EQL: Fix CPS index options for PIT (elastic#138800)

Author: luigidellaquila

x-pack/plugin/eql/src/main/java/org/elasticsearch/xpack/eql/execution/search/BasicQueryClient.java

@@ -76,7 +76,8 @@ protected void search(SearchRequest search, boolean allowPartialSearchResults, A
             log.trace("About to execute query {} on {}", StringUtils.toString(search.source()), indices);
         }
 
-        if (cfg.crossProjectEnabled()) {
+        // PIT contains the options already, and _search won't accept them a second time
+        if (usingPit() == false && cfg.crossProjectEnabled()) {
             search.indicesOptions(CrossProjectIndexResolutionValidator.indicesOptionsForCrossProjectFanout(search.indicesOptions()));
         }
         client.search(search, listener);
@@ -95,7 +96,8 @@ protected void search(MultiSearchRequest search, boolean allowPartialSearchResul
             }
             log.trace("About to execute multi-queries {} on {}", sj, indices);
         }
-        if (cfg.crossProjectEnabled()) {
+        // PIT contains the options already, and _search won't accept them a second time
+        if (usingPit() == false && cfg.crossProjectEnabled()) {
             search.indicesOptions(CrossProjectIndexResolutionValidator.indicesOptionsForCrossProjectFanout(search.indicesOptions()));
         }
         client.multiSearch(search, multiSearchLogListener(listener, allowPartialSearchResults, log));
@@ -196,4 +198,8 @@ public void multiQuery(List<SearchRequest> searches, ActionListener<MultiSearchR
         }
         search(multiSearchBuilder.request(), allowPartialSearchResults, listener);
     }
+
+    protected boolean usingPit() {
+        return false;
+    }
 }

x-pack/plugin/eql/src/main/java/org/elasticsearch/xpack/eql/execution/search/PITAwareQueryClient.java

@@ -165,4 +165,9 @@ public void close(ActionListener<Boolean> listener) {
             pitId = null;
         }
     }
+
+    @Override
+    protected boolean usingPit() {
+        return true;
+    }
 }