chore: fix linting

Author: msand

android/build.gradle

@@ -4,11 +4,12 @@ def safeExtGet(prop, fallback) {
 
 buildscript {
     repositories {
+        google()
         jcenter()
     }
 
     dependencies {
-        classpath 'com.android.tools.build:gradle:2.2.3'
+        classpath 'com.android.tools.build:gradle:3.5.2'
     }
 }
 
@@ -37,5 +38,6 @@ repositories {
 }
 
 dependencies {
+    //noinspection GradleDynamicVersion
     implementation 'com.facebook.react:react-native:+'
 }

android/src/main/AndroidManifest.xml

@@ -1,4 +1,2 @@
 <?xml version="1.0" encoding="utf-8"?>
-<manifest xmlns:android="http://schemas.android.com/apk/res/android"
-    package="com.cmcewen.blurview" >
-</manifest>
+<manifest package="com.cmcewen.blurview" />

android/src/main/java/com/cmcewen/blurview/BlurViewManager.java

@@ -2,27 +2,29 @@
 
 import android.view.View;
 
-import com.facebook.react.bridge.ReactMethod;
 import com.facebook.react.uimanager.SimpleViewManager;
 import com.facebook.react.uimanager.ThemedReactContext;
 import com.facebook.react.uimanager.annotations.ReactProp;
 
+import javax.annotation.Nonnull;
 
-public class BlurViewManager extends SimpleViewManager<BlurringView> {
-    public static final String REACT_CLASS = "BlurView";
 
-    public static final int defaultRadius = 10;
-    public static final int defaultSampling = 10;
+@SuppressWarnings("unused")
+class BlurViewManager extends SimpleViewManager<BlurringView> {
+    private static final String REACT_CLASS = "BlurView";
+
+    private static final int defaultRadius = 10;
+    private static final int defaultSampling = 10;
 
     private static ThemedReactContext context;
 
     @Override
-    public String getName() {
+    public @Nonnull String getName() {
         return REACT_CLASS;
     }
 
     @Override
-    public BlurringView createViewInstance(ThemedReactContext ctx) {
+    public @Nonnull BlurringView createViewInstance(@Nonnull ThemedReactContext ctx) {
         context = ctx;
 
         BlurringView blurringView = new BlurringView(ctx);

android/src/main/java/com/cmcewen/blurview/BlurViewPackage.java

@@ -1,32 +1,33 @@
 package com.cmcewen.blurview;
 
-import android.app.Activity;
-
 import com.facebook.react.ReactPackage;
 import com.facebook.react.bridge.JavaScriptModule;
 import com.facebook.react.bridge.NativeModule;
 import com.facebook.react.bridge.ReactApplicationContext;
 import com.facebook.react.uimanager.ViewManager;
 
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.Collections;
 import java.util.List;
 
+import javax.annotation.Nonnull;
+
 public class BlurViewPackage implements ReactPackage {
     @Override
-    public List<NativeModule> createNativeModules(ReactApplicationContext reactApplicationContext) {
-        List<NativeModule> modules = new ArrayList<>();
-        return modules;
+    @Nonnull
+    public List<NativeModule> createNativeModules(@Nonnull ReactApplicationContext reactApplicationContext) {
+        return new ArrayList<>();
     }
 
+    @SuppressWarnings("unused")
     public List<Class<? extends JavaScriptModule>> createJSModules() {
         return Collections.emptyList();
     }
 
     @Override
-    public List<ViewManager> createViewManagers(ReactApplicationContext reactContext) {
-        return Arrays.<ViewManager>asList(
+    @Nonnull
+    public List<ViewManager> createViewManagers(@Nonnull ReactApplicationContext reactContext) {
+        return Collections.<ViewManager>singletonList(
                 new BlurViewManager()
         );
     }

android/src/main/java/com/cmcewen/blurview/BlurringView.java

@@ -30,7 +30,7 @@ public BlurringView(ThemedReactContext context) {
         this(context, null);
     }
 
-    public BlurringView(ThemedReactContext context, AttributeSet attrs) {
+    public BlurringView(Context context, AttributeSet attrs) {
         super(context, attrs);
 
         final Resources res = getResources();
@@ -40,11 +40,11 @@ public BlurringView(ThemedReactContext context, AttributeSet attrs) {
 
         initializeRenderScript(context);
 
-        TypedArray a = context.obtainStyledAttributes(attrs, R.styleable.PxBlurringView);
-        setBlurRadius(a.getInt(R.styleable.PxBlurringView_blurRadius, defaultBlurRadius));
-        setDownsampleFactor(a.getInt(R.styleable.PxBlurringView_downsampleFactor,
+        TypedArray a = context.obtainStyledAttributes(attrs, R.styleable.BlurringView);
+        setBlurRadius(a.getInt(R.styleable.BlurringView_blurRadius, defaultBlurRadius));
+        setDownsampleFactor(a.getInt(R.styleable.BlurringView_downsampleFactor,
                 defaultDownsampleFactor));
-        setOverlayColor(a.getColor(R.styleable.PxBlurringView_overlayColor, defaultOverlayColor));
+        setOverlayColor(a.getColor(R.styleable.BlurringView_overlayColor, defaultOverlayColor));
         a.recycle();
     }
 
@@ -111,7 +111,7 @@ private void initializeRenderScript(Context context) {
         mBlurScript = ScriptIntrinsicBlur.create(mRenderScript, Element.U8_4(mRenderScript));
     }
 
-    protected boolean prepare() {
+    private boolean prepare() {
         final int width = mBlurredView.getWidth();
         final int height = mBlurredView.getHeight();
 
@@ -156,7 +156,7 @@ protected boolean prepare() {
         return true;
     }
 
-    protected void blur() {
+    private void blur() {
         mBlurInput.copyFrom(mBitmapToBlur);
         mBlurScript.setInput(mBlurInput);
         mBlurScript.forEach(mBlurOutput);
@@ -182,7 +182,7 @@ private void checkForCircularReference() {
         // Need to wait until blurredView is set and the view is attached to window.
         if (mBlurredView == null || getParent() == null) return;
 
-        Boolean circularReference = (mBlurredView.findViewById(getId()) != null);
+        boolean circularReference = (mBlurredView.findViewById(getId()) != null);
         if (circularReference) {
             ThemedReactContext reactContext = (ThemedReactContext) getContext();
             reactContext.getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter.class)
@@ -191,14 +191,13 @@ private void checkForCircularReference() {
 
             setBlurredView(null);
             invalidate();
-            return;
         }
     }
 
     private int mDownsampleFactor;
     private int mOverlayColor;
 
-    protected View mBlurredView;
+    private View mBlurredView;
     private int mBlurredViewWidth, mBlurredViewHeight;
 
     private boolean mDownsampleFactorChanged;

android/src/main/res/values/attr.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources>
-    <declare-styleable name="PxBlurringView">
+    <declare-styleable name="BlurringView">
         <attr name="blurRadius" format="integer"/>
         <attr name="downsampleFactor" format="integer"/>
         <attr name="overlayColor" format="color"/>

example/android/build.gradle

@@ -3,7 +3,7 @@
 buildscript {
     ext {
         buildToolsVersion = "28.0.3"
-        minSdkVersion = 16
+        minSdkVersion = 17
         compileSdkVersion = 28
         targetSdkVersion = 28
         supportLibVersion = "28.0.0"
@@ -13,7 +13,7 @@ buildscript {
         jcenter()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:3.3.1'
+        classpath 'com.android.tools.build:gradle:3.5.2'
 
         // NOTE: Do not place your application dependencies here; they belong
         // in the individual module build.gradle files

example/android/gradle/wrapper/gradle-wrapper.properties

@@ -1,5 +1,6 @@
+#Sat Nov 09 00:42:16 EET 2019
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.2-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-5.4.1-all.zip