drivers: intc: nxp_pint: fix off-by-one error in pin_enable

kartben · kartben · commit 48a1a2a24857 · 2025-06-21T10:40:28.000+02:00
Prevent out-of-bounds access in nxp_pint_pin_enable by fixing the
comparison to use &gt;= instead of &gt;.

Signed-off-by: Benjamin Cabé &lt;benjamin@zephyrproject.org&gt;
diff --git a/drivers/interrupt_controller/intc_nxp_pint.c b/drivers/interrupt_controller/intc_nxp_pint.c
@@ -69,7 +69,7 @@ int nxp_pint_pin_enable(uint8_t pin, enum nxp_pint_trigger trigger, bool wake)
 {
 	uint8_t slot = 0U;
 
-	if (pin > ARRAY_SIZE(pin_pint_id)) {
+	if (pin >= ARRAY_SIZE(pin_pint_id)) {
 		/* Invalid pin ID */
 		return -EINVAL;
 	}

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ int nxp_pint_pin_enable(uint8_t pin, enum nxp_pint_trigger trigger, bool wake)`
`69`	`69`	`{`
`70`	`70`	`uint8_t slot = 0U;`
`71`	`71`
`72`		`- if (pin > ARRAY_SIZE(pin_pint_id)) {`
	`72`	`+ if (pin >= ARRAY_SIZE(pin_pint_id)) {`
`73`	`73`	`/* Invalid pin ID */`
`74`	`74`	`return -EINVAL;`
`75`	`75`	`}`