Remove unnecessary optional return type

Author: KurtWagner

src/lib/ast.zig

@@ -219,13 +219,13 @@ test "deferBlock - has expected children" {
         var tmp = std.testing.tmpDir(.{});
         defer tmp.cleanup();
 
-        var doc = (try testing.loadFakeDocument(
+        var doc = try testing.loadFakeDocument(
             &ctx,
             tmp.dir,
             "test.zig",
             "fn main() void {\n" ++ source ++ "\n}",
             arena.allocator(),
-        )).?;
+        );
         defer doc.deinit(arena.allocator());
 
         const decl_ref = try deferBlock(

src/lib/session.zig

@@ -620,13 +620,13 @@ test "LintDocument.isEnclosedInTestBlock" {
         \\}
     ;
 
-    var doc = (try testing.loadFakeDocument(
+    var doc = try testing.loadFakeDocument(
         &ctx,
         tmp.dir,
         "test.zig",
         source,
         arena.allocator(),
-    )).?;
+    );
     defer doc.deinit(ctx.gpa);
 
     try std.testing.expect(
@@ -988,13 +988,13 @@ test "LintDocument.resolveTypeKind" {
         var arena = std.heap.ArenaAllocator.init(std.testing.allocator);
         defer arena.deinit();
 
-        var doc = (try testing.loadFakeDocument(
+        var doc = try testing.loadFakeDocument(
             &ctx,
             tmp.dir,
             "test.zig",
             test_case.contents,
             arena.allocator(),
-        )).?;
+        );
         defer doc.deinit(ctx.gpa);
 
         const node = doc.handle.tree.rootDecls()[0];

src/lib/testing.zig

@@ -7,7 +7,7 @@ pub fn loadFakeDocument(
     file_name: []const u8,
     contents: [:0]const u8,
     arena: std.mem.Allocator,
-) !?LintDocument {
+) !LintDocument {
     assertTestOnly();
 
     if (std.fs.path.dirname(file_name)) |dir_name|
@@ -214,13 +214,13 @@ fn runRule(rule: LintRule, file_name: []const u8, contents: [:0]const u8, option
     var arena = std.heap.ArenaAllocator.init(std.testing.allocator);
     defer arena.deinit();
 
-    var doc = (try loadFakeDocument(
+    var doc = try loadFakeDocument(
         &ctx,
         tmp.dir,
         file_name,
         contents,
         arena.allocator(),
-    )).?;
+    );
     defer doc.deinit(ctx.gpa);
 
     const tree = doc.handle.tree;
@@ -388,13 +388,13 @@ pub fn initDocForTesting(
     const doc = try arena.create(LintDocument);
     errdefer arena.destroy(doc);
 
-    doc.* = (try loadFakeDocument(
+    doc.* = try loadFakeDocument(
         ctx,
         tmp.dir,
         "test.zig",
         source,
         arena,
-    )).?;
+    );
 
     return doc;
 }

src/rules/require_errdefer_dealloc.zig

@@ -399,13 +399,13 @@ test "hasNonFreeingAllocatorParam" {
         var tmp = std.testing.tmpDir(.{});
         defer tmp.cleanup();
 
-        var doc = (try zlinter.testing.loadFakeDocument(
+        var doc = try zlinter.testing.loadFakeDocument(
             &ctx,
             tmp.dir,
             "test.zig",
             "fn main() void {\n" ++ source ++ "\n}",
             arena.allocator(),
-        )).?;
+        );
         defer doc.deinit(ctx.gpa);
 
         const tree = doc.handle.tree;