feat: skip destroy imported resources (#1239)

Author: hoangndst

pkg/apis/api.kusion.io/v1/types.go

@@ -251,15 +251,18 @@ const (
 	BackendTypeOss   = "oss"
 	BackendTypeS3    = "s3"
 
-	EnvOssAccessKeyID     = "OSS_ACCESS_KEY_ID"
-	EnvOssAccessKeySecret = "OSS_ACCESS_KEY_SECRET"
-	EnvAwsAccessKeyID     = "AWS_ACCESS_KEY_ID"
-	EnvAwsSecretAccessKey = "AWS_SECRET_ACCESS_KEY"
-	EnvAwsDefaultRegion   = "AWS_DEFAULT_REGION"
-	EnvAwsRegion          = "AWS_REGION"
-	EnvAlicloudAccessKey  = "ALICLOUD_ACCESS_KEY"
-	EnvAlicloudSecretKey  = "ALICLOUD_SECRET_KEY"
-	EnvAlicloudRegion     = "ALICLOUD_REGION"
+	EnvOssAccessKeyID        = "OSS_ACCESS_KEY_ID"
+	EnvOssAccessKeySecret    = "OSS_ACCESS_KEY_SECRET"
+	EnvAwsAccessKeyID        = "AWS_ACCESS_KEY_ID"
+	EnvAwsSecretAccessKey    = "AWS_SECRET_ACCESS_KEY"
+	EnvAwsDefaultRegion      = "AWS_DEFAULT_REGION"
+	EnvAwsRegion             = "AWS_REGION"
+	EnvAlicloudAccessKey     = "ALICLOUD_ACCESS_KEY"
+	EnvAlicloudSecretKey     = "ALICLOUD_SECRET_KEY"
+	EnvAlicloudRegion        = "ALICLOUD_REGION"
+	EnvViettelCloudCmpURL    = "VIETTEL_CLOUD_CMP_URL"
+	EnvViettelCloudUserToken = "VIETTEL_CLOUD_USER_TOKEN"
+	EnvViettelCloudProjectID = "VIETTEL_CLOUD_PROJECT_ID"
 
 	FieldImportedResources = "importedResources"
 )

pkg/engine/operation/graph/resource_node.go

@@ -205,6 +205,12 @@ func (rn *ResourceNode) computeActionType(
 	switch operation.OperationType {
 	case models.Destroy, models.DestroyPreview:
 		rn.Action = models.Delete
+		if planedResource != nil {
+			importID, ok := planedResource.Extensions[tfops.ImportIDKey].(string)
+			if ok && importID != "" {
+				rn.Action = models.UnChanged
+			}
+		}
 	case models.Apply, models.ApplyPreview:
 		if planedResource == nil {
 			rn.Action = models.Delete
@@ -252,7 +258,9 @@ func (rn *ResourceNode) initThreeWayDiffData(operation *models.Operation) (*apiv
 	// When a resource is deleted in Intent but exists in PriorState,
 	// this node should be regarded as a deleted node, and rn.resource stores the PriorState
 	if rn.Action == models.Delete {
-		planedResource = nil
+		if _, ok := planedResource.Extensions[tfops.ImportIDKey].(string); !ok {
+			planedResource = nil
+		}
 	}
 
 	// 2. get prior resource from the latest release

pkg/engine/runtime/terraform/terraform_runtime.go

@@ -190,11 +190,6 @@ func (t *Runtime) Read(ctx context.Context, request *runtime.ReadRequest) *runti
 			DependsOn:  priorResource.DependsOn,
 			Extensions: priorResource.Extensions,
 		}
-
-		// For the resource to be deleted, the 'import_id' attribute in 'Extensions' field should be removed.
-		if _, ok := planResource.Extensions[tfops.ImportIDKey].(string); ok {
-			delete(planResource.Extensions, tfops.ImportIDKey)
-		}
 	}
 
 	var tfState *tfops.StateRepresentation
@@ -216,17 +211,34 @@ func (t *Runtime) Read(ctx context.Context, request *runtime.ReadRequest) *runti
 		}
 	}
 
-	if priorResource == nil {
-		// For resources declared with 'import_id' in the 'Extensions' field,
-		// use 'terraform import' to import the latest state.
-		importID, ok := planResource.Extensions[tfops.ImportIDKey].(string)
-		if ok && importID != "" {
-			if err = ws.ImportResource(ctx, importID); err != nil {
+	importID, ok := planResource.Extensions[tfops.ImportIDKey].(string)
+	if ok && importID != "" {
+		if err = ws.ImportResource(ctx, importID); err != nil {
+			return &runtime.ReadResponse{Resource: nil, Status: v1.NewErrorStatus(err)}
+		} else {
+			// read resource from tfstate
+			tfState, err = ws.ShowState(ctx)
+			if err != nil {
 				return &runtime.ReadResponse{Resource: nil, Status: v1.NewErrorStatus(err)}
 			}
-		} else {
-			return &runtime.ReadResponse{Resource: nil, Status: nil}
+			// get terraform provider version
+			providerAddr, err := ws.GetProvider()
+			if err != nil {
+				return &runtime.ReadResponse{Resource: nil, Status: v1.NewErrorStatus(err)}
+			}
+			r := tfops.ConvertTFState(tfState, providerAddr)
+			return &runtime.ReadResponse{
+				Resource: &apiv1.Resource{
+					ID:         planResource.ID,
+					Type:       planResource.Type,
+					Attributes: r.Attributes,
+					DependsOn:  planResource.DependsOn,
+					Extensions: planResource.Extensions,
+				}, Status: nil,
+			}
 		}
+	} else if priorResource == nil {
+		return &runtime.ReadResponse{Resource: nil, Status: nil}
 	} else if err = ws.WriteTFState(priorResource); err != nil {
 		// priorResource overwrite tfState in workspace
 		return &runtime.ReadResponse{Resource: nil, Status: v1.NewErrorStatus(err)}

pkg/engine/runtime/terraform/tfops/workspace.go

@@ -576,6 +576,30 @@ func (w *WorkSpace) getEnvProviderInfo() ([]string, error) {
 		envs = append(envs, fmt.Sprintf("%s=%s", v1.EnvAlicloudRegion, alicloudRegion))
 	}
 
+	viettelCloudCmpURL, err := workspace.GetStringFromGenericConfig(context, v1.EnvViettelCloudCmpURL)
+	if err != nil {
+		return nil, err
+	}
+	if viettelCloudCmpURL != "" {
+		envs = append(envs, fmt.Sprintf("%s=%s", v1.EnvViettelCloudCmpURL, viettelCloudCmpURL))
+	}
+
+	viettelCloudUserToken, err := workspace.GetStringFromGenericConfig(context, v1.EnvViettelCloudUserToken)
+	if err != nil {
+		return nil, err
+	}
+	if viettelCloudUserToken != "" {
+		envs = append(envs, fmt.Sprintf("%s=%s", v1.EnvViettelCloudUserToken, viettelCloudUserToken))
+	}
+
+	viettelCloudProjectID, err := workspace.GetStringFromGenericConfig(context, v1.EnvViettelCloudProjectID)
+	if err != nil {
+		return nil, err
+	}
+	if viettelCloudProjectID != "" {
+		envs = append(envs, fmt.Sprintf("%s=%s", v1.EnvViettelCloudProjectID, viettelCloudProjectID))
+	}
+
 	return envs, nil
 }