Contributing/refactoring

[msmorgan]

I forked your repository yesterday, planning to submit a data update and get Bucklers working properly (the defenses aren't considered like with other shields). Do you accept pull requests like this?

I encountered some friction getting the dataParser working from a fresh checkout. This was partly due to scattered/incomplete documentation, but also

• No requirements.txt (forcing me to install dependencies as Python imports failed)
• Missing .gitkeep files for language directories that are expected to exist
• Use of Bash scripts instead of the two other scripting languages already in use

I prefer to refactor as I go, and I'd like to fix these and other issues to help the next person who comes along. I'll add the missing files, remove the dependency on Bash by rewriting the scripts (this can be JS, Python, or directly in package.json), and update the docs.

If you expect to pull upstream changes from Awakened PoE Trade for the dataParser module, my proposed modifications could make that more difficult. I'll stick to the Buckler fix only if you prefer. (They'd be separate pull requests if you want both.)

[Kvan7]

Do you accept pull requests like this?

Yes but not in the actual data, it would have to be in dataParser itself, ie not just editing the ndjson files directly

yeah its in pretty poor shape right now. I have been working on completely rewriting it from scratch for the past month and a half or so actually, hopefully it will be done before the update later this week