chore: remove unnecessary mutex in dodo

Author: lehainam-dev

pkg/liquidity-source/dodo/dpp/pool_simulator.go

@@ -4,7 +4,6 @@ import (
 	"math/big"
 	"slices"
 	"strings"
-	"sync"
 
 	"github.com/KyberNetwork/blockchain-toolkit/integer"
 	"github.com/KyberNetwork/blockchain-toolkit/number"
@@ -19,7 +18,6 @@ import (
 )
 
 type PoolSimulator struct {
-	*sync.RWMutex
 	pool.Pool
 	libv2.PMMState
 	Meta shared.V2Meta
@@ -78,7 +76,6 @@ func NewPoolSimulator(entityPool entity.Pool) (*PoolSimulator, error) {
 	}
 
 	return &PoolSimulator{
-		RWMutex: &sync.RWMutex{},
 		Pool: pool.Pool{
 			Info: info,
 		},
@@ -148,7 +145,6 @@ func (p *PoolSimulator) CalcAmountOut(param pool.CalcAmountOutParams) (*pool.Cal
 
 func (p *PoolSimulator) CloneState() pool.IPoolSimulator {
 	cloned := *p
-	cloned.RWMutex = &sync.RWMutex{}
 	cloned.Info.Reserves = slices.Clone(p.Info.Reserves)
 	return &cloned
 }

pkg/liquidity-source/dodo/dpp/storage.go

@@ -9,9 +9,6 @@ import (
 
 // https://github.com/DODOEX/contractV2/blob/c58c067c4038437610a9cc8aef8f8025e2af4f63/contracts/DODOPrivatePool/impl/DPPStorage.sol#L51
 func (p *PoolSimulator) getPMMState() libv2.PMMState {
-	p.Lock()
-	defer p.Unlock()
-
 	libv2.AdjustedTarget(&p.PMMState)
 	return p.PMMState
 }

pkg/liquidity-source/dodo/dsp/pool_simulator.go

@@ -4,7 +4,6 @@ import (
 	"math/big"
 	"slices"
 	"strings"
-	"sync"
 
 	"github.com/KyberNetwork/blockchain-toolkit/integer"
 	"github.com/KyberNetwork/blockchain-toolkit/number"
@@ -19,7 +18,6 @@ import (
 )
 
 type PoolSimulator struct {
-	*sync.RWMutex
 	pool.Pool
 	libv2.PMMState
 	Meta shared.V2Meta
@@ -78,7 +76,6 @@ func NewPoolSimulator(entityPool entity.Pool) (*PoolSimulator, error) {
 	}
 
 	return &PoolSimulator{
-		RWMutex: &sync.RWMutex{},
 		Pool: pool.Pool{
 			Info: info,
 		},
@@ -148,7 +145,6 @@ func (p *PoolSimulator) CalcAmountOut(param pool.CalcAmountOutParams) (*pool.Cal
 
 func (p *PoolSimulator) CloneState() pool.IPoolSimulator {
 	cloned := *p
-	cloned.RWMutex = &sync.RWMutex{}
 	cloned.Info.Reserves = slices.Clone(p.Info.Reserves)
 	return &cloned
 }

pkg/liquidity-source/dodo/dsp/storage.go

@@ -9,9 +9,6 @@ import (
 
 // https://github.com/DODOEX/contractV2/blob/c58c067c4038437610a9cc8aef8f8025e2af4f63/contracts/DODOStablePool/impl/DSPStorage.sol#L70
 func (p *PoolSimulator) getPMMState() libv2.PMMState {
-	p.Lock()
-	defer p.Unlock()
-
 	libv2.AdjustedTarget(&p.PMMState)
 	return p.PMMState
 }

pkg/liquidity-source/dodo/dvm/pool_simulator.go

@@ -4,7 +4,6 @@ import (
 	"math/big"
 	"slices"
 	"strings"
-	"sync"
 
 	"github.com/KyberNetwork/blockchain-toolkit/integer"
 	"github.com/KyberNetwork/blockchain-toolkit/number"
@@ -19,7 +18,6 @@ import (
 )
 
 type PoolSimulator struct {
-	*sync.RWMutex
 	pool.Pool
 	libv2.PMMState
 	Meta shared.V2Meta
@@ -78,7 +76,6 @@ func NewPoolSimulator(entityPool entity.Pool) (*PoolSimulator, error) {
 	}
 
 	return &PoolSimulator{
-		RWMutex: &sync.RWMutex{},
 		Pool: pool.Pool{
 			Info: info,
 		},
@@ -148,7 +145,6 @@ func (p *PoolSimulator) CalcAmountOut(param pool.CalcAmountOutParams) (*pool.Cal
 
 func (p *PoolSimulator) CloneState() pool.IPoolSimulator {
 	cloned := *p
-	cloned.RWMutex = &sync.RWMutex{}
 	cloned.Info.Reserves = slices.Clone(p.Info.Reserves)
 	return &cloned
 }

pkg/liquidity-source/dodo/dvm/storage.go

@@ -9,9 +9,6 @@ import (
 
 // https://github.com/DODOEX/contractV2/blob/c58c067c4038437610a9cc8aef8f8025e2af4f63/contracts/DODOVendingMachine/impl/DVMStorage.sol#L66
 func (p *PoolSimulator) getPMMState() libv2.PMMState {
-	p.Lock()
-	defer p.Unlock()
-
 	libv2.AdjustedTarget(&p.PMMState)
 	return p.PMMState
 }