add PR comments - Dessy

ilanDoron · ilanDoron · commit 4fc962933e82 · 2020-07-22T13:32:55.000+03:00
diff --git a/contracts/reserves/fprConversionRate/ConversionRateEnhancedSteps.sol b/contracts/reserves/fprConversionRate/ConversionRateEnhancedSteps.sol
@@ -12,7 +12,7 @@ import "./ConversionRates.sol";
 
 contract ConversionRateEnhancedSteps is ConversionRates {
 
-    uint  constant internal MAX_RATE  = (PRECISION * 10**7); // up to 10M tokens per ETH
+    uint  constant internal MAX_RATE = (PRECISION * 10 ** 7); // up to 10M tokens per ETH
     uint constant internal MAX_STEPS_IN_FUNCTION = 16;
     int constant internal MAX_IMBALANCE = 2 ** 255 - 1;
     uint constant internal POW_2_128 = 2 ** 128;
@@ -276,6 +276,7 @@ contract ConversionRateEnhancedSteps is ConversionRates {
                 change += (stepXValue - fromVal) * stepYValue;
                 fromVal = stepXValue;
             }
+            // max change < MAX_QTY * BPS * 16 = (10 ** 28) * 10000 * 16 = 1.6e33
         }
 
         return change / (to - from);

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ import "./ConversionRates.sol";`
`12`	`12`
`13`	`13`	`contract ConversionRateEnhancedSteps is ConversionRates {`
`14`	`14`
`15`		`- uint constant internal MAX_RATE = (PRECISION * 10**7); // up to 10M tokens per ETH`
	`15`	`+ uint constant internal MAX_RATE = (PRECISION * 10 ** 7); // up to 10M tokens per ETH`
`16`	`16`	`uint constant internal MAX_STEPS_IN_FUNCTION = 16;`
`17`	`17`	`int constant internal MAX_IMBALANCE = 2 ** 255 - 1;`
`18`	`18`	`uint constant internal POW_2_128 = 2 ** 128;`
`@@ -276,6 +276,7 @@ contract ConversionRateEnhancedSteps is ConversionRates {`
`276`	`276`	`change += (stepXValue - fromVal) * stepYValue;`
`277`	`277`	`fromVal = stepXValue;`
`278`	`278`	`}`
	`279`	`+ // max change < MAX_QTY * BPS * 16 = (10 ** 28) * 10000 * 16 = 1.6e33`
`279`	`280`	`}`
`280`	`281`
`281`	`282`	`return change / (to - from);`