Skip to content

Commit 5ec67e4

Browse files
ayobuenavistailanDoron
authored andcommitted
update solhint setting to enforce more strict linting checks by CI. At this stage will apply only to new solidity folders.
1 parent 36ff315 commit 5ec67e4

File tree

3 files changed

+38
-12
lines changed

3 files changed

+38
-12
lines changed

.solhint.json

Lines changed: 30 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,35 @@
11
{
2-
"extends": "solhint:default",
2+
"extends": "solhint:recommended",
3+
"plugins": [],
34
"rules": {
4-
"quotes": ["error", "double"],
5+
"avoid-call-value": "error",
6+
"avoid-low-level-calls": "off",
7+
"avoid-sha3": "error",
58
"avoid-suicide": "error",
6-
"avoid-sha3": "warn",
7-
"avoid-tx-origin": "warn",
8-
"const-name-snakecase": "off",
9-
"func-order": "warn",
10-
"not-rely-on-block-hash": "warn"
9+
"avoid-throw": "error",
10+
"avoid-tx-origin": "off",
11+
"check-send-result": "error",
12+
"compiler-version": ["error", "0.6.6"],
13+
"const-name-snakecase": "error",
14+
"func-name-mixedcase": "error",
15+
"func-order": "error",
16+
"imports-on-top": "error",
17+
"mark-callable-contracts": "error",
18+
"max-line-length": ["error", 99],
19+
"max-states-count": ["error", 20],
20+
"multiple-sends": "error",
21+
"no-complex-fallback": "error",
22+
"no-empty-blocks": "off",
23+
"no-inline-assembly": "error",
24+
"no-unused-vars": "error",
25+
"not-rely-on-block-hash": "error",
26+
"not-rely-on-time": "off",
27+
"payable-fallback": "error",
28+
"quotes": ["error","double"],
29+
"reentrancy": "error",
30+
"state-visibility": "error",
31+
"use-forbidden-name": "error",
32+
"var-name-mixedcase": "error",
33+
"visibility-modifier-order": "error"
1134
}
1235
}

.solhintignore

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
1-
# zeppelin contracts
2-
contracts/sol6/utils/zeppelin
3-
contracts/sol5/bridges
4-
1+
contracts/sol4
2+
contracts/sol5
3+
contracts/sol6/Dao
4+
contracts/sol6/mock
5+
contracts/sol6/utils
6+
contracts/sol6/wrappers
7+
contracts/sol6/*.sol

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ install:
2222
- npm ci
2323

2424
before_script:
25-
- npx solhint contracts/sol6/**/*.sol
25+
- npx solhint "contracts/sol6/**/*.sol"
2626

2727
script:
2828
- ./cmp.sh

0 commit comments

Comments
 (0)