update according to review comments

Author: ilanDoron

contracts/wrappers/SetStepFunctionWrapper.sol

@@ -25,16 +25,17 @@ contract SetStepFunctionWrapper2 is Withdrawable {
         rateContract = _contract;
     }
 
-    function setImbalanceStepFunction(ERC20 token,
+    function setImbalanceStepFunction(
+        ERC20 token,
         int[] xBuy,
         int[] yBuy,
         int[] xSell,
         int[] ySell)
-    public onlyOperator
+        public onlyOperator
     {
         uint i;
 
-        // check all x for buy are positiv
+        // check all x for buy are positive
         for( i = 0 ; i < xBuy.length ; i++ ) {
             require(xBuy[i] >= 0 );
         }

web3deployment/compileContracts.js

@@ -6,6 +6,9 @@ const input = {
     "ConversionRates.sol" : fs.readFileSync(contractPath + 'reserves/fprConversionRate/ConversionRates.sol','utf8'),
     "EnhancedStepFunctions.sol" : fs.readFileSync(contractPath + 'reserves/fprConversionRate/EnhancedStepFunctions.sol', 'utf8'),
     "ConversionRatesInterface.sol" : fs.readFileSync(contractPath + 'ConversionRatesInterface.sol', 'utf8'),
+    "reserves/fprConversionRate/ConversionRates.sol" : fs.readFileSync(contractPath + 'reserves/fprConversionRate/ConversionRates.sol','utf8'),
+    "reserves/VolumeImbalanceRecorder.sol" : fs.readFileSync(contractPath + 'reserves/VolumeImbalanceRecorder.sol', 'utf8'),
+    "VolumeImbalanceRecorder.sol" : fs.readFileSync(contractPath + 'reserves/VolumeImbalanceRecorder.sol', 'utf8'),
     "PermissionGroups.sol" : fs.readFileSync(contractPath + 'PermissionGroups.sol', 'utf8'),
     "ERC20Interface.sol" : fs.readFileSync(contractPath + 'ERC20Interface.sol', 'utf8'),
     "ExpectedRate.sol" : fs.readFileSync(contractPath + 'ExpectedRate.sol', 'utf8'),
@@ -36,15 +39,13 @@ const input = {
     "Utils.sol" : fs.readFileSync(contractPath + 'Utils.sol', 'utf8'),
     "Utils2.sol" : fs.readFileSync(contractPath + 'Utils2.sol', 'utf8'),
     "Utils3.sol" : fs.readFileSync(contractPath + 'Utils3.sol', 'utf8'),
-    "reserves/fprConversionRate/ConversionRates.sol" : fs.readFileSync(contractPath + 'reserves/fprConversionRate/ConversionRates.sol','utf8'),
-    "reserves/VolumeImbalanceRecorder.sol" : fs.readFileSync(contractPath + 'reserves/VolumeImbalanceRecorder.sol', 'utf8'),
     "Withdrawable.sol" : fs.readFileSync(contractPath + 'Withdrawable.sol', 'utf8'),
     "WhiteList.sol" : fs.readFileSync(contractPath + 'WhiteList.sol', 'utf8'),
     "WhiteListInterface.sol" : fs.readFileSync(contractPath + 'WhiteListInterface.sol', 'utf8'),
     "WrapFeeBurner.sol" : fs.readFileSync(contractPath + 'wrappers/WrapFeeBurner.sol', 'utf8'),
     "KyberUniswapReserve.sol" : fs.readFileSync(contractPath + 'reserves/bridgeReserves/uniswap/KyberUniswapReserve.sol', 'utf8'),
     "WrapperBase.sol" : fs.readFileSync(contractPath + 'wrappers/WrapperBase.sol', 'utf8'),
-    "SetStepFunctionWrapper.sol" : fs.readFileSync(contractPath + 'wrappers/SetStepFunctionWrapper.sol', 'utf8')
+    "SetStepFunctionWrapper.sol" : fs.readFileSync(contractPath + 'wrappers/SetStepFunctionWrapper.sol', 'utf8'),
     "WrapConversionRate.sol" : fs.readFileSync(contractPath + 'wrappers/WrapConversionRate.sol', 'utf8'),
     "WrapReadTokenData.sol" : fs.readFileSync(contractPath + 'wrappers/WrapReadTokenData.sol', 'utf8')
   };

web3deployment/reserveEnhancedSteps.js renamed to web3deployment/reserveEnhancedStepsDeployer.js

@@ -187,6 +187,7 @@ async function main() {
     console.log('chainId', chainId);
     console.log('starting compilation');
     output = await require("./compileContracts.js").compileContracts();
+    console.log(output.errors)
     console.log("finished compilation");
 
     if (!dontSendTx) {
@@ -210,15 +211,22 @@ async function main() {
 
     console.log("wrapperAddress", wrapperAddress);
 
+    let stepsSetterContract;
+    let stepsSetterAddress;
+
+    console.log("deploying step function setter.");
+    [stepsSetterAddress, stepsSetterContract] = await deployContract(output, "WrapConversionRate.sol:WrapConversionRate", [conversionRatesAddress]);
+
     operators = ['0xF76d38Da26c0c0a4ce8344370D7Ae4c34B031dea','0xf3d872b9e8d314820dc8e99dafbe1a3feedc27d5']
     admin = '0xf3d872b9e8d314820dc8e99dafbe1a3feedc27d5';
 
     await setPermissions(reserveContract, operators, operators, admin);
     await setPermissions(wrapperContract, operators, operators, admin);
+    await setPermissions(stepsSetterContract, operators, operators, admin);
 
-    operators[2] = wrapperAddress;
+    operators.push(stepsSetterAddress);
     await setPermissions(conversionRatesContract, operators, operators, admin);
-
+console.log(operators)
     console.log("done for now...")
 return;