[Don't pull] - Math manual review comments for KyberNetwork.sol on Katalyst #1010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* As part of infrastructure work to enable kyberFeeHandler to work with multiple fee tokens, add token parameter to event feeDistributed in kyberFeeHandler
add test for missing event
- update test
…uggy. Can immediately deploy emergency fee handle which will collect fees till the bug is fixed. * add EmergencyFeeHandler contract that supports IKyberFeeHandler interface.
Update due to changes from other PRs Staking no longer need to be manually deployed Add setHintHandler
Fix deployment script
ilanDoron
force-pushed
the
Katalyst
branch
2 times, most recently
from
a757be7 to
d7a026d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.