Skip to content

Commit 4a73590

Browse files
authored
Merge pull request #38 from KyberNetwork/fix-action-data-hash
fix: ActionData type hash
2 parents b3a04ef + 47f01b6 commit 4a73590

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

.github/workflows/lint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
submodules: recursive
1919

2020
- name: Install Foundry
21-
uses: foundry-rs/foundry-toolchain@v1
21+
uses: KyberNetwork/foundry-toolchain@master
2222
with:
2323
version: v1.3.0
2424

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
submodules: recursive
2323

2424
- name: Install Foundry
25-
uses: foundry-rs/foundry-toolchain@v1
25+
uses: KyberNetwork/foundry-toolchain@master
2626
with:
2727
version: v1.3.0
2828

src/types/ActionData.sol

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ using ActionDataLibrary for ActionData global;
4242
library ActionDataLibrary {
4343
bytes32 constant ACTION_DATA_TYPE_HASH = keccak256(
4444
abi.encodePacked(
45-
'ActionData(uint256[] erc20Ids,uint256[] erc20Amounts,uint256[] erc721Ids,uint256 approvalFlags,uint256 actionSelectorId,bytes actionCalldata,bytes hookActionData,bytes extraData,uint256 deadline,uint256 nonce)'
45+
'ActionData(uint256[] erc20Ids,uint256[] erc20Amounts,uint256[] erc721Ids,uint256 feeInfo,address partnerRecipient,uint256 approvalFlags,uint256 actionSelectorId,bytes actionCalldata,bytes hookActionData,bytes extraData,uint256 deadline,uint256 nonce)'
4646
)
4747
);
4848

@@ -53,6 +53,8 @@ library ActionDataLibrary {
5353
keccak256(abi.encodePacked(self.erc20Ids)),
5454
keccak256(abi.encodePacked(self.erc20Amounts)),
5555
keccak256(abi.encodePacked(self.erc721Ids)),
56+
self.feeInfo,
57+
self.partnerRecipient,
5658
self.approvalFlags,
5759
self.actionSelectorId,
5860
keccak256(self.actionCalldata),

0 commit comments

Comments
 (0)