Merge pull request #3 from KyleKincer/transactions

WIP

Author: KyleKincer

CLAUDE.md

@@ -11,6 +11,8 @@ This project provides a complete testing framework for 4D applications featuring
 - **Flexible filtering** - Run specific test subsets by name, pattern, or tags
 - **Multiple output formats** - Human-readable and JSON output with terse/verbose modes
 - **CI/CD ready** - Structured JSON output for automated testing pipelines
+- **Automatic transaction management** - Test isolation with automatic rollback
+- **Manual transaction control** - Full transaction lifecycle management for advanced scenarios
 
 ## Running Tests
 
@@ -92,4 +94,76 @@ testing/Project/Sources/Classes/
 └── [other test classes]
 ```
 
-The framework automatically discovers and runs any class ending with "Test" that contains methods starting with "test_".
+The framework automatically discovers and runs any class ending with "Test" that contains methods starting with "test_".
+
+## Transaction Management
+
+The framework provides automatic transaction management for test isolation and manual transaction control for advanced scenarios.
+
+### Automatic Transaction Management
+
+By default, each test runs in its own transaction that is automatically rolled back after completion, ensuring:
+- **Test Isolation**: Tests cannot interfere with each other's data
+- **Clean Environment**: Database state is restored after each test
+- **No Side Effects**: Failed tests don't leave partial data
+
+### Controlling Transaction Behavior
+
+Use comment-based annotations to control transaction behavior:
+
+```4d
+Function test_withTransactions($t : cs:C1710.Testing)
+    // Automatic transactions enabled (default)
+    // Test data changes will be rolled back
+    
+Function test_withoutTransactions($t : cs:C1710.Testing)  
+    // #transaction: false
+    // Disables automatic transaction management
+```
+
+### Manual Transaction Control
+
+The Testing context provides methods for manual transaction management:
+
+```4d
+Function test_manualTransactions($t : cs:C1710.Testing)
+    // #transaction: false
+    
+    // Start transaction manually
+    $t.startTransaction()
+    
+    // Check transaction status
+    If ($t.inTransaction())
+        // Perform database operations
+    End if
+    
+    // Validate or cancel transaction
+    If ($success)
+        $t.validateTransaction()
+    Else
+        $t.cancelTransaction()  
+    End if
+
+Function test_transactionWrapper($t : cs:C1710.Testing)
+    // #transaction: false
+    
+    // Execute operation within transaction (auto-rollback)
+    var $success : Boolean
+    $success:=$t.withTransaction(Formula(
+        // Database operations here
+        // Will be rolled back automatically
+    ))
+    
+    // Execute operation with validation (persists data)
+    $success:=$t.withTransactionValidate(Formula(
+        // Database operations here  
+        // Will be validated if test succeeds
+    ))
+```
+
+### Transaction Control Comments
+
+| Comment | Effect |
+|---------|--------|
+| `// #transaction: false` | Disables automatic transactions |
+| No comment | Enables automatic transactions (default) |

testing/Project/Sources/Classes/TestRunner.4dm

@@ -1,5 +1,5 @@
 property classStore : 4D:C1709.Object  // Class store from the calling project
-property testSuites : Collection  // Collection of cs.TestSuite
+property testSuites : Collection  // Collection of cs._TestSuite
 property results : Object  // Test results summary
 property outputFormat : Text  // "human" or "json"
 property verboseOutput : Boolean  // Whether to include detailed information
@@ -32,7 +32,7 @@ Function run()
 		This:C1470._logHeader()
 	End if 
 
-	var $testSuite : cs:C1710.TestSuite
+	var $testSuite : cs:C1710._TestSuite
 	For each ($testSuite; This:C1470.testSuites)
 		$testSuite.run()
 		This:C1470._collectSuiteResults($testSuite)
@@ -52,8 +52,8 @@ Function run()
 Function discoverTests()
 	var $class : 4D:C1709.Class
 	For each ($class; This:C1470._getTestClasses())
-		var $testSuite : cs:C1710.TestSuite
-		$testSuite:=cs:C1710.TestSuite.new($class; This:C1470.outputFormat; This:C1470.testPatterns; This:C1470)
+		var $testSuite : cs:C1710._TestSuite
+		$testSuite:=cs:C1710._TestSuite.new($class; This:C1470.outputFormat; This:C1470.testPatterns; This:C1470)
 
 		// Filter test suite based on patterns
 		If (This:C1470._shouldIncludeTestSuite($testSuite))
@@ -114,7 +114,7 @@ Function _logHeader()
 	LOG EVENT:C667(Into system standard outputs:K38:9; "Running tests...\r\n"; Information message:K38:1)
 	LOG EVENT:C667(Into system standard outputs:K38:9; "\r\n"; Information message:K38:1)
 
-Function _collectSuiteResults($testSuite : cs:C1710.TestSuite)
+Function _collectSuiteResults($testSuite : cs:C1710._TestSuite)
 	var $suiteResult : Object
 	$suiteResult:=New object:C1471(\
 		"name"; $testSuite.class.name; \
@@ -123,7 +123,7 @@ Function _collectSuiteResults($testSuite : cs:C1710.TestSuite)
 		"failed"; 0\
 		)
 
-	var $testFunction : cs:C1710.TestFunction
+	var $testFunction : cs:C1710._TestFunction
 	For each ($testFunction; $testSuite.testFunctions)
 		var $testResult : Object
 		$testResult:=$testFunction.getResult()
@@ -319,7 +319,7 @@ Function _parseTestPatterns()
 		End for each 
 	End if 
 
-Function _shouldIncludeTestSuite($testSuite : cs:C1710.TestSuite) : Boolean
+Function _shouldIncludeTestSuite($testSuite : cs:C1710._TestSuite) : Boolean
 	// If no patterns specified, include all tests
 	If (This:C1470.testPatterns.length=0)
 		return True:C214
@@ -344,8 +344,8 @@ Function _shouldIncludeTestSuite($testSuite : cs:C1710.TestSuite) : Boolean
 
 	return False:C215
 
-Function _patternMatchesAnyTestInSuite($testSuite : cs:C1710.TestSuite; $pattern : Text) : Boolean
-	var $testFunction : cs:C1710.TestFunction
+Function _patternMatchesAnyTestInSuite($testSuite : cs:C1710._TestSuite; $pattern : Text) : Boolean
+	var $testFunction : cs:C1710._TestFunction
 	For each ($testFunction; $testSuite.testFunctions)
 		var $fullTestName : Text
 		$fullTestName:=$testSuite.class.name+"."+$testFunction.functionName
@@ -455,7 +455,7 @@ Function _parseTagList($tagString : Text) : Collection
 
 	return $tags
 
-Function _shouldIncludeTestByTags($testFunction : cs:C1710.TestFunction) : Boolean
+Function _shouldIncludeTestByTags($testFunction : cs:C1710._TestFunction) : Boolean
 	// Apply tag filtering logic to determine if test should be included
 
 	// If no tag filters specified, include all tests

testing/Project/Sources/Classes/Testing.4dm

@@ -31,4 +31,90 @@ Function resetForNewTest()
 
 Function run($name : Text; $subtest : 4D:C1709.Function)
 	// This will be implemented later
+
+// Transaction management methods for manual control
+
+Function startTransaction() : Boolean
+	// Start a transaction and return success status
+	START TRANSACTION:C239
+	return True
+
+Function validateTransaction() : Boolean
+	// Validate the current transaction
+	VALIDATE TRANSACTION:C240
+	return (OK=1)
+
+Function cancelTransaction()
+	// Cancel the current transaction
+	CANCEL TRANSACTION:C241
+
+Function inTransaction() : Boolean
+	// Check if we're currently in a transaction
+	return (In transaction:C397)
+
+Function withTransaction($operation : 4D:C1709.Function) : Boolean
+	// Execute an operation within a transaction
+	// Returns true if operation succeeded and transaction was validated
+	var $success : Boolean
+	$success:=False
+	
+	START TRANSACTION:C239
+	
+	// Set up error handler to catch any errors during operation
+	var $previousErrorHandler : Text
+	$previousErrorHandler:=Method called on error:C704
+	ON ERR CALL:C155("TestErrorHandler")
+	
+	$operation.apply()
+	
+	// Restore previous error handler
+	If ($previousErrorHandler#"")
+		ON ERR CALL:C155($previousErrorHandler)
+	Else 
+		ON ERR CALL:C155("")
+	End if 
+	
+	// Check if operation succeeded (no test failures)
+	If (Not:C34(This:C1470.failed))
+		CANCEL TRANSACTION:C241  // Always rollback for withTransaction
+		$success:=True
+	Else 
+		CANCEL TRANSACTION:C241
+		$success:=False
+	End if 
+	
+	return $success
+
+Function withTransactionValidate($operation : 4D:C1709.Function) : Boolean
+	// Execute an operation within a transaction and always validate on success
+	// Useful for tests that need to persist data
+	var $success : Boolean
+	$success:=False
+	
+	START TRANSACTION:C239
+	
+	// Set up error handler to catch any errors during operation
+	var $previousErrorHandler : Text
+	$previousErrorHandler:=Method called on error:C704
+	ON ERR CALL:C155("TestErrorHandler")
+	
+	$operation.apply()
+	
+	// Restore previous error handler
+	If ($previousErrorHandler#"")
+		ON ERR CALL:C155($previousErrorHandler)
+	Else 
+		ON ERR CALL:C155("")
+	End if 
+	
+	// Validate transaction if test succeeded
+	If (Not:C34(This:C1470.failed))
+		VALIDATE TRANSACTION:C240
+		$success:=(OK=1)
+	Else 
+		CANCEL TRANSACTION:C241
+		$success:=False
+	End if 
+	
+	return $success
 

testing/Project/Sources/Classes/UnitStatsTracker.4dm

@@ -14,7 +14,7 @@ Function resetStatistics()
 	If (This:C1470._statsMap=Null:C1517)
 		return 
 	End if 
-	var $statistic : cs:C1710.UnitStatsDetail
+	var $statistic : cs:C1710._UnitStatsDetail
 	For each ($statistic; OB Values:C1718(This:C1470._statsMap))
 		If (OB Instance of:C1731($statistic.reset; 4D:C1709.Function))
 			$statistic.reset()
@@ -26,14 +26,14 @@ Function createStatistic($name : Text) : cs:C1710.UnitStatsTracker
 $name - text - the name of the statistic to create
 returns - cs.UnitStatsTracker - This object to chain call
 */
-	This:C1470._statsMap[$name]:=cs:C1710.UnitStatsDetail.new()
+	This:C1470._statsMap[$name]:=cs:C1710._UnitStatsDetail.new()
 	return This:C1470
 
-Function getStat($name : Text) : cs:C1710.UnitStatsDetail
+Function getStat($name : Text) : cs:C1710._UnitStatsDetail
 /* Gets a statistic. If one does not exist, a new statistic will
 be created an returned.
 $name - text - the name of the statistic to return
-returns - cs.UnitStatsDetail - a statistic
+returns - cs._UnitStatsDetail - a statistic
 */
 	If (Not:C34(This:C1470._doesStatisticExist($name)))
 		This:C1470.createStatistic($name)
@@ -47,7 +47,7 @@ $functionName - text - the name of the statistic to update
 $parameters - collection - the collection of parameters to push onto the related statistic
 $returnValue - variant - value this method will return
 */
-	var $statistic : cs:C1710.UnitStatsDetail
+	var $statistic : cs:C1710._UnitStatsDetail
 	$statistic:=This:C1470.getStat($functionName)
 	If ($statistic#Null:C1517)
 		$statistic.appendCalledParameters((($parameters#Null:C1517) ? $parameters : []))

…g/Project/Sources/Classes/AssertTest.4dm …/Project/Sources/Classes/_AssertTest.4dmtesting/Project/Sources/Classes/AssertTest.4dm renamed to testing/Project/Sources/Classes/_AssertTest.4dm testing/Project/Sources/Classes/AssertTest.4dm renamed to testing/Project/Sources/Classes/_AssertTest.4dm

@@ -9,15 +9,15 @@ Function test_null_class_handling($t : cs:C1710.Testing)
 	// We can't easily test with actual null class without causing errors,
 	// but we can test with valid classes to ensure the structure works
 	var $validClass : 4D:C1709.Class
-	$validClass:=cs:C1710.ExampleTest
+	$validClass:=cs:C1710._ExampleTest
 
 	$t.assert.isNotNull($t; $validClass; "Valid class should not be null")
 
-	var $suite : cs:C1710.TestSuite
-	$suite:=cs:C1710.TestSuite.new($validClass; "human"; []; Null:C1517)
+	var $suite : cs:C1710._TestSuite
+	$suite:=cs:C1710._TestSuite.new($validClass; "human"; []; Null:C1517)
 
 	$t.assert.isNotNull($t; $suite; "TestSuite should handle valid class")
-	$t.assert.areEqual($t; "ExampleTest"; $suite.class.name; "Should store class correctly")
+	$t.assert.areEqual($t; "_ExampleTest"; $suite.class.name; "Should store class correctly")
 
 Function test_empty_test_class($t : cs:C1710.Testing)
 
@@ -29,19 +29,19 @@ Function test_empty_test_class($t : cs:C1710.Testing)
 	$runner:=cs:C1710.TestRunner.new()
 	$runner.testPatterns:=["nonexistent_pattern"]
 
-	var $suite : cs:C1710.TestSuite
-	$suite:=cs:C1710.TestSuite.new(cs:C1710.ExampleTest; "human"; ["nonexistent_pattern"]; Null:C1517)
+	var $suite : cs:C1710._TestSuite
+	$suite:=cs:C1710._TestSuite.new(cs:C1710._ExampleTest; "human"; ["nonexistent_pattern"]; Null:C1517)
 
 	$t.assert.areEqual($t; 0; $suite.testFunctions.length; "Should have no test functions when pattern doesn't match")
 
 Function test_malformed_test_methods($t : cs:C1710.Testing)
 
 	// Test that test discovery handles methods that don't follow the pattern
-	var $suite : cs:C1710.TestSuite
-	$suite:=cs:C1710.TestSuite.new(cs:C1710.ExampleTest; "human"; []; Null:C1517)
+	var $suite : cs:C1710._TestSuite
+	$suite:=cs:C1710._TestSuite.new(cs:C1710._ExampleTest; "human"; []; Null:C1517)
 
 	// All discovered methods should start with "test_"
-	var $testFunction : cs:C1710.TestFunction
+	var $testFunction : cs:C1710._TestFunction
 	For each ($testFunction; $suite.testFunctions)
 		$t.assert.isTrue($t; $testFunction.functionName="test_@"; "All discovered methods should start with test_, found: "+$testFunction.functionName)
 	End for each 
@@ -152,14 +152,14 @@ Function test_timing_precision($t : cs:C1710.Testing)
 
 	// Test that timing works correctly even for very fast tests
 	var $exampleClass : 4D:C1709.Class
-	$exampleClass:=cs:C1710.ExampleTest
-	var $classInstance : cs:C1710.ExampleTest
-	$classInstance:=cs:C1710.ExampleTest.new()
+	$exampleClass:=cs:C1710._ExampleTest
+	var $classInstance : cs:C1710._ExampleTest
+	$classInstance:=cs:C1710._ExampleTest.new()
 	var $testMethod : 4D:C1709.Function
 	$testMethod:=$classInstance.test_areEqual_pass
 
-	var $testFunction : cs:C1710.TestFunction
-	$testFunction:=cs:C1710.TestFunction.new($exampleClass; $classInstance; $testMethod; "test_areEqual_pass"; "")
+	var $testFunction : cs:C1710._TestFunction
+	$testFunction:=cs:C1710._TestFunction.new($exampleClass; $classInstance; $testMethod; "test_areEqual_pass"; "")
 	$testFunction.run()
 
 	var $result : Object
@@ -202,7 +202,7 @@ Function test_memory_and_cleanup($t : cs:C1710.Testing)
 	$t.assert.isTrue($t; $runner.testSuites.length>$initialSuites; "Should discover test suites")
 
 	// Verify each suite has proper structure
-	var $suite : cs:C1710.TestSuite
+	var $suite : cs:C1710._TestSuite
 	For each ($suite; $runner.testSuites)
 		$t.assert.isNotNull($t; $suite.class; "Suite should have class reference")
 		$t.assert.isNotNull($t; $suite.classInstance; "Suite should have class instance")