chore: bump CI actions to v5, sync spec, add tests for extracted code (#112)

KyleNesium · web-flow · commit 42639a1f2b83 · 2026-03-14T17:17:21.000+02:00
- Bump actions/checkout and actions/cache from v4 to v5 in both CI and
  release workflows (fixes Node.js 20 deprecation warnings)
- Add new files to spec/ARCHITECTURE.md project tree: MenuBarIconGeometry,
  TokenHealthSessionInfo, ActivityChartData, ActivityChartTrend
- Add 29 tests for SessionInfoFormatter (20) and ActivityTrendComputation (9)
  covering label parts, ID prefix, bottom parts, stale idle detection,
  detail tooltips, time formatting, vs-yesterday/week/month comparisons,
  month projection, and copy text formatting
- Update README test coverage: 585→613 tests across 39→41 files

Co-authored-by: KyleNesium &lt;22541778+KyleNesium@users.noreply.github.com&gt;
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -29,10 +29,10 @@ jobs:
     runs-on: macos-15
     timeout-minutes: 10
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
 
       - name: Cache SPM
-        uses: actions/cache@v4
+        uses: actions/cache@v5
         with:
           path: .build
           key: spm-${{ runner.os }}-${{ hashFiles('Package.resolved', 'Package.swift') }}
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -16,10 +16,10 @@ jobs:
       HAS_SPARKLE_KEY: ${{ secrets.SPARKLE_EDDSA_KEY != '' }}
       HAS_HOMEBREW_TOKEN: ${{ secrets.HOMEBREW_TAP_TOKEN != '' }}
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
 
       - name: Cache SPM
-        uses: actions/cache@v4
+        uses: actions/cache@v5
         with:
           path: .build
           key: spm-${{ runner.os }}-${{ hashFiles('Package.resolved', 'Package.swift') }}
diff --git a/README.md b/README.md
@@ -485,13 +485,13 @@ If it saves you time or helps you get more out of your Claude subscription, cons
 
 ## 🧪 Test Coverage
 
-**585 tests** across 39 test files.
+**613 tests** across 41 test files.
 
 | Area | Tests | What's covered |
 |------|-------|----------------|
 | Models | 180 | Token summaries, rate limit parsing (predictive estimates, fresh window guard, unknown claim defaults, countdown formatter, throttled header parsing, per-window throttle detection, utilization clamping, past reset guard, threshold boundary), health status, metric modes, API profiles (org ID validation: empty, too long, special chars, hyphens/underscores), session entries (service_tier decode), account records, stats cache, usage snapshots (trends, busiest day, auto-resolved mode with priority tiers and edge cases, urgency score piecewise interpolation with midpoint verification and clamping, context health fallback chain, single-pass activity stats), model pricing (cache correctness for unknown models), health config |
 | Services | 231 | Token ledger (high-water-mark merge, historical model restoration, per-account isolation, persistence, sort order, all token types, file size guard), version checker (semver comparison, tag stripping, cache behavior, force check, stale cache discard, persistence keys), Sparkle update service (automatic checks disabled, automatic downloads disabled, check interval zero, feed URL, singleton identity, canCheckForUpdates), notification manager (alert thresholds, alert key migration), token health monitor (band classification, warnings, anomalies, velocity, rapid consumption, custom config, idle session inclusion), status checker (severity ordering, incident escalation, known components catalog, status string parsing), status indicator (dot colors, label text), session log reader (entry decoding, makeUsageEntry, symlink boundary check), account store (multi-account CRUD, persistence, merge metadata preservation), stats cache reader (decode, caching, invalidation, full payload, file size guard, symlink boundary check, prefix traversal attack), usage aggregator (empty state, stats-only, JSONL-only, rate limit pass-through, model filtering, deduplication, stats+JSONL merge, all-time mode, redundant aggregation skip, hourly merge, peak hour update, totalMessages dedup, old model visibility, all-dates daily merge, todayHourCounts separation), rate limit fetcher (cache expiry, stale marking, multi-account isolation, Retry-After parsing), OAuth manager (AuthError messages, transient error classification) |
-| Views | 14 | Activity chart data transformations (daily 7-day generation, gap filling, chronological ordering, hourly 12-hour window, midnight wraparound, month totals aggregation, invalid date handling, monthly 12-month generation, current-month projection, early-month projection skip, past-month no projection) |
+| Views | 43 | Activity chart data transformations (daily 7-day generation, gap filling, chronological ordering, hourly 12-hour window, midnight wraparound, month totals aggregation, invalid date handling, monthly 12-month generation, current-month projection, early-month projection skip, past-month no projection), activity trend computation (vs-yesterday positive/negative/same/nil, month change projection/nil/early-month, copy text formatting), session info formatter (label parts with project/branch/HEAD/empty, ID prefix truncation/nil/short, bottom parts with duration/velocity/fallback, stale idle detection by band/recency, detail tooltip content, time formatting just-now/minutes/today) |
 | ViewModels | 26 | UsageViewModel static helpers (refresh interval clamping, error message logic, adaptive polling data-change detection, throttle event recording with dedup + exhaustion detection, throttle count filtering + string timestamp parsing) |
 | Utilities | 136 | Token formatter (K/M suffixes, boundaries), model name mapper (display names, versions, date stripping, result cache), Claude paths (suffixes, URLs), theme colors (standard + colorblind palettes, NSColor, semantic colors, danger), UserDefaults keys (prefix, uniqueness), date formatters (format strings, round-trips, locale pinning, date range formatting), adaptive polling state (threshold behavior, progressive doubling, caps, reset), secure networking (ephemeral session config, singleton, size limit, cookie policy, resource timeout), duration formatter (compact format, boundaries, 24h edge case, days/hours/minutes/seconds), menu bar icon (breathing animation, recovery sparkle effect, quantized caching, broken star fragments, pulse steps, cache identity, sparkle/broken/normal key isolation, context health colors), throttle tracker (transition detection, recovery-then-throttle, exhaustion detection, no double-count, timestamp parsing for doubles/strings/ints/mixed, append-and-prune with 30-day cutoff, count filtering) |
 
diff --git a/Tests/AIBatteryCoreTests/Views/ActivityTrendTests.swift b/Tests/AIBatteryCoreTests/Views/ActivityTrendTests.swift
@@ -0,0 +1,136 @@
+import Testing
+import Foundation
+@testable import AIBatteryCore
+
+@Suite("ActivityTrendComputation")
+@MainActor
+struct ActivityTrendTests {
+
+    // MARK: - changeVsYesterday
+
+    @Test func changeVsYesterday_positive() {
+        let cal = Calendar.current
+        let now = Date()
+        let yesterdayStr = DateFormatters.dateKey.string(from: cal.date(byAdding: .day, value: -1, to: now)!)
+        let snapshot = makeSnapshot(todayMessages: 15, dailyActivity: [
+            DailyActivity(date: yesterdayStr, messageCount: 10, sessionCount: 1, toolCallCount: 0)
+        ])
+        let change = ActivityTrendComputation.changeVsYesterday(snapshot, cal: cal, now: now)
+        #expect(change?.symbol == "↑")
+        #expect(change?.label == "+5 vs yesterday")
+    }
+
+    @Test func changeVsYesterday_negative() {
+        let cal = Calendar.current
+        let now = Date()
+        let yesterdayStr = DateFormatters.dateKey.string(from: cal.date(byAdding: .day, value: -1, to: now)!)
+        let snapshot = makeSnapshot(todayMessages: 5, dailyActivity: [
+            DailyActivity(date: yesterdayStr, messageCount: 10, sessionCount: 1, toolCallCount: 0)
+        ])
+        let change = ActivityTrendComputation.changeVsYesterday(snapshot, cal: cal, now: now)
+        #expect(change?.symbol == "↓")
+        #expect(change?.label == "-5 vs yesterday")
+    }
+
+    @Test func changeVsYesterday_same() {
+        let cal = Calendar.current
+        let now = Date()
+        let yesterdayStr = DateFormatters.dateKey.string(from: cal.date(byAdding: .day, value: -1, to: now)!)
+        let snapshot = makeSnapshot(todayMessages: 10, dailyActivity: [
+            DailyActivity(date: yesterdayStr, messageCount: 10, sessionCount: 1, toolCallCount: 0)
+        ])
+        let change = ActivityTrendComputation.changeVsYesterday(snapshot, cal: cal, now: now)
+        #expect(change?.symbol == "→")
+    }
+
+    @Test func changeVsYesterday_nilWhenNoYesterdayData() {
+        let snapshot = makeSnapshot(todayMessages: 10, dailyActivity: [])
+        let change = ActivityTrendComputation.changeVsYesterday(snapshot)
+        #expect(change == nil)
+    }
+
+    // MARK: - monthChangeInfo
+
+    @Test func monthChange_positiveProjection() {
+        let cal = Calendar.current
+        // March 15, 2026 — dayOfMonth=15, daysInMonth=31
+        let now = cal.date(from: DateComponents(year: 2026, month: 3, day: 15))!
+        // thisMonth=100, projected=100*31/15=206, lastMonth=100 → +106% → ↑
+        let change = ActivityTrendComputation.monthChangeInfo(thisMonth: 100, lastMonth: 100, cal: cal, now: now)
+        #expect(change?.symbol == "↑")
+    }
+
+    @Test func monthChange_nilWhenLastMonthZero() {
+        let change = ActivityTrendComputation.monthChangeInfo(thisMonth: 50, lastMonth: 0)
+        #expect(change == nil)
+    }
+
+    @Test func monthChange_nilWhenTooEarlyInMonth() {
+        let cal = Calendar.current
+        let now = cal.date(from: DateComponents(year: 2026, month: 3, day: 2))!
+        let change = ActivityTrendComputation.monthChangeInfo(thisMonth: 50, lastMonth: 100, cal: cal, now: now)
+        #expect(change == nil) // dayOfMonth < 4
+    }
+
+    // MARK: - copyText
+
+    @Test func copyText_includesAllParts() {
+        let data = ActivityTrendData(
+            change: ActivityChangeInfo(symbol: "↑", label: "+5 vs yesterday", color: .orange),
+            stat: "15 msgs today",
+            throttleCount: 2,
+            peak: "Peak: 14:00",
+            throttleDays: 1
+        )
+        let text = ActivityTrendComputation.copyText(data)
+        #expect(text.contains("↑ +5 vs yesterday"))
+        #expect(text.contains("15 msgs today"))
+        #expect(text.contains("Throttled: 2×"))
+        #expect(text.contains("Peak: 14:00"))
+    }
+
+    @Test func copyText_zeroThrottles() {
+        let data = ActivityTrendData(
+            change: nil,
+            stat: nil,
+            throttleCount: 0,
+            peak: nil,
+            throttleDays: 1
+        )
+        let text = ActivityTrendComputation.copyText(data)
+        #expect(text == "Throttled: 0")
+    }
+
+    // MARK: - Helpers
+
+    private func makeSnapshot(
+        todayMessages: Int = 0,
+        dailyActivity: [DailyActivity] = []
+    ) -> UsageSnapshot {
+        let stats = UsageSnapshot.computeActivityStats(dailyActivity)
+        return UsageSnapshot(
+            lastUpdated: Date(),
+            rateLimits: nil,
+            firstSessionDate: nil,
+            totalSessions: 0,
+            totalMessages: 0,
+            longestSessionDuration: nil,
+            longestSessionMessages: 0,
+            peakHour: nil,
+            peakHourCount: 0,
+            todayMessages: todayMessages,
+            todaySessions: 0,
+            todayToolCalls: 0,
+            modelTokens: [],
+            totalTokens: 0,
+            dailyActivity: dailyActivity,
+            dailyAverage: stats.average,
+            trendDirection: stats.trend,
+            busiestDayOfWeek: stats.busiestDay,
+            hourCounts: [:],
+            todayHourCounts: [:],
+            tokenHealth: nil,
+            topSessionHealths: []
+        )
+    }
+}
diff --git a/Tests/AIBatteryCoreTests/Views/SessionInfoFormatterTests.swift b/Tests/AIBatteryCoreTests/Views/SessionInfoFormatterTests.swift
@@ -0,0 +1,180 @@
+import Testing
+import Foundation
+@testable import AIBatteryCore
+
+@Suite("SessionInfoFormatter")
+struct SessionInfoFormatterTests {
+
+    // MARK: - Label parts
+
+    @Test func labelParts_projectAndBranch() {
+        let health = makeHealth(projectName: "MyApp", gitBranch: "main")
+        let parts = SessionInfoFormatter.labelParts(for: health)
+        #expect(parts == ["MyApp", "main"])
+    }
+
+    @Test func labelParts_projectOnly() {
+        let health = makeHealth(projectName: "MyApp", gitBranch: nil)
+        let parts = SessionInfoFormatter.labelParts(for: health)
+        #expect(parts == ["MyApp"])
+    }
+
+    @Test func labelParts_skipsHEADBranch() {
+        let health = makeHealth(projectName: "MyApp", gitBranch: "HEAD")
+        let parts = SessionInfoFormatter.labelParts(for: health)
+        #expect(parts == ["MyApp"])
+    }
+
+    @Test func labelParts_skipsEmptyBranch() {
+        let health = makeHealth(projectName: "MyApp", gitBranch: "")
+        let parts = SessionInfoFormatter.labelParts(for: health)
+        #expect(parts == ["MyApp"])
+    }
+
+    @Test func labelParts_empty() {
+        let health = makeHealth(projectName: nil, gitBranch: nil)
+        let parts = SessionInfoFormatter.labelParts(for: health)
+        #expect(parts.isEmpty)
+    }
+
+    // MARK: - ID prefix
+
+    @Test func idPrefix_truncatesTo8Chars() {
+        let health = makeHealth(id: "abcdef1234567890")
+        #expect(SessionInfoFormatter.idPrefix(for: health) == "abcdef12")
+    }
+
+    @Test func idPrefix_nilForEmptyId() {
+        let health = makeHealth(id: "")
+        #expect(SessionInfoFormatter.idPrefix(for: health) == nil)
+    }
+
+    @Test func idPrefix_shortIdUnchanged() {
+        let health = makeHealth(id: "abc")
+        #expect(SessionInfoFormatter.idPrefix(for: health) == "abc")
+    }
+
+    // MARK: - Bottom parts
+
+    @Test func bottomParts_includesDurationAndVelocity() {
+        let health = makeHealth(
+            sessionDuration: 3600,
+            lastActivity: Date(),
+            tokensPerMinute: 1500
+        )
+        let parts = SessionInfoFormatter.bottomParts(for: health)
+        #expect(parts.count == 3)
+        #expect(parts[0] == "1h 0m") // DurationFormatter.compact(3600)
+        #expect(parts[2] == "1.5K/min")
+    }
+
+    @Test func bottomParts_emptyWhenNoMetadata() {
+        let health = makeHealth()
+        let parts = SessionInfoFormatter.bottomParts(for: health)
+        #expect(parts.isEmpty)
+    }
+
+    @Test func bottomParts_fallsBackToSessionStart() {
+        let health = makeHealth(
+            sessionStart: Date(),
+            lastActivity: nil
+        )
+        let parts = SessionInfoFormatter.bottomParts(for: health)
+        #expect(parts.count == 1)
+        #expect(parts[0].contains("just now") || parts[0].contains("Today"))
+    }
+
+    // MARK: - Stale idle minutes
+
+    @Test func staleIdleMinutes_nilForGreenBand() {
+        let health = makeHealth(band: .green, lastActivity: Date().addingTimeInterval(-3600))
+        #expect(SessionInfoFormatter.staleIdleMinutes(for: health) == nil)
+    }
+
+    @Test func staleIdleMinutes_nilForRecentActivity() {
+        let health = makeHealth(band: .orange, lastActivity: Date().addingTimeInterval(-60))
+        #expect(SessionInfoFormatter.staleIdleMinutes(for: health) == nil)
+    }
+
+    @Test func staleIdleMinutes_returnsMinutesWhenStale() {
+        let health = makeHealth(band: .orange, lastActivity: Date().addingTimeInterval(-3600))
+        let minutes = SessionInfoFormatter.staleIdleMinutes(for: health)
+        #expect(minutes == 60)
+    }
+
+    // MARK: - Detail tooltip
+
+    @Test func detailTooltip_includesSessionId() {
+        let health = makeHealth(id: "test-session-123")
+        let tooltip = SessionInfoFormatter.detailTooltip(for: health)
+        #expect(tooltip.contains("Session: test-session-123"))
+    }
+
+    @Test func detailTooltip_includesModel() {
+        let health = makeHealth(model: "claude-opus-4-6-20250929")
+        let tooltip = SessionInfoFormatter.detailTooltip(for: health)
+        #expect(tooltip.contains("Model: Opus 4.6"))
+    }
+
+    @Test func detailTooltip_includesContext() {
+        let health = makeHealth(totalUsed: 50000, usableWindow: 160000)
+        let tooltip = SessionInfoFormatter.detailTooltip(for: health)
+        #expect(tooltip.contains("Context:"))
+    }
+
+    // MARK: - Time formatting
+
+    @Test func formatSessionTime_justNow() {
+        let result = SessionInfoFormatter.formatSessionTime(Date())
+        #expect(result == "just now")
+    }
+
+    @Test func formatSessionTime_minutesAgo() {
+        let result = SessionInfoFormatter.formatSessionTime(Date().addingTimeInterval(-300))
+        #expect(result == "5m ago")
+    }
+
+    @Test func formatSessionTime_todayShowsTime() {
+        let result = SessionInfoFormatter.formatSessionTime(Date().addingTimeInterval(-7200))
+        #expect(result.hasPrefix("Today"))
+    }
+
+    // MARK: - Helpers
+
+    private func makeHealth(
+        id: String = "session-1",
+        band: HealthBand = .green,
+        model: String = "",
+        projectName: String? = nil,
+        gitBranch: String? = nil,
+        sessionStart: Date? = nil,
+        sessionDuration: TimeInterval? = nil,
+        lastActivity: Date? = nil,
+        tokensPerMinute: Double? = nil,
+        totalUsed: Int = 0,
+        usableWindow: Int = 160000
+    ) -> TokenHealthStatus {
+        TokenHealthStatus(
+            id: id,
+            band: band,
+            usagePercentage: 0,
+            totalUsed: totalUsed,
+            contextWindow: 200000,
+            usableWindow: usableWindow,
+            remainingTokens: usableWindow - totalUsed,
+            inputTokens: 0,
+            outputTokens: 0,
+            cacheReadTokens: 0,
+            cacheWriteTokens: 0,
+            model: model,
+            turnCount: 0,
+            warnings: [],
+            tokensPerMinute: tokensPerMinute,
+            projectName: projectName,
+            gitBranch: gitBranch,
+            sessionStart: sessionStart,
+            sessionDuration: sessionDuration,
+            lastActivity: lastActivity
+        )
+    }
+}
diff --git a/spec/ARCHITECTURE.md b/spec/ARCHITECTURE.md
@@ -98,6 +98,7 @@ AIBattery/
   Views/
     StatusBarManager.swift        — NSStatusItem + floating NSPanel, native AppKit button, controlBackgroundColor, Combine-driven updates
     MenuBarIcon.swift             — 4-pointed star NSImage: breathing glow, broken star (throttled), recovery sparkle; quantized cache
+    MenuBarIconGeometry.swift     — Star path geometry helpers (starPath, brokenStarFragments, drawStroke) + NSBezierPath→CGPath
     UsagePopoverView.swift        — Main popover: header, metric toggle, ordered sections, footer
     Settings/
       SettingsRow.swift           — Inline settings container: account names + sub-sections
@@ -109,9 +110,12 @@ AIBattery/
     TutorialOverlay.swift         — First-launch 3-step walkthrough overlay
     UsageBarsSection.swift        — FiveHourBarSection + SevenDayBarSection rate limit bars
     TokenHealthSection.swift      — Context health gauge + warnings + multi-session chevron toggle
+    TokenHealthSessionInfo.swift  — Session detail computation: label parts, tooltip, idle detection, time formatting
     TokenUsageSection.swift       — Per-model token breakdown with token type tags + optional cost
     InsightsSection.swift         — Collapsible insights: Today, All Time, Longest, Tools, Period (date range)
     ActivityChartView.swift        — 12H/7D/12M activity chart (Swift Charts, rolling windows)
+    ActivityChartData.swift       — Chart data transformation layer (daily/hourly/monthly points)
+    ActivityChartTrend.swift      — Trend computation: vs-yesterday/week/month comparisons + copy text
     CollapsibleSectionHeader.swift — Shared collapsible header with rotating chevron, used by 4 sections
     FooterLink.swift              — Footer link button with hover underline and external arrow
     RefreshButton.swift           — Refresh button with brief spin animation
