Skip to content

Commit 3936c0e

Browse files
authored
Allow the updating of the root url used for the CDN (#176)
1 parent da91520 commit 3936c0e

File tree

2 files changed

+14
-10
lines changed

2 files changed

+14
-10
lines changed

src/resources/config/shopify-app.php

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -56,13 +56,13 @@
5656
*/
5757

5858
'route_names' => [
59-
'home' => env('SHOPIFY_ROUTE_NAME_HOME', 'home'),
60-
'authenticate' => env('SHOPIFY_ROUTE_NAME_AUTHENTICATE', 'authenticate'),
61-
'authenticate.token' => env('SHOPIFY_ROUTE_NAME_AUTHENTICATE_TOKEN', 'authenticate.token'),
62-
'billing' => env('SHOPIFY_ROUTE_NAME_BILLING', 'billing'),
63-
'billing.process' => env('SHOPIFY_ROUTE_NAME_BILLING_PROCESS', 'billing.process'),
59+
'home' => env('SHOPIFY_ROUTE_NAME_HOME', 'home'),
60+
'authenticate' => env('SHOPIFY_ROUTE_NAME_AUTHENTICATE', 'authenticate'),
61+
'authenticate.token' => env('SHOPIFY_ROUTE_NAME_AUTHENTICATE_TOKEN', 'authenticate.token'),
62+
'billing' => env('SHOPIFY_ROUTE_NAME_BILLING', 'billing'),
63+
'billing.process' => env('SHOPIFY_ROUTE_NAME_BILLING_PROCESS', 'billing.process'),
6464
'billing.usage_charge' => env('SHOPIFY_ROUTE_NAME_BILLING_USAGE_CHARGE', 'billing.usage_charge'),
65-
'webhook' => env('SHOPIFY_ROUTE_NAME_WEBHOOK', 'webhook'),
65+
'webhook' => env('SHOPIFY_ROUTE_NAME_WEBHOOK', 'webhook'),
6666
],
6767

6868
/*
@@ -141,6 +141,10 @@
141141
// Leaving empty will use the latest version - not recommended in production.
142142
'appbridge_version' => env('SHOPIFY_APPBRIDGE_VERSION', 'latest'),
143143

144+
// Set a new CDN URL if you want to host the AppBridge JS yourself or unpkg goes down.
145+
// DO NOT include a trailing slash.
146+
'appbridge_cdn_url' => env('SHOPIFY_APPBRIDGE_CDN_URL', 'https://unpkg.com'),
147+
144148
/*
145149
|--------------------------------------------------------------------------
146150
| Shopify App Name
@@ -410,8 +414,8 @@
410414
*/
411415

412416
'job_queues' => [
413-
'webhooks' => env('WEBHOOKS_JOB_QUEUE', null),
414-
'scripttags' => env('SCRIPTTAGS_JOB_QUEUE', null),
417+
'webhooks' => env('WEBHOOKS_JOB_QUEUE', null),
418+
'scripttags' => env('SCRIPTTAGS_JOB_QUEUE', null),
415419
'after_authenticate' => env('AFTER_AUTHENTICATE_JOB_QUEUE', null),
416420
],
417421

src/resources/views/layouts/default.blade.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
</div>
1919

2020
@if(\Osiset\ShopifyApp\Util::getShopifyConfig('appbridge_enabled') && \Osiset\ShopifyApp\Util::useNativeAppBridge())
21-
<script src="https://unpkg.com/@shopify/app-bridge{{ \Osiset\ShopifyApp\Util::getShopifyConfig('appbridge_version') ? '@'.config('shopify-app.appbridge_version') : '' }}"></script>
22-
<script src="https://unpkg.com/@shopify/app-bridge-utils{{ \Osiset\ShopifyApp\Util::getShopifyConfig('appbridge_version') ? '@'.config('shopify-app.appbridge_version') : '' }}"></script>
21+
<script src="{{config('shopify-app.appbridge_cdn_url')}}/@shopify/app-bridge{{ \Osiset\ShopifyApp\Util::getShopifyConfig('appbridge_version') ? '@'.config('shopify-app.appbridge_version') : '' }}"></script>
22+
<script src="{{config('shopify-app.appbridge_cdn_url')}}/@shopify/app-bridge-utils{{ \Osiset\ShopifyApp\Util::getShopifyConfig('appbridge_version') ? '@'.config('shopify-app.appbridge_version') : '' }}"></script>
2323
<script
2424
@if(\Osiset\ShopifyApp\Util::getShopifyConfig('turbo_enabled'))
2525
data-turbolinks-eval="false"

0 commit comments

Comments
 (0)