Skip to content

Commit 556fa7f

Browse files
authored
Remove some app example domain as requested by Shopify as it is a malicious domain. (#433)
1 parent c640c4d commit 556fa7f

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/resources/config/shopify-app.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -388,16 +388,16 @@
388388
/*
389389
[
390390
'topic' => env('SHOPIFY_WEBHOOK_1_TOPIC', 'ORDERS_CREATE'),
391-
'address' => env('SHOPIFY_WEBHOOK_1_ADDRESS', 'https://some-app.com/webhook/orders-create')
391+
'address' => env('SHOPIFY_WEBHOOK_1_ADDRESS', 'https://example.com/webhook/orders-create')
392392
], [
393393
'topic' => env('SHOPIFY_WEBHOOK_2_TOPIC', 'APP_PURCHASES_ONE_TIME_UPDATE'),
394-
'address' => env('SHOPIFY_WEBHOOK_2_ADDRESS', 'https://some-app.com/webhook/purchase'),
394+
'address' => env('SHOPIFY_WEBHOOK_2_ADDRESS', 'https://example.com/webhook/purchase'),
395395
]
396396
// In certain situations you may wish to map the webhook to a specific class
397397
// To do this, change the array to an associative array with a 'class' key
398398
'orders-create' => [
399399
'topic' => env('SHOPIFY_WEBHOOK_3_TOPIC', 'ORDERS_PAID'),
400-
'address' => env('SHOPIFY_WEBHOOK_3_ADDRESS', 'https://some-app.com/webhook/orders-create'),
400+
'address' => env('SHOPIFY_WEBHOOK_3_ADDRESS', 'https://example.com/webhook/orders-create'),
401401
'class' => \App\Shopify\Actions\ExampleAppJob::class
402402
],
403403
*/],
@@ -414,7 +414,7 @@
414414
'scripttags' => [
415415
/*
416416
[
417-
'src' => env('SHOPIFY_SCRIPTTAG_1_SRC', 'https://some-app.com/some-controller/js-method-response'),
417+
'src' => env('SHOPIFY_SCRIPTTAG_1_SRC', 'https://example.com/some-controller/js-method-response'),
418418
'event' => env('SHOPIFY_SCRIPTTAG_1_EVENT', 'onload'),
419419
'display_scope' => env('SHOPIFY_SCRIPTTAG_1_DISPLAY_SCOPE', 'online_store')
420420
],

tests/Traits/WebhookControllerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ protected function getEnvironmentSetUp($app): void
159159
$webhooks = Config::get('shopify-app.webhooks');
160160
$webhooks['orders-create-example'] = [
161161
'topic' => 'ORDERS_PAID',
162-
'address' => 'https://some-app.com/webhook/orders-create-example',
162+
'address' => 'https://example.com/webhook/orders-create-example',
163163
'class' => OrdersCreateJob::class,
164164
];
165165
$app['config']->set('shopify-app.webhooks', $webhooks);

0 commit comments

Comments
 (0)