Skip to content

Conversation

usmanpakistan
Copy link
Contributor

No description provided.

@usmanpakistan
Copy link
Contributor Author

Hello @Kyon147 , I hope everything is going well. It's been a while since this PR was submitted, what are your thoughts on it? Is there anything else that needs to be changed or improved?

@Kyon147
Copy link
Owner

Kyon147 commented Nov 2, 2023

Hey @usmanpakistan

Could you update me on what the PR is for, what it looks to solve and how someone would set it up?

Also, some of the tests are failing, could you take a look.

@usmanpakistan
Copy link
Contributor Author

@Kyon147 This PR resolve issue reported previously on the legacy laravel-shopify package.
It enables a user to provide an EventBridge ARN while subscribing to Webhooks. You can refer to your comment here for more detail
gnikyt/laravel-shopify#1113 (comment)

@usmanpakistan
Copy link
Contributor Author

@Kyon147 Any update on this PR

@Jamesking56
Copy link
Contributor

@Kyon147 Any update on this PR

Your PR is still failing tests, resolve those first please

@Kyon147
Copy link
Owner

Kyon147 commented Mar 5, 2024

Hey @usmanpakistan

As @Jamesking56 mentions please fix the failing tests and I can re-review once they are good.

@usmanpakistan
Copy link
Contributor Author

@Jamesking56 @Kyon147 can I get some help with fixing these tests. I am not well versed with writing them. I have tried a lot to fix the tests but these are still failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants