Fix a crash in lib/msf/core/payload/php.rb

jvoisin · jvoisin · commit 1647d3a96b1d · 2024-09-22T21:07:53.000+02:00
As it seems that shuffle is a method (https://ruby-doc.org/core-2.7.0/Array.html#method-i-shuffle) and not a function. As spotted by @Chocapikk in rapid7#19445 (review)
diff --git a/lib/msf/core/payload/php.rb b/lib/msf/core/payload/php.rb
@@ -135,7 +135,7 @@ def php_system_block(options = {})
     "
 
     exec_methods = [passthru, shell_exec, system, exec, proc_open, popen];
-    shuffle(exec_methods);
+    exec_methods = exec_methods.shuffle
     buf = setup + exec_methods.join("") + fail_block
 
     return buf

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ def php_system_block(options = {})`
`135`	`135`	`"`
`136`	`136`
`137`	`137`	`exec_methods = [passthru, shell_exec, system, exec, proc_open, popen];`
`138`		`- shuffle(exec_methods);`
	`138`	`+ exec_methods = exec_methods.shuffle`
`139`	`139`	`buf = setup + exec_methods.join("") + fail_block`
`140`	`140`
`141`	`141`	`return buf`