Land rapid7#20107, modules/post/multi/gather: Resolve RuboCop violations

Author: cgranleese-r7

modules/post/multi/gather/apple_ios_backup.rb

@@ -32,6 +32,11 @@ def initialize(info = {})
               stdapi_sys_config_getuid
             ]
           }
+        },
+        'Notes' => {
+          'Stability' => [CRASH_SAFE],
+          'SideEffects' => [],
+          'Reliability' => []
         }
       )
     )
@@ -241,7 +246,7 @@ def process_backup(path)
           store_loot('ios.backup.data', ctype, session, fdata, rname, "iOS Backup: #{rname}")
         rescue ::Interrupt
           raise $ERROR_INFO
-        rescue ::Exception => e
+        rescue StandardError => e
           print_error("Failed to download #{fname}: #{e.class} #{e}")
         end
 

modules/post/multi/gather/aws_ec2_instance_metadata.rb

@@ -22,7 +22,12 @@ def initialize(info = {})
         'SessionTypes' => %w[shell meterpreter],
         'References' => [
           [ 'URL', 'http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2-instance-metadata.html' ]
-        ]
+        ],
+        'Notes' => {
+          'Stability' => [CRASH_SAFE],
+          'SideEffects' => [],
+          'Reliability' => []
+        }
       )
     )
 

modules/post/multi/gather/aws_keys.rb

@@ -29,7 +29,12 @@ def initialize(info = {})
         'References' => [
           [ 'URL', 'http://s3tools.org/kb/item14.htm' ],
           [ 'URL', 'http://docs.aws.amazon.com/cli/latest/userguide/cli-chap-getting-started.html#cli-config-files' ]
-        ]
+        ],
+        'Notes' => {
+          'Stability' => [CRASH_SAFE],
+          'SideEffects' => [],
+          'Reliability' => []
+        }
       )
     )
   end

modules/post/multi/gather/check_malware.rb

@@ -20,15 +20,19 @@ def initialize(info = {})
         'License' => MSF_LICENSE,
         'Author' => [ 'sinn3r'],
         'Platform' => [ 'osx', 'win', 'linux' ],
-        'SessionTypes' => [ 'shell', 'meterpreter' ]
+        'SessionTypes' => [ 'shell', 'meterpreter' ],
+        'Notes' => {
+          'Stability' => [CRASH_SAFE],
+          'SideEffects' => [],
+          'Reliability' => []
+        }
       )
     )
 
     register_options(
       [
         OptString.new('APIKEY', [true, 'VirusTotal API key', '501caf66349cc7357eb4398ac3298fdd03dec01a3e2f3ad576525aa7b57a1987']),
         OptString.new('REMOTEFILE', [true, 'A file to check from the remote machine'])
-
       ]
     )
   end
@@ -43,11 +47,11 @@ def get_report(api_key, checksum)
     # The supplied module name is ambiguous: undefined method `register_autofilter_ports'
     #
     url = URI.parse('https://www.virustotal.com/vtapi/v2/file/report')
-    req = Net::HTTP::Post.new(url.path, initheader = { 'Host' => 'www.virustotal.com' })
+    req = Net::HTTP::Post.new(url.path, { 'Host' => 'www.virustotal.com' })
     req.set_form_data({ 'apikey' => api_key, 'resource' => checksum })
     http = Net::HTTP.new(url.host, url.port)
     http.use_ssl = true
-    res = http.start { |http| http.request(req) }
+    res = http.start { |h| h.request(req) }
 
     unless res
       print_error("#{rhost} - Connection timed out")

modules/post/multi/gather/chrome_cookies.rb

@@ -15,7 +15,12 @@ def initialize(info = {})
         'License' => MSF_LICENSE,
         'Author' => ['mangopdf <mangodotpdf[at]gmail.com>'],
         'Platform' => %w[linux unix bsd osx windows],
-        'SessionTypes' => %w[meterpreter shell]
+        'SessionTypes' => %w[meterpreter shell],
+        'Notes' => {
+          'Stability' => [CRASH_SAFE],
+          'SideEffects' => [],
+          'Reliability' => []
+        }
       )
     )
 
@@ -186,7 +191,7 @@ def get_cookies
       # Kills spawned chrome process in windows meterpreter sessions.
       # In OSX and Linux the meterpreter sessions would stop as well.
       if session.platform == 'windows'
-        kill_output = cmd_exec "#{kill_cmd} #{chrome_pid}"
+        cmd_exec "#{kill_cmd} #{chrome_pid}"
       end
     else
       # Using shell_command for backgrounding process (&)

modules/post/multi/gather/dbvis_enum.rb

@@ -30,14 +30,19 @@ def initialize(info = {})
               stdapi_sys_config_getenv
             ]
           }
+        },
+        'Notes' => {
+          'Stability' => [CRASH_SAFE],
+          'SideEffects' => [],
+          'Reliability' => []
         }
       )
     )
     register_options(
       [
         OptString.new('PASSPHRASE', [false, 'The hardcoded passphrase used for encryption']),
         OptInt.new('ITERATION_COUNT', [false, 'The iteration count used in key derivation', 10])
-      ], super.class
+      ]
     )
   end
 
@@ -138,6 +143,7 @@ def parse_new_config_file(raw_xml)
     db = {}
     dbfound = false
     version_found = false
+
     # fetch config file
     raw_xml.each_line do |line|
       if version_found == false
@@ -155,7 +161,7 @@ def parse_new_config_file(raw_xml)
           db[:Namespace] = ''
         end
         # save
-        dbs << db if (db[:Alias] && db[:Type] && db[:Server] && db[:Port])
+        dbs << db if db[:Alias] && db[:Type] && db[:Server] && db[:Port]
         db = {}
       end
 
@@ -204,21 +210,31 @@ def parse_new_config_file(raw_xml)
     end
 
     # Fill the tab and report eligible servers
-    dbs.each do |db|
-      if ::Rex::Socket.is_ipv4?(db[:Server].to_s)
-        print_good("Reporting #{db[:Server]}")
-        report_host(host: db[:Server])
+    dbs.each do |database|
+      if ::Rex::Socket.is_ipv4?(database[:Server].to_s)
+        print_good("Reporting #{database[:Server]}")
+        report_host(host: database[:Server])
       end
 
-      db_table << [ db[:Alias], db[:Type], db[:Server], db[:Port], db[:Database], db[:Namespace], db[:UserID], db[:Password] ]
+      db_table << [
+        database[:Alias],
+        database[:Type],
+        database[:Server],
+        database[:Port],
+        database[:Database],
+        database[:Namespace],
+        database[:UserID],
+        database[:Password]
+      ]
       report_cred(
-        ip: db[:Server],
-        port: db[:Port].to_i,
-        service_name: db[:Type],
-        username: db[:UserID],
-        password: db[:Password]
+        ip: database[:Server],
+        port: database[:Port].to_i,
+        service_name: database[:Type],
+        username: database[:UserID],
+        password: database[:Password]
       )
     end
+
     return db_table
   end
 
@@ -245,15 +261,15 @@ def parse_old_config_file(raw_xml)
     # fetch config file
     raw_xml.each_line do |line|
       if version_found == false
-        vesrion_found = find_version(line)
+        version_found = find_version(line)
       end
 
       if line =~ /<Database id=/
         dbfound = true
       elsif line =~ %r{</Database>}
         dbfound = false
         # save
-        dbs << db if (db[:Alias] && db[:Url])
+        dbs << db if db[:Alias] && db[:Url]
         db = {}
       end
 
@@ -287,33 +303,40 @@ def parse_old_config_file(raw_xml)
     end
 
     # Fill the tab
-    dbs.each do |db|
-      if (db[:URL] =~ %r{[\S+\s+]+/+([\S+\s+]+):[\S+]+}i)
+    dbs.each do |database|
+      if (database[:URL] =~ %r{[\S+\s+]+/+([\S+\s+]+):[\S+]+}i)
         server = ::Regexp.last_match(1)
         if ::Rex::Socket.is_ipv4?(server)
           print_good("Reporting #{server}")
           report_host(host: server)
         end
       end
-      db_table << [ db[:Alias], db[:Type], db[:URL], db[:UserID], db[:Password] ]
+      db_table << [
+        database[:Alias],
+        database[:Type],
+        database[:URL],
+        database[:UserID],
+        database[:Password]
+      ]
       report_cred(
         ip: server,
         port: '',
-        service_name: db[:Type],
-        username: db[:UserID],
-        password: db[:Password]
+        service_name: database[:Type],
+        username: database[:UserID],
+        password: database[:Password]
       )
     end
+
     return db_table
   end
 
   def find_version(tag)
-    found = false
     if tag =~ %r{<Version>([\S+\s+]+)</Version>}i
-      found = true
       print_good("DbVisualizer version: #{::Regexp.last_match(1)}")
+      return true
     end
-    found
+
+    false
   end
 
   def report_cred(opts)
@@ -349,7 +372,7 @@ def decrypt_password(enc_password)
     des.decrypt
     des.key = dk
     des.iv = iv
-    password = des.update(enc_password) + des.final
+    des.update(enc_password) + des.final
   end
 
   def get_derived_key

modules/post/multi/gather/dns_bruteforce.rb

@@ -16,18 +16,21 @@ def initialize(info = {})
         'License' => MSF_LICENSE,
         'Author' => [ 'Carlos Perez <carlos_perez[at]darkoperator.com>'],
         'Platform' => %w[bsd linux osx solaris win],
-        'SessionTypes' => [ 'meterpreter', 'shell' ]
+        'SessionTypes' => [ 'meterpreter', 'shell' ],
+        'Notes' => {
+          'Stability' => [CRASH_SAFE],
+          'SideEffects' => [],
+          'Reliability' => []
+        }
       )
     )
     register_options(
       [
-
         OptString.new('DOMAIN', [true, 'Domain to do a forward lookup bruteforce against.']),
         OptPath.new('NAMELIST', [
           true, 'List of hostnames or subdomains to use.',
           ::File.join(Msf::Config.data_directory, 'wordlists', 'namelist.txt')
         ])
-
       ]
     )
   end
@@ -92,12 +95,12 @@ def proccess_win(data, ns_opt)
   end
 
   # Process the data returned by the host command
-  def process_nix(r, ns_opt)
-    r.each_line do |l|
-      data = l.scan(/(\S*) has address (\S*)$/)
-      next if data.empty?
+  def process_nix(data, ns_opt)
+    data.each_line do |line|
+      dns_data = line.scan(/(\S*) has address (\S*)$/)
+      next if dns_data.empty?
 
-      data.each do |e|
+      dns_data.each do |e|
         print_good("#{ns_opt} #{e[1]}")
         report_host(host: e[1], name: ns_opt.strip)
       end

modules/post/multi/gather/dns_reverse_lookup.rb

@@ -16,19 +16,21 @@ def initialize(info = {})
         'License' => MSF_LICENSE,
         'Author' => [ 'Carlos Perez <carlos_perez[at]darkoperator.com>'],
         'Platform' => %w[bsd linux osx solaris win],
-        'SessionTypes' => [ 'meterpreter', 'shell' ]
+        'SessionTypes' => [ 'meterpreter', 'shell' ],
+        'Notes' => {
+          'Stability' => [CRASH_SAFE],
+          'SideEffects' => [],
+          'Reliability' => []
+        }
       )
     )
     register_options(
       [
-
         OptAddressRange.new('RHOSTS', [true, 'IP Range to perform reverse lookup against.'])
-
       ]
     )
   end
 
-  # Run Method for when run command is issued
   def run
     iprange = datastore['RHOSTS']
     print_status("Performing DNS Reverse Lookup for IP range #{iprange}")

modules/post/multi/gather/dns_srv_lookup.rb

@@ -17,7 +17,12 @@ def initialize(info = {})
         'License' => MSF_LICENSE,
         'Author' => [ 'Carlos Perez <carlos_perez[at]darkoperator.com>'],
         'Platform' => %w[bsd linux osx solaris win],
-        'SessionTypes' => [ 'meterpreter', 'shell' ]
+        'SessionTypes' => [ 'meterpreter', 'shell' ],
+        'Notes' => {
+          'Stability' => [CRASH_SAFE],
+          'SideEffects' => [],
+          'Reliability' => []
+        }
       )
     )
     register_options(
@@ -156,7 +161,6 @@ def nslookup_srv_consume(srv, ns_out)
   def get_ip(host)
     ip_add = []
     cmd_exec('host', " #{host}").each_line do |l|
-      ip = ''
       ip = l.scan(/has address (\S*)$/).join
       ip_add << ip if ip != ''
     end

modules/post/multi/gather/docker_creds.rb

@@ -22,7 +22,12 @@ def initialize(info = {})
         'License' => MSF_LICENSE,
         'Author' => ['Flibustier'],
         'Platform' => %w[bsd linux osx unix],
-        'SessionTypes' => ['shell']
+        'SessionTypes' => ['shell'],
+        'Notes' => {
+          'Stability' => [CRASH_SAFE],
+          'SideEffects' => [],
+          'Reliability' => []
+        }
       )
     )
   end