Lint files

Author: cgranleese-r7

modules/auxiliary/admin/mssql/mssql_enum.rb

@@ -20,16 +20,17 @@ module to work, valid administrative user credentials must be
           supplied.
         },
         'Author' => [ 'Carlos Perez <carlos_perez[at]darkoperator.com>' ],
+        'License' => MSF_LICENSE,
         'Notes' => {
            'Stability' => [CRASH_SAFE],
            'SideEffects' => [IOC_IN_LOGS],
            'Reliability' => []
-        },
-        'License' => MSF_LICENSE
+        }
       )
     )
   end
 
+  # rubocop:disable Metrics/MethodLength
   def run
     print_status('Running MS SQL Server Enumeration...')
     if session
@@ -912,4 +913,5 @@ def run
 
     disconnect
   end
+  # rubocop:enable Metrics/MethodLength
 end

modules/auxiliary/gather/windows_secrets_dump.rb

@@ -328,25 +328,25 @@ def dump_cached_hashes(windows_reg, nlkm_key)
 
       username = cache_info.data.username.encode(::Encoding::UTF_8)
       info = []
-      info << ("Username: #{username}")
+      info << "Username: #{username}"
       if cache_info.iteration_count
-        info << ("Iteration count: #{cache_info.iteration_count} -> real #{cache_info.real_iteration_count}")
+        info << "Iteration count: #{cache_info.iteration_count} -> real #{cache_info.real_iteration_count}"
       end
-      info << ("Last login: #{cache_info.entry.last_access.to_time}")
+      info << "Last login: #{cache_info.entry.last_access.to_time}"
       dns_domain_name = cache_info.data.dns_domain_name.encode(::Encoding::UTF_8)
-      info << ("DNS Domain Name: #{dns_domain_name}")
-      info << ("UPN: #{cache_info.data.upn.encode(::Encoding::UTF_8)}")
-      info << ("Effective Name: #{cache_info.data.effective_name.encode(::Encoding::UTF_8)}")
-      info << ("Full Name: #{cache_info.data.full_name.encode(::Encoding::UTF_8)}")
-      info << ("Logon Script: #{cache_info.data.logon_script.encode(::Encoding::UTF_8)}")
-      info << ("Profile Path: #{cache_info.data.profile_path.encode(::Encoding::UTF_8)}")
-      info << ("Home Directory: #{cache_info.data.home_directory.encode(::Encoding::UTF_8)}")
-      info << ("Home Directory Drive: #{cache_info.data.home_directory_drive.encode(::Encoding::UTF_8)}")
-      info << ("User ID: #{cache_info.entry.user_id}")
-      info << ("Primary Group ID: #{cache_info.entry.primary_group_id}")
-      info << ("Additional groups: #{cache_info.data.groups.map(&:relative_id).join(' ')}")
+      info << "DNS Domain Name: #{dns_domain_name}"
+      info << "UPN: #{cache_info.data.upn.encode(::Encoding::UTF_8)}"
+      info << "Effective Name: #{cache_info.data.effective_name.encode(::Encoding::UTF_8)}"
+      info << "Full Name: #{cache_info.data.full_name.encode(::Encoding::UTF_8)}"
+      info << "Logon Script: #{cache_info.data.logon_script.encode(::Encoding::UTF_8)}"
+      info << "Profile Path: #{cache_info.data.profile_path.encode(::Encoding::UTF_8)}"
+      info << "Home Directory: #{cache_info.data.home_directory.encode(::Encoding::UTF_8)}"
+      info << "Home Directory Drive: #{cache_info.data.home_directory_drive.encode(::Encoding::UTF_8)}"
+      info << "User ID: #{cache_info.entry.user_id}"
+      info << "Primary Group ID: #{cache_info.entry.primary_group_id}"
+      info << "Additional groups: #{cache_info.data.groups.map(&:relative_id).join(' ')}"
       logon_domain_name = cache_info.data.logon_domain_name.encode(::Encoding::UTF_8)
-      info << ("Logon domain name: #{logon_domain_name}")
+      info << "Logon domain name: #{logon_domain_name}"
 
       report_info({ info: info.join('; ') }, 'user.cache_info')
       vprint_line(info.join("\n"))
@@ -626,7 +626,7 @@ def get_domain_users
     nb_digits = (Math.log10(users.length) + 1).floor
     users = users.each_with_index.map do |(rid, name), index|
       if index % progress_interval == 0
-        percent = format('%.2f', (index / users.length.to_f * 100)).rjust(5)
+        percent = format('%.2f', index / users.length.to_f * 100).rjust(5)
         print_status("SID enumeration progress - #{index.to_s.rjust(nb_digits)} / #{users.length} (#{percent}%)")
       end
       sid = @samr.samr_rid_to_sid(object_handle: @domain_handle, rid: rid)

modules/auxiliary/scanner/http/emby_version_ssrf.rb

@@ -53,8 +53,8 @@ def run_host(ip)
     print_status("Identifying Media Server Version on #{peer}")
     print_good("[Media Server] URI: http://#{peer}#{datastore['TARGETURI']}")
     print_good("[Media Server] Version: #{result['Version']}")
-    print_good("[Media Server] Internal IP: #{result['LocalAddress']}") if (result['LocalAddress']).to_s != ''
-    print_good('*** Vulnerable to SSRF module auxiliary/scanner/http/emby_ssrf_scanner! ***') if Rex::Version.new((result['Version']).to_s) < Rex::Version.new('4.5.0')
+    print_good("[Media Server] Internal IP: #{result['LocalAddress']}") if result['LocalAddress'].to_s != ''
+    print_good('*** Vulnerable to SSRF module auxiliary/scanner/http/emby_ssrf_scanner! ***') if Rex::Version.new(result['Version'].to_s) < Rex::Version.new('4.5.0')
     report_service(
       host: rhost,
       port: rport,

modules/auxiliary/scanner/http/jenkins_enum.rb

@@ -104,7 +104,8 @@ def check_app(app)
         :data  => {
           :uri => full_uri,
           :uri_path => uri_path,
-          :response_code => "200"
+          :response_code => "200",
+          :description => "#{full_uri} - #{uri_path} does not require authentication (200)"
         },
         :update => :unique_data
       })