modules/post/firefox: Resolve RuboCop violations

Author: bcoles

modules/post/firefox/gather/cookies.rb

@@ -12,13 +12,18 @@ def initialize(info = {})
     super(
       update_info(
         info,
-        'Name' => 'Firefox Gather Cookies from Privileged Javascript Shell',
+        'Name' => 'Firefox Gather Cookies from Privileged JavaScript Shell',
         'Description' => %q{
-          This module allows collection of cookies from a Firefox Privileged Javascript Shell.
+          This module allows collection of cookies from a Firefox Privileged JavaScript Shell.
         },
         'License' => MSF_LICENSE,
         'Author' => [ 'joev' ],
-        'DisclosureDate' => '2014-03-26'
+        'DisclosureDate' => '2014-03-26',
+        'Notes' => {
+          'Stability' => [CRASH_SAFE],
+          'SideEffects' => [],
+          'Reliability' => []
+        }
       )
     )
 
@@ -38,7 +43,7 @@ def run
 
         file = store_loot('firefox.cookies.json', 'text/json', rhost, results)
         print_good("Saved #{cookies.length} cookies to #{file}")
-      rescue JSON::ParserError => e
+      rescue JSON::ParserError
         print_warning(results)
       end
     end

modules/post/firefox/gather/history.rb

@@ -12,14 +12,19 @@ def initialize(info = {})
     super(
       update_info(
         info,
-        'Name' => 'Firefox Gather History from Privileged Javascript Shell',
+        'Name' => 'Firefox Gather History from Privileged JavaScript Shell',
         'Description' => %q{
           This module allows collection of the entire browser history from a Firefox
-          Privileged Javascript Shell.
+          Privileged JavaScript Shell.
         },
         'License' => MSF_LICENSE,
         'Author' => [ 'joev' ],
-        'DisclosureDate' => '2014-04-11'
+        'DisclosureDate' => '2014-04-11',
+        'Notes' => {
+          'Stability' => [CRASH_SAFE],
+          'SideEffects' => [],
+          'Reliability' => []
+        }
       )
     )
 
@@ -39,7 +44,7 @@ def run
 
         file = store_loot('firefox.history.json', 'text/json', rhost, history.to_json)
         print_good("Saved #{history.length} history entries to #{file}")
-      rescue JSON::ParserError => e
+      rescue JSON::ParserError
         print_warning(results)
       end
     end

modules/post/firefox/gather/passwords.rb

@@ -13,13 +13,18 @@ def initialize(info = {})
     super(
       update_info(
         info,
-        'Name' => 'Firefox Gather Passwords from Privileged Javascript Shell',
+        'Name' => 'Firefox Gather Passwords from Privileged JavaScript Shell',
         'Description' => %q{
-          This module allows collection of passwords from a Firefox Privileged Javascript Shell.
+          This module allows collection of passwords from a Firefox Privileged JavaScript Shell.
         },
         'License' => MSF_LICENSE,
         'Author' => [ 'joev' ],
-        'DisclosureDate' => '2014-04-11'
+        'DisclosureDate' => '2014-04-11',
+        'Notes' => {
+          'Stability' => [CRASH_SAFE],
+          'SideEffects' => [],
+          'Reliability' => []
+        }
       )
     )
 
@@ -43,7 +48,7 @@ def run
         else
           print_warning('No passwords were found in Firefox.')
         end
-      rescue JSON::ParserError => e
+      rescue JSON::ParserError
         print_warning(results)
       end
     end

modules/post/firefox/gather/xss.rb

@@ -22,7 +22,12 @@ def initialize(info = {})
         },
         'License' => MSF_LICENSE,
         'Author' => [ 'joev' ],
-        'Platform' => [ 'firefox' ]
+        'Platform' => [ 'firefox' ],
+        'Notes' => {
+          'Stability' => [CRASH_SAFE],
+          'SideEffects' => [],
+          'Reliability' => []
+        }
       )
     )
 

modules/post/firefox/manage/webcam_chat.rb

@@ -13,17 +13,22 @@ def initialize(info = {})
     super(
       update_info(
         info,
-        'Name' => 'Firefox Webcam Chat on Privileged Javascript Shell',
+        'Name' => 'Firefox Webcam Chat on Privileged JavaScript Shell',
         'Description' => %q{
-          This module allows streaming a webcam from a privileged Firefox Javascript shell.
+          This module allows streaming a webcam from a privileged Firefox JavaScript shell.
         },
         'License' => MSF_LICENSE,
         'Author' => [ 'joev' ],
         'References' => [
           [ 'URL', 'http://www.rapid7.com/db/modules/exploit/firefox/local/exec_shellcode' ]
         ],
         'DisclosureDate' => '2014-05-13'
-      )
+      ),
+      'Notes' => {
+        'Stability' => [CRASH_SAFE],
+        'SideEffects' => [SCREEN_EFFECTS],
+        'Reliability' => []
+      }
     )
 
     register_options([