Skip to content

Commit e99ae3d

Browse files
committed
modules/post/firefox: Resolve RuboCop violations
1 parent 157a15a commit e99ae3d

File tree

5 files changed

+41
-16
lines changed

5 files changed

+41
-16
lines changed

modules/post/firefox/gather/cookies.rb

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,18 @@ def initialize(info = {})
1212
super(
1313
update_info(
1414
info,
15-
'Name' => 'Firefox Gather Cookies from Privileged Javascript Shell',
15+
'Name' => 'Firefox Gather Cookies from Privileged JavaScript Shell',
1616
'Description' => %q{
17-
This module allows collection of cookies from a Firefox Privileged Javascript Shell.
17+
This module allows collection of cookies from a Firefox Privileged JavaScript Shell.
1818
},
1919
'License' => MSF_LICENSE,
2020
'Author' => [ 'joev' ],
21-
'DisclosureDate' => '2014-03-26'
21+
'DisclosureDate' => '2014-03-26',
22+
'Notes' => {
23+
'Stability' => [CRASH_SAFE],
24+
'SideEffects' => [],
25+
'Reliability' => []
26+
}
2227
)
2328
)
2429

@@ -38,7 +43,7 @@ def run
3843

3944
file = store_loot('firefox.cookies.json', 'text/json', rhost, results)
4045
print_good("Saved #{cookies.length} cookies to #{file}")
41-
rescue JSON::ParserError => e
46+
rescue JSON::ParserError
4247
print_warning(results)
4348
end
4449
end

modules/post/firefox/gather/history.rb

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,19 @@ def initialize(info = {})
1212
super(
1313
update_info(
1414
info,
15-
'Name' => 'Firefox Gather History from Privileged Javascript Shell',
15+
'Name' => 'Firefox Gather History from Privileged JavaScript Shell',
1616
'Description' => %q{
1717
This module allows collection of the entire browser history from a Firefox
18-
Privileged Javascript Shell.
18+
Privileged JavaScript Shell.
1919
},
2020
'License' => MSF_LICENSE,
2121
'Author' => [ 'joev' ],
22-
'DisclosureDate' => '2014-04-11'
22+
'DisclosureDate' => '2014-04-11',
23+
'Notes' => {
24+
'Stability' => [CRASH_SAFE],
25+
'SideEffects' => [],
26+
'Reliability' => []
27+
}
2328
)
2429
)
2530

@@ -39,7 +44,7 @@ def run
3944

4045
file = store_loot('firefox.history.json', 'text/json', rhost, history.to_json)
4146
print_good("Saved #{history.length} history entries to #{file}")
42-
rescue JSON::ParserError => e
47+
rescue JSON::ParserError
4348
print_warning(results)
4449
end
4550
end

modules/post/firefox/gather/passwords.rb

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,18 @@ def initialize(info = {})
1313
super(
1414
update_info(
1515
info,
16-
'Name' => 'Firefox Gather Passwords from Privileged Javascript Shell',
16+
'Name' => 'Firefox Gather Passwords from Privileged JavaScript Shell',
1717
'Description' => %q{
18-
This module allows collection of passwords from a Firefox Privileged Javascript Shell.
18+
This module allows collection of passwords from a Firefox Privileged JavaScript Shell.
1919
},
2020
'License' => MSF_LICENSE,
2121
'Author' => [ 'joev' ],
22-
'DisclosureDate' => '2014-04-11'
22+
'DisclosureDate' => '2014-04-11',
23+
'Notes' => {
24+
'Stability' => [CRASH_SAFE],
25+
'SideEffects' => [],
26+
'Reliability' => []
27+
}
2328
)
2429
)
2530

@@ -43,7 +48,7 @@ def run
4348
else
4449
print_warning('No passwords were found in Firefox.')
4550
end
46-
rescue JSON::ParserError => e
51+
rescue JSON::ParserError
4752
print_warning(results)
4853
end
4954
end

modules/post/firefox/gather/xss.rb

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,12 @@ def initialize(info = {})
2222
},
2323
'License' => MSF_LICENSE,
2424
'Author' => [ 'joev' ],
25-
'Platform' => [ 'firefox' ]
25+
'Platform' => [ 'firefox' ],
26+
'Notes' => {
27+
'Stability' => [CRASH_SAFE],
28+
'SideEffects' => [],
29+
'Reliability' => []
30+
}
2631
)
2732
)
2833

modules/post/firefox/manage/webcam_chat.rb

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,17 +13,22 @@ def initialize(info = {})
1313
super(
1414
update_info(
1515
info,
16-
'Name' => 'Firefox Webcam Chat on Privileged Javascript Shell',
16+
'Name' => 'Firefox Webcam Chat on Privileged JavaScript Shell',
1717
'Description' => %q{
18-
This module allows streaming a webcam from a privileged Firefox Javascript shell.
18+
This module allows streaming a webcam from a privileged Firefox JavaScript shell.
1919
},
2020
'License' => MSF_LICENSE,
2121
'Author' => [ 'joev' ],
2222
'References' => [
2323
[ 'URL', 'http://www.rapid7.com/db/modules/exploit/firefox/local/exec_shellcode' ]
2424
],
2525
'DisclosureDate' => '2014-05-13'
26-
)
26+
),
27+
'Notes' => {
28+
'Stability' => [CRASH_SAFE],
29+
'SideEffects' => [SCREEN_EFFECTS],
30+
'Reliability' => []
31+
}
2732
)
2833

2934
register_options([

0 commit comments

Comments
 (0)