Code Review

Author: cdelafuente-r7

lib/msf/core/db_manager/exploit_attempt.rb

@@ -79,13 +79,9 @@ def report_exploit_failure(opts)
 
     vuln = nil
     if rids.present?
-      if svc
-        # Try to find an existing vulnerability with the same service & references
-        vuln = find_vuln_by_refs(rids, host, svc, false)
-      else
-        # Try to find an existing vulnerability with the same host & references
-        vuln = find_vuln_by_refs(rids, host, nil, false)
-      end
+      # Try to find an existing vulnerability with the same service & references
+      # or, if svc is nil, with the same host & references
+      vuln = find_vuln_by_refs(rids, host, svc, false)
     end
 
     opts[:service] = svc