Fix numbrer of seconds in a day, minor nit

Author: jhpratt

src/date.rs

@@ -578,7 +578,7 @@ impl Date {
             return None;
         }
 
-        let julian_day = const_try_opt!(self.to_julian_day().checked_add(whole_days as i32));
+        let julian_day = const_try_opt!(self.to_julian_day().checked_add(whole_days as _));
         if let Ok(date) = Self::from_julian_day(julian_day) {
             Some(date)
         } else {
@@ -623,7 +623,7 @@ impl Date {
             return None;
         }
 
-        let julian_day = const_try_opt!(self.to_julian_day().checked_sub(whole_days as i32));
+        let julian_day = const_try_opt!(self.to_julian_day().checked_sub(whole_days as _));
         if let Ok(date) = Self::from_julian_day(julian_day) {
             Some(date)
         } else {

tests/integration/date.rs

@@ -772,29 +772,29 @@ fn regression_check() {
 fn checked_add_duration() {
     // Adding subday duration
     assert_eq!(
-        Date::MIN.checked_add(Duration::new(84_399, 999_999_999)),
+        Date::MIN.checked_add(Duration::new(86_399, 999_999_999)),
         Some(Date::MIN)
     );
     assert_eq!(
-        Date::MIN.checked_add(Duration::new(-84_399, -999_999_999)),
+        Date::MIN.checked_add(Duration::new(-86_399, -999_999_999)),
         Some(Date::MIN)
     );
 
     assert_eq!(
-        date!(2021 - 10 - 25).checked_add(Duration::new(84_399, 999_999_999)),
+        date!(2021 - 10 - 25).checked_add(Duration::new(86_399, 999_999_999)),
         Some(date!(2021 - 10 - 25))
     );
     assert_eq!(
-        date!(2021 - 10 - 25).checked_add(Duration::new(-84_399, -999_999_999)),
+        date!(2021 - 10 - 25).checked_add(Duration::new(-86_399, -999_999_999)),
         Some(date!(2021 - 10 - 25))
     );
 
     assert_eq!(
-        Date::MAX.checked_add(Duration::new(84_399, 999_999_999)),
+        Date::MAX.checked_add(Duration::new(86_399, 999_999_999)),
         Some(Date::MAX)
     );
     assert_eq!(
-        Date::MAX.checked_add(Duration::new(-84_399, -999_999_999)),
+        Date::MAX.checked_add(Duration::new(-86_399, -999_999_999)),
         Some(Date::MAX)
     );
 
@@ -826,29 +826,29 @@ fn checked_add_duration() {
 fn checked_sub_duration() {
     // Subtracting subday duration
     assert_eq!(
-        Date::MIN.checked_sub(Duration::new(84_399, 999_999_999)),
+        Date::MIN.checked_sub(Duration::new(86_399, 999_999_999)),
         Some(Date::MIN)
     );
     assert_eq!(
-        Date::MIN.checked_sub(Duration::new(-84_399, -999_999_999)),
+        Date::MIN.checked_sub(Duration::new(-86_399, -999_999_999)),
         Some(Date::MIN)
     );
 
     assert_eq!(
-        date!(2021 - 10 - 25).checked_sub(Duration::new(84_399, 999_999_999)),
+        date!(2021 - 10 - 25).checked_sub(Duration::new(86_399, 999_999_999)),
         Some(date!(2021 - 10 - 25))
     );
     assert_eq!(
-        date!(2021 - 10 - 25).checked_sub(Duration::new(-84_399, -999_999_999)),
+        date!(2021 - 10 - 25).checked_sub(Duration::new(-86_399, -999_999_999)),
         Some(date!(2021 - 10 - 25))
     );
 
     assert_eq!(
-        Date::MAX.checked_sub(Duration::new(84_399, 999_999_999)),
+        Date::MAX.checked_sub(Duration::new(86_399, 999_999_999)),
         Some(Date::MAX)
     );
     assert_eq!(
-        Date::MAX.checked_sub(Duration::new(-84_399, -999_999_999)),
+        Date::MAX.checked_sub(Duration::new(-86_399, -999_999_999)),
         Some(Date::MAX)
     );