Skip to content

Bug: MediaMute should be just idempotent MUTE, not toggle mute #444

@Gunni

Description

@Gunni

Describe the bug
MediaMute toggles mute, the name of the command does not imply toggling but that's the current, wrong behavior.

I can't even make it a switch to be able to toggle it with a known state, because the SWITCH just returns to off after toggling!

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Commands'
  2. Click on 'Add New'
  3. Scroll down to MediaMute
  4. Store Command
  5. Call MediaMute several times
  6. Observe toggling of mute instead of idempotent mute

Expected behavior
I'd expect the api to be idempotent, regardless of number of calls to MediaMute, it should JUST mute the computer.

Screenshots
If applicable, add screenshots to help explain your problem.

Misc info (please complete the following information):

  • Windows build (ideally screenshot/info of winver.exe output):
    • Image
  • Windows' UI language: en-US
  • HASS.Agent version: 2.1.1

Please check what's applicable (multiple answers possible):

  • Installed via installer
  • Installed manually
  • Problem occurs in HASS.Agent
  • Problem occurs in Satellite Service

Additional context
Idempotent API design makes is so much simpler to design things that call it, because you can just call it over and over with the same value and if the system is already in that state then NOTHING happens, no feedback needed, confirmed received at most is a nice to have.

Logs
N/A

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions