Skip to content

Commit c1f6aec

Browse files
authored
Fixes antismash and annotation workflow failures (#160)
* added monitoring tools to antismash image * manually update image versions on branch * add reporting tools to image * annotation workflow no longer causes failed runs from filling up bin space * opaver_anno.pl script no longer fills up bin space
1 parent d542a15 commit c1f6aec

File tree

5 files changed

+18
-16
lines changed

5 files changed

+18
-16
lines changed

workflows/Nextflow/configs/container.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ process {
5353
container = 'ghcr.io/lanl-bioinformatics/edge_phage_finder:1.2.0'
5454
}
5555
withLabel: 'sma' {
56-
container = 'ghcr.io/lanl-bioinformatics/edge_sma:0.14.0'
56+
container = 'ghcr.io/lanl-bioinformatics/edge_sma:0.15.2'
5757
}
5858
withLabel: 'binning' {
5959
container = 'ghcr.io/lanl-bioinformatics/edge_binning:1.0.0'

workflows/Nextflow/modules/runAnnotation/resources/usr/bin/opaver_anno.pl

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,9 @@
4343

4444
#init directory
4545
`mkdir -p $outdir`;
46-
`mkdir -p $Bin/ec_info`;
46+
`mkdir -p ./ec_info`;
4747
die "[ERROR] Can't create output directory $outdir: $!\n" unless -d $outdir;
48-
die "[ERROR] Can't create ec_info directory $Bin/ec_info: $!\n" unless -d "$Bin/ec_info";
48+
die "[ERROR] Can't create ec_info directory ./ec_info: $!\n" unless -d "./ec_info";
4949

5050
#init KEGG info
5151
$ecinfo = &retrieveKoInfoJson( $kojson ) if -s $kojson;
@@ -74,9 +74,9 @@
7474
print STDERR "[INFO] Retrieve pathway image and KGML...";
7575
foreach my $mapid ( keys %$map ){
7676
print STDERR "[INFO] download map$mapid...";
77-
if( -e "$Bin/ec_info/ec$mapid.png" && -e "$Bin/ec_info/ec$mapid.xml" ){
78-
`cp $Bin/ec_info/ec$mapid.png $outdir/ec$mapid.png`;
79-
`cp $Bin/ec_info/ec$mapid.xml $outdir/ec$mapid.xml`;
77+
if( -e "./ec_info/ec$mapid.png" && -e "./ec_info/ec$mapid.xml" ){
78+
`cp ./ec_info/ec$mapid.png $outdir/ec$mapid.png`;
79+
`cp ./ec_info/ec$mapid.xml $outdir/ec$mapid.xml`;
8080
}
8181

8282
if( !-e "$outdir/ec$mapid.png" || !-e "$outdir/ec$mapid.xml" ){
@@ -86,8 +86,8 @@
8686
print STDERR "[WARNING] Failed to download map$mapid image/KGML from KEGG.\n";
8787
}
8888
else{
89-
`cp $outdir/ec$mapid.png $Bin/ec_info/ec$mapid.png`;
90-
`cp $outdir/ec$mapid.xml $Bin/ec_info/ec$mapid.xml`;
89+
`cp $outdir/ec$mapid.png ./ec_info/ec$mapid.png`;
90+
`cp $outdir/ec$mapid.xml ./ec_info/ec$mapid.xml`;
9191
print STDERR "Done.\n";
9292
}
9393
}
@@ -220,7 +220,7 @@ sub getECinfo {
220220
my $info;
221221
my $url = "https://rest.kegg.jp/get";
222222
my $content;
223-
my $ec_info_file = "$Bin/ec_info/$ec";
223+
my $ec_info_file = "./ec_info/$ec";
224224

225225
if( -e $ec_info_file ){
226226
local $/;

workflows/Nextflow/modules/runAnnotation/runAnnotation.nf

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
process autodetectKingdom {
55
label 'annotation'
66
label 'tiny'
7-
containerOptions '--compat --bind .:/venv/bin/ec_info'
7+
containerOptions '--compat --bind \$PWD:/venv/bin/ec_info'
88
input:
99
path contigs
1010

@@ -25,7 +25,7 @@ process autodetectKingdom {
2525
process prokkaAnnotate {
2626
label 'annotation'
2727
label 'small'
28-
containerOptions '--compat --bind .:/venv/bin/ec_info'
28+
containerOptions '--compat --bind \$PWD:/venv/bin/ec_info'
2929
publishDir(
3030
path: "${settings["annotationOutDir"]}",
3131
mode: 'copy'
@@ -88,7 +88,7 @@ process prokkaAnnotate {
8888
process rattAnnotate {
8989
label 'annotation'
9090
label 'small'
91-
containerOptions '--compat --bind .:/venv/bin/ec_info'
91+
containerOptions '--compat --bind \$PWD:/venv/bin/ec_info'
9292
publishDir(
9393
path: "${settings["annotationOutDir"]}",
9494
mode: 'copy'
@@ -127,7 +127,7 @@ process rattAnnotate {
127127
process annPlot {
128128
label 'annotation'
129129
label 'tiny'
130-
containerOptions '--compat --bind .:/venv/bin/ec_info'
130+
containerOptions '--compat --bind \$PWD:/venv/bin/ec_info'
131131
publishDir(
132132
path: "${settings["annotationOutDir"]}",
133133
mode: 'copy'
@@ -154,7 +154,7 @@ process annPlot {
154154
process keggPlots {
155155
label 'annotation'
156156
label 'tiny'
157-
containerOptions '--compat --bind .:/venv/bin/ec_info'
157+
containerOptions '--compat --bind \$PWD:/venv/bin/ec_info'
158158
publishDir(
159159
path: "${settings["annotationOutDir"]}",
160160
mode: 'copy'

workflows/Nextflow/modules/runAntiSmash/Dockerfile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
# syntax=docker/dockerfile:1
22
FROM antismash/standalone-lite-nonfree:7.1.0
3-
ENV version=0.14.0
3+
ENV version=0.15.2
4+
5+
RUN apt-get update && apt-get install procps -y && apt-get clean
46

57
#we override the base image's entrypoint for appropriate interaction with Nextflow
68
ENTRYPOINT ["/usr/bin/env"]

workflows/Nextflow/nextflow.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ process {
305305
container = 'ghcr.io/lanl-bioinformatics/edge_phage_finder:1.2.0'
306306
}
307307
withLabel: 'sma' {
308-
container = 'ghcr.io/lanl-bioinformatics/edge_sma:0.14.0'
308+
container = 'ghcr.io/lanl-bioinformatics/edge_sma:0.15.2'
309309
}
310310
withLabel: 'binning' {
311311
container = 'ghcr.io/lanl-bioinformatics/edge_binning:1.0.0'

0 commit comments

Comments
 (0)