Merge pull request #5 from psbds/dev-padasil

Refactoring and adding deepscan extensions

Author: Paulo Sérgio Baima

.devcontainer/devcontainer.json

@@ -30,6 +30,7 @@
 	// Add the IDs of extensions you want installed when the container is created in the array below.
 	"extensions": [
 		"ms-vscode.vscode-typescript-tslint-plugin",
-		"hbenl.vscode-mocha-test-adapter"
+		"hbenl.vscode-mocha-test-adapter",
+		"deepscan.vscode-deepscan"
 	]
 }

.vscode/settings.json

@@ -0,0 +1,3 @@
+{
+    "deepscan.enable": true
+}

unify-release-build-task/.taskkey

@@ -1,12 +1,10 @@
 import { resolve } from "path"
 import { config } from "dotenv"
-import { singleton, injectable, inject } from "tsyringe";
+import { singleton, inject } from "tsyringe";
 import { IVariableManager } from "../interfaces/types";
 
 config({ path: resolve(__dirname, "../.env") })
 
-
-
 @singleton()
 export default class VariableManager implements IVariableManager {
     constructor(@inject("TaskLib") private taskLib: any) {

unify-release-build-task/src/helpers/variableManager.ts

@@ -6,6 +6,7 @@ async function run() {
     try {
         let unifyReleaseService = container.resolve<IUnifyReleaseService>("IUnifyReleaseService");
         await unifyReleaseService.unifyRelease();
+        console.log("Test");
         tl.setResult(tl.TaskResult.Succeeded, "Task Completed");
     }
     catch (err) {

unify-release-build-task/src/index.ts

@@ -1,4 +1,4 @@
-import { Build, BuildStatus, BuildResult } from "azure-devops-node-api/interfaces/BuildInterfaces";
+import { Build } from "azure-devops-node-api/interfaces/BuildInterfaces";
 import IAzureDevOpsClientWrapper from "../helpers/azureDevOpsClientWrapper";
 import { injectable, inject } from "tsyringe";
 import { IBuildService } from "../interfaces/types";

unify-release-build-task/src/services/buildService.ts

@@ -6,8 +6,7 @@ import { StubbedInstance, stubInterface as StubInterface } from "ts-sinon";
 
 //# Imports
 import AzureDevOpsClientWrapper from "../../src/helpers/azureDevOpsClientWrapper";
-import { Build, BuildStatus, BuildResult } from "azure-devops-node-api/interfaces/BuildInterfaces";
-import buildService from "../../src/services/buildService";
+import { Build } from "azure-devops-node-api/interfaces/BuildInterfaces";
 import BuildService from "../../src/services/buildService";
 
 //# Tests

unify-release-build-task/tests/services/buildServiceTests.ts

@@ -28,7 +28,6 @@ describe('UnifyReleaseService', () => {
     })
 
     describe('unifyRelease', () => {
-        const buildId = 1;
         it("Should create tag if all last related builds are Completed and Succeeded or Partially Suceeded", async () => {
             let triggeredBuild: Build = {
                 id: 1,