change the department name to snake case to meet the role name (#2121)

* change the department name to snake case to make the role name

* update

* revert the department ecs role

* keep the department_ecs_role as snake case as well

Author: Tian-2017

terraform/modules/department/50-aws-iam-policies.tf

@@ -933,10 +933,8 @@ data "aws_iam_policy_document" "department_ecs_passrole" {
       "iam:PassRole"
     ]
     resources = [
-      aws_iam_role.department_ecs_role.arn,
-      "arn:aws:iam::${data.aws_caller_identity.current.account_id}:role/${local.department_identifier}-ecs-execution-role",
-      "arn:aws:iam::${data.aws_caller_identity.current.account_id}:role/dap-ecs-execution-role",
-      "arn:aws:iam::${data.aws_caller_identity.current.account_id}:role/dap-ecs-task-role"
+      aws_iam_role.department_ecs_role.arn, # Defined in 50-aws-iam-roles.tf
+      "arn:aws:iam::${data.aws_caller_identity.current.account_id}:role/${replace(local.department_identifier, "-", "_")}-ecs-execution-role", # Defined in ecs repo.
     ]
     condition {
       test     = "StringEquals"

terraform/modules/department/50-aws-iam-roles.tf

@@ -143,7 +143,7 @@ resource "aws_secretsmanager_secret_version" "airflow_user_secret_version" {
 
 # Department ECS
 resource "aws_iam_role" "department_ecs_role" {
-  name               = lower("${var.identifier_prefix}-ecs-${local.department_identifier}")
+  name               = lower("${var.identifier_prefix}-ecs-${replace(local.department_identifier, "-", "_")}")
   assume_role_policy = data.aws_iam_policy_document.ecs_assume_role_policy.json
   tags               = var.tags
 }