update aws_db_instance.id to aws_db_instance.identifier (#2336)

timburke-hackit · web-flow · commit 869a1cd48fc8 · 2025-07-15T15:28:23.000+01:00
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/guides/version-5-upgrade#resourceaws_db_instance
diff --git a/terraform/modules/sql-to-rds-snapshot/10-ecs.tf b/terraform/modules/sql-to-rds-snapshot/10-ecs.tf
@@ -3,7 +3,7 @@ locals {
     { name : "MYSQL_HOST", value : aws_db_instance.ingestion_db.address },
     { name : "MYSQL_USER", value : aws_db_instance.ingestion_db.username },
     { name : "MYSQL_PASS", value : random_password.rds_password.result },
-    { name : "RDS_INSTANCE_ID", value : aws_db_instance.ingestion_db.id },
+    { name : "RDS_INSTANCE_ID", value : aws_db_instance.ingestion_db.identifier },
     { name : "BUCKET_NAME", value : var.watched_bucket_name },
   ]
 
@@ -71,7 +71,7 @@ module "sql_to_parquet" {
         { name : "MYSQL_HOST", value : aws_db_instance.ingestion_db.address },
         { name : "MYSQL_USER", value : aws_db_instance.ingestion_db.username },
         { name : "MYSQL_PASS", value : random_password.rds_password.result },
-        { name : "RDS_INSTANCE_ID", value : aws_db_instance.ingestion_db.id },
+        { name : "RDS_INSTANCE_ID", value : aws_db_instance.ingestion_db.identifier },
         { name : "BUCKET_NAME", value : var.watched_bucket_name },
       ]
     }
diff --git a/terraform/modules/sql-to-rds-snapshot/99-outputs.tf b/terraform/modules/sql-to-rds-snapshot/99-outputs.tf
@@ -5,7 +5,7 @@ output "ecr_repository_worker_endpoint" {
 }
 
 output "rds_instance_id" {
-  value = aws_db_instance.ingestion_db.id
+  value = aws_db_instance.ingestion_db.identifier
 }
 
 output "cloudwatch_event_rule_name" {

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@ locals {`
`3`	`3`	`{ name : "MYSQL_HOST", value : aws_db_instance.ingestion_db.address },`
`4`	`4`	`{ name : "MYSQL_USER", value : aws_db_instance.ingestion_db.username },`
`5`	`5`	`{ name : "MYSQL_PASS", value : random_password.rds_password.result },`
`6`		`- { name : "RDS_INSTANCE_ID", value : aws_db_instance.ingestion_db.id },`
	`6`	`+ { name : "RDS_INSTANCE_ID", value : aws_db_instance.ingestion_db.identifier },`
`7`	`7`	`{ name : "BUCKET_NAME", value : var.watched_bucket_name },`
`8`	`8`	`]`
`9`	`9`
`@@ -71,7 +71,7 @@ module "sql_to_parquet" {`
`71`	`71`	`{ name : "MYSQL_HOST", value : aws_db_instance.ingestion_db.address },`
`72`	`72`	`{ name : "MYSQL_USER", value : aws_db_instance.ingestion_db.username },`
`73`	`73`	`{ name : "MYSQL_PASS", value : random_password.rds_password.result },`
`74`		`- { name : "RDS_INSTANCE_ID", value : aws_db_instance.ingestion_db.id },`
	`74`	`+ { name : "RDS_INSTANCE_ID", value : aws_db_instance.ingestion_db.identifier },`
`75`	`75`	`{ name : "BUCKET_NAME", value : var.watched_bucket_name },`
`76`	`76`	`]`
`77`	`77`	`}`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@ output "ecr_repository_worker_endpoint" {`
`5`	`5`	`}`
`6`	`6`
`7`	`7`	`output "rds_instance_id" {`
`8`		`- value = aws_db_instance.ingestion_db.id`
	`8`	`+ value = aws_db_instance.ingestion_db.identifier`
`9`	`9`	`}`
`10`	`10`
`11`	`11`	`output "cloudwatch_event_rule_name" {`