Skip to content

Commit 9653960

Browse files
authored
Merge pull request #2092 from LBHackney-IT/feature/remove-open-ingress-rule
removes HTTP and HTTPS traffic from coming in via the internet, as custodian removes these rules any way
2 parents 1b8da40 + 0ae3833 commit 9653960

File tree

1 file changed

+2
-20
lines changed

1 file changed

+2
-20
lines changed

terraform/modules/qlik-sense-server/10-aws-ec2.tf

Lines changed: 2 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -75,32 +75,14 @@ resource "aws_security_group" "qlik_sense" {
7575
from_port = 139
7676
to_port = 139
7777
protocol = "tcp"
78-
cidr_blocks = ["10.151.11.27/32"] # Replace with specific IP ranges for better security
78+
cidr_blocks = ["10.151.11.27/32"] # Replace with specific IP ranges for better security
7979
}
8080

8181
ingress {
8282
from_port = 445
8383
to_port = 445
8484
protocol = "tcp"
85-
cidr_blocks = ["10.151.11.27/32"] # Replace with specific IP ranges for better security
86-
}
87-
88-
ingress {
89-
description = "Allow inbound HTTP traffic"
90-
from_port = 80
91-
to_port = 80
92-
protocol = "tcp"
93-
cidr_blocks = ["0.0.0.0/0"]
94-
ipv6_cidr_blocks = ["::/0"]
95-
}
96-
97-
ingress {
98-
description = "Allow inbound HTTPS traffic"
99-
from_port = 443
100-
to_port = 443
101-
protocol = "tcp"
102-
cidr_blocks = ["0.0.0.0/0"]
103-
ipv6_cidr_blocks = ["::/0"]
85+
cidr_blocks = ["10.151.11.27/32"] # Replace with specific IP ranges for better security
10486
}
10587

10688
ingress {

0 commit comments

Comments
 (0)