Skip to content

Commit b4ad3d1

Browse files
authored
Add dq test (#2617)
* Update test values * Update test values; pause housing GX job * add test to look for uniqueness with person and tenancy refs
1 parent d9ed8c8 commit b4ad3d1

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

scripts/jobs/housing/housing_nec_migration_people_data_load_gx_suite.py

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,16 @@
77
import great_expectations.expectations as gxe
88

99

10-
class PeopleExpectPersonRefColumnValuesToBeUnique(gxe.ExpectColumnValuesToBeUnique):
11-
column: str = "lpar_per_alt_ref"
12-
description: str = "Expect lpar_per_alt_ref (person ref) values to be unique"
10+
# class PeopleExpectPersonRefColumnValuesToBeUnique(gxe.ExpectColumnValuesToBeUnique):
11+
# column: str = "lpar_per_alt_ref"
12+
# description: str = "Expect lpar_per_alt_ref (person ref) values to be unique"
13+
14+
15+
16+
class PeopleExpectPersonRefTenancyRefColumnValuesToBeUnique(gxe.ExpectCompoundColumnsToBeUnique):
17+
column: list = ["lpar_per_alt_ref", "lpar_tcy_alt_ref"]
18+
description: str = "Expect lpar_per_alt_ref (person ref) and lpar_tcy_alt_ref (tenancy ref) values to be unique"
19+
1320

1421

1522
class PeopleExpectPersonRefColumnValuesToNotBeNull(gxe.ExpectColumnValuesToNotBeNull):
@@ -120,7 +127,7 @@ class PeopleExpectPeopleColumnsToMatchOrderedList(
120127

121128
suite = gx.ExpectationSuite(name="people_data_load_suite")
122129

123-
suite.add_expectation(PeopleExpectPersonRefColumnValuesToBeUnique())
130+
suite.add_expectation(PeopleExpectPersonRefTenancyRefColumnValuesToBeUnique())
124131
suite.add_expectation(PeopleExpectTitleToBeInSet())
125132
suite.add_expectation(PeopleExpectPeopleColumnsToMatchOrderedList())
126133
suite.add_expectation(PeopleExpectPersonRefColumnValuesToNotBeNull())

0 commit comments

Comments
 (0)