Fix glue database visibility (#2498)

* add unrestricted database access

* add liberator access to parking dept

* update db names from etl state

* formatting

* add identifier_prefix

* add address api db

* fixup

Author: timburke-hackit

terraform/core/05-departments.tf

@@ -73,6 +73,24 @@ module "department_parking" {
   departmental_airflow_user       = true
   mwaa_etl_scripts_bucket_arn     = aws_s3_bucket.mwaa_etl_scripts_bucket.arn
   mwaa_key_arn                    = aws_kms_key.mwaa_key.arn
+  additional_glue_database_access = [
+    {
+      database_name = "${local.identifier_prefix}-liberator-raw-zone"
+      actions       = ["glue:GetTable", "glue:GetTables"]
+    },
+    {
+      database_name = "${local.identifier_prefix}-liberator-refined-zone"
+      actions       = ["glue:GetTable", "glue:GetTables"]
+    },
+    {
+      database_name = "${local.identifier_prefix}-liberator-trusted-zone"
+      actions       = ["glue:GetTable", "glue:GetTables"]
+    },
+    {
+      database_name = "${local.identifier_prefix}-raw-zone-unrestricted-address-api"
+      actions       = ["glue:GetTable", "glue:GetTables"]
+    },
+  ]
 }
 
 module "department_finance" {

terraform/modules/department/50-aws-iam-policies.tf

@@ -202,6 +202,10 @@ data "aws_iam_policy_document" "read_only_glue_access" {
       "arn:aws:glue:${data.aws_region.current.name}:${data.aws_caller_identity.current.account_id}:table/${aws_glue_catalog_database.raw_zone_catalog_database.name}/*",
       "arn:aws:glue:${data.aws_region.current.name}:${data.aws_caller_identity.current.account_id}:table/${aws_glue_catalog_database.refined_zone_catalog_database.name}/*",
       "arn:aws:glue:${data.aws_region.current.name}:${data.aws_caller_identity.current.account_id}:table/${aws_glue_catalog_database.trusted_zone_catalog_database.name}/*",
+      "arn:aws:glue:${data.aws_region.current.name}:${data.aws_caller_identity.current.account_id}:table/unrestricted-raw-zone/*",
+      "arn:aws:glue:${data.aws_region.current.name}:${data.aws_caller_identity.current.account_id}:table/unrestricted-refined-zone/*",
+      "arn:aws:glue:${data.aws_region.current.name}:${data.aws_caller_identity.current.account_id}:table/unrestricted-trusted-zone/*",
+
     ]
   }
 
@@ -585,6 +589,9 @@ data "aws_iam_policy_document" "glue_access" {
       "arn:aws:glue:${data.aws_region.current.name}:${data.aws_caller_identity.current.account_id}:table/${aws_glue_catalog_database.raw_zone_catalog_database.name}/*",
       "arn:aws:glue:${data.aws_region.current.name}:${data.aws_caller_identity.current.account_id}:table/${aws_glue_catalog_database.refined_zone_catalog_database.name}/*",
       "arn:aws:glue:${data.aws_region.current.name}:${data.aws_caller_identity.current.account_id}:table/${aws_glue_catalog_database.trusted_zone_catalog_database.name}/*",
+      "arn:aws:glue:${data.aws_region.current.name}:${data.aws_caller_identity.current.account_id}:table/unrestricted-raw-zone/*",
+      "arn:aws:glue:${data.aws_region.current.name}:${data.aws_caller_identity.current.account_id}:table/unrestricted-refined-zone/*",
+      "arn:aws:glue:${data.aws_region.current.name}:${data.aws_caller_identity.current.account_id}:table/unrestricted-trusted-zone/*",
     ]
   }