Skip to content

Commit eb877d7

Browse files
authored
Merge pull request #2252 from LBHackney-IT/di-620-dq-tests-for-nec-estates-loads
Remove prefix 'r' and start/end of text notifiers (^ $) from regex
2 parents f5f4808 + 885d507 commit eb877d7

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

scripts/jobs/housing/housing_assets_reshape_gx_suite.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ class ExpectUPRNColumnValueLengthsBetween(gxe.ExpectColumnValueLengthsToBeBetwee
2020

2121
class ExpectUPRNColumnValuesToMatchRegex(gxe.ExpectColumnValuesToMatchRegex):
2222
column: str = "uprn"
23-
regex: str = r"^[1-9]\d{10,11}"
23+
regex: str = "[1-9]\d{10,11}"
2424
description: str = "Expect UPRN to match regex ^[1-9]\d{10,11} (starting with digit 1-9, followed by 10 or 11 digits"
2525

2626

scripts/jobs/housing/housing_dwellings_list_gx_suite.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,19 +31,19 @@ class ExpectLLPGColumnValueLengthsBetween(gxe.ExpectColumnValueLengthsToBeBetwee
3131

3232
class ExpectBlockRefNoColumnValuesToMatchRegex(gxe.ExpectColumnValuesToMatchRegex):
3333
column: str = "block_reference_number"
34-
regex: str = r"^\d+$"
34+
regex: str = "\d+$"
3535
description: str = "Expect Block Reference Number to match regex ^\d+$ (numerical)"
3636

3737

3838
class ExpectLLPGColumnValuesToMatchRegex(gxe.ExpectColumnValuesToMatchRegex):
3939
column: str = "llpg"
40-
regex: str = r"^[1-9]\d{10,11}"
40+
regex: str = "[1-9]\d{10,11}"
4141
description: str = "Expect UPRN (LLPG) to match regex ^[1-9]\d{10,11} (starting with digit 1-9, followed by 10 or 11 digits"
4242

4343

4444
class ExpectEstateRefNoColumnValuesToMatchRegex(gxe.ExpectColumnValuesToMatchRegex):
4545
column: str = "estate_reference_number"
46-
regex: str = r"^\d+$"
46+
regex: str = "\d+"
4747
description: str = "Expect Estate Reference Number to match regex ^\d+$ (numerical)"
4848

4949

scripts/jobs/housing/housing_homeowner_record_sheet_gx_suite.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,13 @@ class ExpectPropNoColumnValuesToNotBeNull(gxe.ExpectColumnValuesToNotBeNull):
2424

2525
class ExpectPropNoNoColumnValuesToMatchRegex(gxe.ExpectColumnValuesToMatchRegex):
2626
column: str = "property_no"
27-
regex: str = r"^\d+$"
27+
regex: str = "\d+"
2828
description: str = "Expect Property Number Number to match regex ^\d+$ (numerical)"
2929

3030

3131
class ExpectPaymentRefNoColumnValuesToMatchRegex(gxe.ExpectColumnValuesToMatchRegex):
3232
column: str = "payment_ref"
33-
regex: str = r"^\d+$"
33+
regex: str = "\d+"
3434
description: str = "Expect Payment Reference Number to match regex ^\d+$ (numerical)"
3535

3636

0 commit comments

Comments
 (0)