-
Notifications
You must be signed in to change notification settings - Fork 0
Description
In the rush of getting first API endpoints delivered in the ASAP manner, there has been a mistake made in the naming of the domain and EF Core entities. Due to the confusion caused by this mix up, a new issue appeared, which is the Domain objects referencing EF Core infrastructure classes (evident from the namespace):
lbh-fss-public-api/LBHFSSPublicAPI/V1/Domain/ServiceEntity.cs
Lines 3 to 8 in 2e6fff9
| using LBHFSSPublicAPI.V1.Infrastructure; | |
| namespace LBHFSSPublicAPI.V1.Domain | |
| { | |
| public class ServiceEntity | |
| { |
The following complex types referenced within this Domain entity are actually EF Core entities:
lbh-fss-public-api/LBHFSSPublicAPI/V1/Domain/ServiceEntity.cs
Lines 28 to 32 in 2e6fff9
| public File Image { get; set; } | |
| public Organization Organization { get; set; } | |
| public ICollection<ServiceLocation> ServiceLocations { get; set; } | |
| public ICollection<ServiceTaxonomy> ServiceTaxonomies { get; set; } | |
| } |
It can be seen better from this snippet made within the text editor:
Thankfully, the API behaviour is pretty simple and doesn't require much domain processing and hence doesn't cause functionality issues. However I believe we should fix this to keep Domain and Infrastructure object trees separate for at the very least increasing code readability.
