Correct leads teams process

Previously these docs said that the leads only needed to be added to the '... leads_' team and permissions would be inherited for regular contributions. This is true for the repositories, however the leads also need to be able to manage the team members list, which requires them to have 'maintainer' role on the team (and also to be in that team).

Author: spikeheap

docs/ways-of-working/GitHub/manage_github_teams.md

@@ -28,22 +28,40 @@ Typically a new joiner will need to be added to at least two teams:
 
 ### Adding a regular contributor
 
-1. In the [Teams list](https://github.com/orgs/LBHackney-IT/teams) click on the team you want to add them to.
+Any lead can add people to one or more of their teams.
+
+1. In the [Teams list](https://github.com/orgs/LBHackney-IT/teams) click on the team you want to add them to, e.g. `Housing Products`.
 2. Click `Add a member`
 3. Search for the user's GitHub username.
 4. Click `Invite`.
 
 ### Adding a lead
 
-Leads are added in a subtly different way, in order to grant them the `Admin` role to repositories the team is responsible for.
+Leads are added in a subtly different way, in order to grant them the `Admin` role to repositories the team is responsible for. We add the lead to both the main product _and_ the leads teams, and set them as team maintainers so they can add and remove team members.
 
 > ℹ️ A "lead" in this context is someone trusted to manage the project, and doesn't reflect a specific job title.
 
-1. In the [Teams list](https://github.com/orgs/LBHackney-IT/teams) find the team you want to add them to.
-2. Click the disclosure arrow on the right hand side (next to `X teams`, and click the relevant "... leads" team).
-    ![Screenshot showing the above steps to select the leads team.](../img/github_add_to_leads_team.png)
-3. Click `Add a member`
-4. Search for the user's GitHub username.
-5. Click `Invite`.
+Any lead can add another lead, or this can be carried out by a GitHub admin, e.g. the Head of Engineering.
 
-> ℹ️ The lead doesn't need to be added to the parent team, because the permissions are inherited.
+1. In the [Teams list](https://github.com/orgs/LBHackney-IT/teams) find the team you want to add them to, e.g. `Housing Products`.
+2. Click the disclosure arrow on the right hand side (next to `X teams`, and click the relevant "... leads" team).
+    ![Screenshot showing the above steps to select the leads team.](../img/github_add_to_leads_team.png), and add the user:
+    1. Click `Add a member`.
+    2. Search for the user's GitHub username.
+    3. Click `Invite`.
+3. Change their role to 'Maintainer' for the team:
+    1. Click the check box to the left of the user.
+    2. Click the `1 member selected` drop-down.
+    3. Click `Change role`.
+    4. Select `Maintainer`.
+    5. Click  `Change role`.
+4. Go to the parent team (e.g. `Housing Products`), and add the user:
+    1. Click `Add a member`
+    2. Search for the user's GitHub username.
+    3. Click `Invite`.
+5. Change their role to 'Maintainer' for the team:
+    1. Click the check box to the left of the user.
+    2. Click the `1 member selected` drop-down.
+    3. Click `Change role`.
+    4. Select `Maintainer`.
+    5. Click  `Change role`.