Skip to content

Commit 3990b22

Browse files
committed
Merge branch 'master' into fix/rt_octave_bands
2 parents a0d2c17 + 285cadb commit 3990b22

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

CHANGELOG.rst

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ Bugfix:
2727

2828
- Fixes MicrophoneArray.append(MicrophoneArray)
2929
AttributeError: 'MicrophoneArray' object has no attribute 'shape'.
30+
- Fixes issue #421: When generating a highpass filtered room impulse response make
31+
sure that the output is a memory contiguous NumPy array.
3032

3133
`0.9.0`_ - 2025-12-07
3234
---------------------
@@ -488,7 +490,7 @@ Changed
488490
- Changed while loop to iterate up to `room_isinside_max_iter` in `pyroomacoustics.room.Room.isinside`
489491
- Changed initialization of FastMNMF to accelerate convergence
490492
- Fixed bug in doa/tops (float -> integer division)
491-
- Added vectorised functions in MUSIC
493+
- Added vectorised functions in MUSIC
492494
- Use the vectorised functions in _process of MUSIC
493495

494496

pyroomacoustics/room.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1418,8 +1418,8 @@ def extrude(self, height, v_vec=None, absorption=None, materials=None):
14181418
if len(self.walls[i].absorption) == 1:
14191419
# Single band
14201420
wall_materials[name] = Material(
1421-
energy_absorption=float(self.walls[i].absorption),
1422-
scattering=float(self.walls[i].scatter),
1421+
energy_absorption=float(self.walls[i].absorption.item()),
1422+
scattering=float(self.walls[i].scatter.item()),
14231423
)
14241424
elif len(self.walls[i].absorption) == self.octave_bands.n_bands:
14251425
# Multi-band
@@ -2355,7 +2355,7 @@ def compute_rir(self):
23552355

23562356
# Apply the high-pass filter if requested.
23572357
if rir_hpf_sos is not None:
2358-
rir = sosfiltfilt(rir_hpf_sos, rir)
2358+
rir = np.ascontiguousarray(sosfiltfilt(rir_hpf_sos, rir))
23592359

23602360
self.rir[m].append(rir)
23612361

0 commit comments

Comments
 (0)