Merge pull request #1138 from LEDBrain/fix/command-execution-permissions

fix: do proper command deployment and require NODE_ENV

Author: kdev

src/deploy.ts

@@ -42,19 +42,22 @@ export default async () => {
         console.log(commands);
 
         //  Use this when in development phase
-        await rest.put(
-            Routes.applicationGuildCommands(
-                env.DISCORD_CLIENT_ID,
-                env.DISCORD_DEV_GUILD_ID
-            ),
-            {
+        if (env.NODE_ENV === 'development') {
+            await rest.put(
+                Routes.applicationGuildCommands(
+                    env.DISCORD_CLIENT_ID,
+                    env.DISCORD_DEV_GUILD_ID
+                ),
+                {
+                    body: commands,
+                }
+            );
+        } else if (env.NODE_ENV === 'production') {
+            if (!client.isReady()) return;
+            await rest.put(Routes.applicationCommands(client.user.id), {
                 body: commands,
-            }
-        );
-
-        // await rest.put(Routes.applicationCommands(client.user.id), {
-        //     body: commands,
-        // });
+            });
+        }
 
         console.log('Successfully reloaded application (/) commands.');
     } catch (error) {

src/env.ts

@@ -1,13 +1,15 @@
 import { createEnv } from '@t3-oss/env-core';
 import { z } from 'zod';
 
+const nodeEnvs = ['production', 'development'] as const;
+
 export const env = createEnv({
     isServer: true,
     server: {
         DISCORD_TOKEN: z.string().min(1),
-        DISCORD_CLIENT_ID: z.string().min(1),
-        DISCORD_DEV_GUILD_ID: z.string().min(1),
-        DISCORD_CLIENT_SECRET: z.string().min(1),
+        DISCORD_CLIENT_ID: z.string(),
+        DISCORD_DEV_GUILD_ID: z.string(),
+        DISCORD_CLIENT_SECRET: z.string(),
         DISCORD_REDIRECT_URI: z.string().url().min(1),
 
         DISCORD_ADMIN_ID: z.string().min(1),
@@ -26,6 +28,7 @@ export const env = createEnv({
         GAME_DE: z.string().url().optional(),
         GAME_DE_USERNAME: z.string().min(1),
         GAME_DE_PASSWORD: z.string().min(1),
+        NODE_ENV: z.enum(nodeEnvs),
     },
     runtimeEnv: {
         ...process.env,