Address PR comment 2

Signed-off-by: Ikoh Obaro <[email protected]>

Author: obaroikoh

affiliation/identity.go

@@ -17,13 +17,6 @@ var (
 	emailRegex = regexp.MustCompile("^[a-zA-Z0-9.!#$%&'*+\\/=?^_`{|}~-]+@[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?(?:\\.[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)*$")
 )
 
-const (
-	// TRUE ...
-	TRUE = true
-	// FALSE ...
-	FALSE = false
-)
-
 // Affiliations interface
 type Affiliations interface {
 	AddIdentity(identity *Identity) bool
@@ -88,7 +81,7 @@ func (a *Affiliation) AddIdentity(identity *Identity) bool {
 		log.Println("AddIdentity: Identity is nil")
 		return false
 	}
-	token, err := a.auth0ClientProvider.GetToken(TRUE)
+	token, err := a.auth0ClientProvider.GetToken(true)
 	if err != nil {
 		log.Println(err)
 	}
@@ -135,7 +128,7 @@ func (a *Affiliation) GetIdentity(uuid string) *Identity {
 		log.Println("GetIdentity: uuid is empty")
 		return nil
 	}
-	token, err := a.auth0ClientProvider.GetToken(TRUE)
+	token, err := a.auth0ClientProvider.GetToken(true)
 	if err != nil {
 		log.Println(err)
 	}
@@ -163,7 +156,7 @@ func (a *Affiliation) GetOrganizations(uuid, projectSlug string) *[]Enrollment {
 	if uuid == "" || projectSlug == "" {
 		return nil
 	}
-	token, err := a.auth0ClientProvider.GetToken(TRUE)
+	token, err := a.auth0ClientProvider.GetToken(true)
 	if err != nil {
 		log.Println(err)
 	}
@@ -208,7 +201,7 @@ func (a *Affiliation) GetProfile(uuid, projectSlug string) *ProfileResponse {
 	if uuid == "" || projectSlug == "" {
 		return nil
 	}
-	token, err := a.auth0ClientProvider.GetToken(TRUE)
+	token, err := a.auth0ClientProvider.GetToken(true)
 	if err != nil {
 		log.Println(err)
 	}
@@ -238,7 +231,7 @@ func (a *Affiliation) GetIdentityByUser(key string, value string) (*AffIdentity,
 		nilKeyOrValueErr := "GetIdentityByUser: key or value is null"
 		return nil, fmt.Errorf(nilKeyOrValueErr)
 	}
-	token, err := a.auth0ClientProvider.GetToken(TRUE)
+	token, err := a.auth0ClientProvider.GetToken(true)
 	if err != nil {
 		log.Println(err)
 		return nil, err
@@ -348,7 +341,7 @@ func (a *Affiliation) GetProfileByUsername(username string, projectSlug string)
 		return nil, fmt.Errorf(nilKeyOrValueErr)
 	}
 
-	token, err := a.auth0ClientProvider.GetToken(FALSE)
+	token, err := a.auth0ClientProvider.GetToken(false)
 	if err != nil {
 		log.Println(err)
 		return nil, err

orgs/organization.go

@@ -15,11 +15,6 @@ import (
 	"github.com/LF-Engineering/dev-analytics-libraries/http"
 )
 
-const (
-	// TRUE ...
-	TRUE = true
-)
-
 // Auth0ClientProvider ...
 type Auth0ClientProvider interface {
 	GetToken(validateTokenRequired bool) (string, error)
@@ -67,7 +62,7 @@ func (o *Org) SearchOrganization(name string, pageSize string, offset string) (*
 		log.Println("SearchOrganization: name param is empty")
 		return nil, errors.New("SearchOrganization: name param is empty")
 	}
-	token, err := o.auth0Client.GetToken(TRUE)
+	token, err := o.auth0Client.GetToken(true)
 	if err != nil {
 		log.Println(err)
 		return nil, err
@@ -103,7 +98,7 @@ func (o *Org) LookupOrganization(name string) (*Organization, error) {
 		log.Println("LookupOrganization: name param is empty")
 		return nil, errors.New("LookupOrganization: name param is empty")
 	}
-	token, err := o.auth0Client.GetToken(TRUE)
+	token, err := o.auth0Client.GetToken(true)
 	if err != nil {
 		log.Println(err)
 		return nil, err

users/user.go

@@ -56,14 +56,9 @@ type Client struct {
 	slackProvider    SlackProvider
 }
 
-const (
-	// TRUE ...
-	TRUE = true
-)
-
 // List ...
 func (u *Client) List(email string, pageSize string, offset string) (*ListResponse, error) {
-	token, err := u.auth0Client.GetToken(TRUE)
+	token, err := u.auth0Client.GetToken(true)
 	if err != nil {
 		log.Println("users.List", err)
 		return nil, err