Skip to content
This repository was archived by the owner on May 24, 2024. It is now read-only.

Commit e9b850e

Browse files
Ajinkya Naharajinkyan83
authored andcommitted
DA-4596: remove original code to have param for validating token
Signed-off-by: Ajinkya Nahar <[email protected]>
1 parent 376c27d commit e9b850e

File tree

8 files changed

+17
-26
lines changed

8 files changed

+17
-26
lines changed

auth0/token.go

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ func NewAuth0Client(env,
7575
}
7676

7777
// GetToken ...
78-
func (a *ClientProvider) GetToken(input bool) (string, error) {
78+
func (a *ClientProvider) GetToken() (string, error) {
7979
authToken, err := a.getCachedToken()
8080
if err != nil {
8181
log.Println(err)
@@ -86,22 +86,13 @@ func (a *ClientProvider) GetToken(input bool) (string, error) {
8686
return authToken, errors.New("cached token is empty")
8787
}
8888

89-
if input {
90-
// check token validity
91-
ok, _, err := a.isValid(authToken, false)
92-
if err != nil {
93-
log.Println(err)
94-
return "", err
95-
}
96-
97-
if ok {
98-
return authToken, nil
99-
}
100-
101-
return authToken, errors.New("cached token is not valid")
89+
// check token validity
90+
ok, _, err := a.isValid(authToken, false)
91+
if ok && err == nil {
92+
return authToken, nil
10293
}
10394

104-
return authToken, nil
95+
return authToken, errors.New("cached token is not valid")
10596
}
10697

10798
func (a *ClientProvider) generateToken() (string, error) {

orgs/mocks/auth0_client_provider.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

orgs/mocks/es_client_provider.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

orgs/mocks/http_client_provider.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

orgs/mocks/slack_provider.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

orgs/organization.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import (
1717

1818
// Auth0ClientProvider ...
1919
type Auth0ClientProvider interface {
20-
GetToken(validateTokenRequired bool) (string, error)
20+
GetToken() (string, error)
2121
}
2222

2323
// HTTPClientProvider ...
@@ -62,7 +62,7 @@ func (o *Org) SearchOrganization(name string, pageSize string, offset string) (*
6262
log.Println("SearchOrganization: name param is empty")
6363
return nil, errors.New("SearchOrganization: name param is empty")
6464
}
65-
token, err := o.auth0Client.GetToken(true)
65+
token, err := o.auth0Client.GetToken()
6666
if err != nil {
6767
log.Println(err)
6868
return nil, err
@@ -98,7 +98,7 @@ func (o *Org) LookupOrganization(name string) (*Organization, error) {
9898
log.Println("LookupOrganization: name param is empty")
9999
return nil, errors.New("LookupOrganization: name param is empty")
100100
}
101-
token, err := o.auth0Client.GetToken(true)
101+
token, err := o.auth0Client.GetToken()
102102
if err != nil {
103103
log.Println(err)
104104
return nil, err

users/mocks/auth0_client_provider.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

users/user.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import (
1717

1818
// Auth0ClientProvider ...
1919
type Auth0ClientProvider interface {
20-
GetToken(validateTokenRequired bool) (string, error)
20+
GetToken() (string, error)
2121
}
2222

2323
// HTTPClientProvider ...
@@ -58,7 +58,7 @@ type Client struct {
5858

5959
// List ...
6060
func (u *Client) List(email string, pageSize string, offset string) (*ListResponse, error) {
61-
token, err := u.auth0Client.GetToken(true)
61+
token, err := u.auth0Client.GetToken()
6262
if err != nil {
6363
log.Println("users.List", err)
6464
return nil, err

0 commit comments

Comments
 (0)