fix for cargo clippy --all-targets --all-features

Author: LGSI-KarumuriHari

src/server/apiserver/src/artifact/mod.rs

@@ -153,7 +153,7 @@ pub async fn withdraw(body: &str) -> common::Result<String> {
 #[cfg(test)]
 mod tests {
     use super::*;
-    use tokio;
+    
 
     // -- Test Artifacts --
 

src/server/apiserver/src/grpc/receiver.rs

@@ -413,7 +413,7 @@ mod tests {
         assert!(result.is_ok());
 
         let response = result.unwrap().into_inner();
-        assert_eq!(response.success, false);
+        assert!(!response.success);
         assert!(
             response.message.contains("not found")
                 || response.message.contains("Failed to retrieve node")
@@ -494,7 +494,7 @@ mod tests {
         assert!(result.is_ok());
 
         let response = result.unwrap().into_inner();
-        assert_eq!(response.success, true);
+        assert!(response.success);
         assert_eq!(response.message, "Successfully updated topology");
         assert!(response.updated_topology.is_some());
 
@@ -512,7 +512,7 @@ mod tests {
         assert!(result.is_ok());
 
         let response = result.unwrap().into_inner();
-        assert_eq!(response.success, false);
+        assert!(!response.success);
         assert_eq!(response.message, "No topology provided in request");
         assert!(response.updated_topology.is_none());
     }

src/server/apiserver/src/grpc/sender/filtergateway.rs

@@ -133,7 +133,7 @@ spec:
         tokio::spawn(async move {
             tonic::transport::Server::builder()
                 .add_service(FilterGatewayConnectionServer::new(
-                    MockFilterGateway::default(),
+                    MockFilterGateway,
                 ))
                 .serve_with_incoming(stream)
                 .await

src/server/apiserver/src/main.rs

@@ -21,6 +21,11 @@ mod node;
 mod route;
 
 /// Main function of Piccolo API Server
+#[cfg(feature = "tarpaulin_include")]
+fn main() {
+    // Dummy main for coverage builds
+    println!("Tarpaulin coverage build: main function stub.");
+}
 #[cfg(not(feature = "tarpaulin_include"))]
 #[tokio::main]
 async fn main() {

src/server/apiserver/src/manager.rs

@@ -748,7 +748,7 @@ spec:
         tokio::spawn(async move {
             tonic::transport::Server::builder()
                 .add_service(FilterGatewayConnectionServer::new(
-                    MockFilterGateway::default(),
+                    MockFilterGateway,
                 ))
                 .serve_with_incoming(stream)
                 .await

src/server/apiserver/src/route/api.rs

@@ -55,7 +55,7 @@ async fn withdraw_artifact(body: String) -> Response {
 //UNIT TEST CASES
 #[cfg(test)]
 mod tests {
-    use super::*;
+    
     use crate::route::status;
     use axum::{
         body::Body,

src/server/apiserver/src/route/mod.rs

@@ -58,12 +58,8 @@ mod tests {
         routing::{delete, get, post},
         Router,
     };
-    use std::{error::Error as StdError, net::SocketAddr};
-    use tokio::{
-        net::{TcpListener, TcpStream},
-        task,
-        time::{sleep, Duration},
-    };
+    use std::error::Error as StdError;
+    
     use tower::ServiceExt;
     use tower_http::cors::{Any, CorsLayer};
 
@@ -75,7 +71,7 @@ mod tests {
         assert_eq!(ok_response.status(), StatusCode::OK);
 
         // Negative case: Error response
-        let err = Box::new(std::io::Error::new(std::io::ErrorKind::Other, "test error"))
+        let err = Box::new(std::io::Error::other("test error"))
             as Box<dyn StdError + Send + Sync>;
         let err_response = status(Err(err));
         assert_eq!(err_response.status(), StatusCode::METHOD_NOT_ALLOWED);

src/server/apiserver/tests/apiserver_init.rs

@@ -1,5 +1,5 @@
 use apiserver::manager;
-use tokio::time::{timeout, Duration};
+use tokio::time::Duration;
 
 #[tokio::test(flavor = "current_thread")]
 async fn test_manager_initialize() {

src/server/apiserver/tests/manager_integration.rs

@@ -1,6 +1,4 @@
-use apiserver::manager::{apply_artifact, initialize, withdraw_artifact};
-use common::filtergateway::{Action, HandleScenarioRequest};
-use tokio;
+use apiserver::manager::{apply_artifact, initialize};
 
 /// Correct valid YAML artifact (Scenario + Package + Model)
 const VALID_ARTIFACT_YAML: &str = r#"