Skip to content

Conversation

@hhirtz
Copy link
Member

@hhirtz hhirtz commented Jun 7, 2022

Extracted from #153

Renamed Aabb (axis aligned bounding box) to just BoundinxBox

Also renamed Mbr to OrientedBoundingBox (instead of arbitrarily oriented bounding box). Let me know if you have a better name for this.

Aabb is used for rcb in #165 to keep track of the min/max of each coordinate

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #164 (48abeb8) into master (fb2cf47) will increase coverage by 0.02%.
The diff coverage is 91.07%.

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
+ Coverage   51.71%   51.74%   +0.02%     
==========================================
  Files          42       42              
  Lines        7315     7251      -64     
==========================================
- Hits         3783     3752      -31     
+ Misses       3532     3499      -33     
Impacted Files Coverage Δ
src/lib.rs 100.00% <ø> (ø)
tools/src/bin/medit2svg.rs 0.40% <0.00%> (-0.01%) ⬇️
src/algorithms/recursive_bisection.rs 84.15% <75.00%> (-0.10%) ⬇️
src/algorithms/z_curve.rs 98.60% <85.71%> (+21.67%) ⬆️
src/algorithms/hilbert_curve.rs 65.15% <90.00%> (+0.13%) ⬆️
src/algorithms/k_means.rs 80.25% <100.00%> (ø)
src/geometry.rs 95.98% <100.00%> (-0.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb2cf47...48abeb8. Read the comment docs.

hhirtz added 3 commits June 7, 2022 11:26
to BoundingBox and OrientedBoundingBox

also make the BoundingBox fields public for simplicity.
@hhirtz hhirtz merged commit 28272a9 into master Jun 7, 2022
@cedricchevalier19 cedricchevalier19 deleted the geom-bb branch June 22, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants