Skip to content

Commit 00eac3a

Browse files
committed
Revert "introduced a WITH_EXTERNAL_MACHINETYPES option that uses an external project or an internal one."
This reverts commit 5ee74c9.
1 parent 9761c1a commit 00eac3a

File tree

3 files changed

+5
-31
lines changed

3 files changed

+5
-31
lines changed

CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ cmake_print_variables(smooth3D_VERSION)
1313

1414

1515
option(BUILD_SHARED_LIBS ON)
16-
option(WITH_EXTERNAL_MACHINETYPES "links with an external machine_types project" ON)
1716

1817
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/smooth3D)
1918

smooth3D/CMakeLists.txt

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
#==============================================================================
44
#project(smooth3D CXX)
55

6+
#add_definitions(-DDLLEXPORT)
7+
68
#==============================================================================
79
# CODE STRUCTURE
810
#==============================================================================
@@ -15,12 +17,6 @@ set(SMOOTH3D_SRC_DIR ${CMAKE_CURRENT_SOURCE_DIR}/src)
1517
set(SMOOTH3D_HEADER_FILES
1618
inc/smooth3D/smooth3d.h
1719
)
18-
if (NOT WITH_EXTERNAL_MACHINETYPES)
19-
configure_file(inc/machine_types.h.in ${CMAKE_CURRENT_BINARY_DIR}/inc/machine_types.h @ONLY)
20-
include_directories("${CMAKE_CURRENT_BINARY_DIR}/inc")
21-
set(SMOOTH3D_MACHINETYPES_FILES
22-
inc/machine_types.h)
23-
endif ()
2420

2521

2622
set(SMOOTH3D_SRC_FILES
@@ -61,9 +57,7 @@ set(SMOOTH3D_SRC_FILES
6157
#==============================================================================
6258
# DEPENDENCIES
6359
#==============================================================================
64-
if (WITH_EXTERNAL_MACHINETYPES)
65-
find_package(MachineTypes REQUIRED)
66-
endif ()
60+
find_package(MachineTypes REQUIRED)
6761

6862
find_package(Lima REQUIRED)
6963

@@ -84,7 +78,7 @@ include ("${CMAKE_CURRENT_SOURCE_DIR}/FindMesquite.cmake")
8478
# LIBRARY BUILDING
8579
#==============================================================================
8680

87-
add_library(smooth3D ${SMOOTH3D_HEADER_FILES} ${SMOOTH3D_MACHINETYPES_FILES} ${SMOOTH3D_SRC_FILES})
81+
add_library(smooth3D ${SMOOTH3D_HEADER_FILES} ${SMOOTH3D_SRC_FILES})
8882

8983
#set_target_properties(gmds PROPERTIES PUBLIC_HEADER "${GMDS_HEADER_FILES}")
9084

@@ -94,9 +88,7 @@ add_library(smooth3D ${SMOOTH3D_HEADER_FILES} ${SMOOTH3D_MACHINETYPES_FILES} ${S
9488

9589
target_link_libraries(smooth3D PRIVATE gmds)
9690
target_link_libraries(smooth3D PRIVATE Lima::Lima Mesquite::Mesquite)
97-
if (WITH_EXTERNAL_MACHINETYPES)
98-
target_link_libraries(smooth3D PUBLIC MachineTypes::MachineTypes)
99-
endif ()
91+
target_link_libraries(smooth3D PUBLIC MachineTypes::MachineTypes)
10092

10193
#add_custom_command(
10294
# TARGET gmds
@@ -117,11 +109,6 @@ install(TARGETS smooth3D
117109

118110
install(FILES
119111
${SMOOTH3D_HEADER_FILES} DESTINATION include/smooth3D)
120-
if (NOT WITH_EXTERNAL_MACHINETYPES)
121-
install(FILES
122-
${CMAKE_CURRENT_BINARY_DIR}/inc/machine_types.h DESTINATION include/)
123-
endif ()
124-
125112

126113

127114
set(INCLUDE_INSTALL_DIR include/ )

smooth3D/inc/machine_types.h.in

Lines changed: 0 additions & 12 deletions
This file was deleted.

0 commit comments

Comments
 (0)