Lint recipes (#40)

* Test CI with 2 jobs

* Fix condition on second job

* Fix linter errors

* Merge CIs

* Fix linter errors on recipes

* Change job name

* Do not replace $GITHUB_WORKSPACE by ${{github.workspace}}

Author: lelandaisb

.github/workflows/check-magix3d.yml

@@ -0,0 +1,93 @@
+name: Check push
+
+on:
+  [push, pull_request]
+
+jobs:
+  lint-recipes:
+    name: Lint Recipes
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      packages: write
+
+    steps:
+      - name: Checkout Repository
+        uses: actions/checkout@v4
+
+      - name: Flake8 on meshing
+        uses: py-actions/flake8@v2
+        with:
+          ignore: "E501,F405,F403"
+          path: "meshing"
+
+      - name: Flake8 on meshing_supersede
+        uses: py-actions/flake8@v2
+        with:
+          ignore: "E501,F405,F403,W504"
+          path: "meshing_supersede"
+
+  spack-spec-mgx3d:
+    # The CMake configure and build commands are platform agnostic and should work equally
+    # well on Linux, Windows or Mac.
+    # See: https://docs.github.com/en/free-pro-team@latest/actions/learn-github-actions/managing-complex-workflows#using-a-build-matrix
+    name: Spack Spec Magix3D
+    runs-on:  ubuntu-latest
+    needs: [lint-recipes]
+    strategy:
+      fail-fast: false
+
+    steps:
+      - name: Checkout Repository
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 2 # seems to be needed by codecov
+          submodules: recursive
+
+      - name: Initialize Spack environment
+        shell: bash
+        run: |
+          git clone --depth=1 -b releases/latest https://github.com/spack/spack.git ${{github.workspace}}/spack
+          source ${{github.workspace}}/spack/share/spack/setup-env.sh
+          spack repo add ${{github.workspace}}/meshing
+          spack repo add ${{github.workspace}}/meshing_supersede
+
+      - name: Check Spack spec
+        # We create a subdirectory that will stand as our working directory for all
+        # subsequent commands
+        run: |
+          source ${{github.workspace}}/spack/share/spack/setup-env.sh
+          spack spec magix3d~smooth3d~pythonaddon+doc ^vtk-maillage~opengl2+qt ^qt+opengl
+
+  spack-install-mgx3d:
+    # Do not replace $GITHUB_WORKSPACE by ${{github.workspace}}
+    # See https://github.com/actions/runner/issues/2058
+    name: Spack Install Magix3D
+    runs-on: ubuntu-latest
+    needs: [spack-spec-mgx3d]
+    container:
+      image: ghcr.io/lihpc-computational-geometry/spack-cgcore:latest
+    strategy:
+        fail-fast: false
+
+    steps:
+      - name: Checkout Repository
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 2 # seems to be needed by codecov
+          submodules: recursive
+
+      - name: Initialize Spack Environment
+        shell: bash
+        run: |
+          source /spack/share/spack/setup-env.sh
+          spack repo add $GITHUB_WORKSPACE/meshing
+          spack repo add $GITHUB_WORKSPACE/meshing_supersede
+
+      - name: Build and Install Magix3D
+        shell: bash
+        run: |
+          source /spack/share/spack/setup-env.sh
+          spack env activate meshing-env
+          spack add magix3d~smooth3d~pythonaddon+doc ^vtk-maillage~opengl2+qt ^qt+opengl
+          spack install -v --no-checksum

.github/workflows/check-push.yml

@@ -104,7 +104,9 @@ def cmake_args(self):
         # Installation instructions:
         # https://doc.cgal.org/latest/Manual/installation.html
         spec = self.spec
-        variant_bool = lambda feature: str(feature in spec)
+
+        def variant_bool(feature):
+            str(feature in spec)
         cmake_args = []
 
         cmake_args.append("-DBUILD_SHARED_LIBS:BOOL=%s" % variant_bool("+shared"))

.github/workflows/check-recipes-style.yml

@@ -39,21 +39,22 @@
 #
 from spack import *
 
+
 #
-# omniORB 4.1.7 de ATT tres legerement retouche pour qu'il puisse s'installe dans 
+# omniORB 4.1.7 de ATT tres legerement retouche pour qu'il puisse s'installe dans
 # un environnement spack (de base il y a un probleme de shebang ...)
 #
 class OmniorbAnl(AutotoolsPackage):
     """ORB de ATT"""
 
     homepage = ""
-    url      = "omniorb-anl-4.1.7.tar.gz"
+    url = "omniorb-anl-4.1.7.tar.gz"
     version('4.1.7', sha256='3f42d97cb0344afb25c3b203ec874ad3d2ea944ea75a16bcb5e084c66273691d')
     version('4.3.0')
 
-	# On a besoin de 2.7 <= python < 3.0.0 :
-#    depends_on('[email protected]:', type=('link'))
-#    depends_on('python@:2.7.16', type=('build', 'link'))
+    # On a besoin de 2.7 <= python < 3.0.0 :
+    #    depends_on('[email protected]:', type=('link'))
+    #    depends_on('python@:2.7.16', type=('build', 'link'))
     depends_on('python@:2.7.16', type='run', when="@:4.2.99")
     depends_on('python@3:', type='run', when="@4.3.0:")
 

.github/workflows/check-spec-magix3d.yml

@@ -15,11 +15,11 @@ class Opencascade(CMakePackage):
 
 
 ##############################################
-# WARNING this supersedes the upstream recipe 
+# WARNING this supersedes the upstream recipe
 ##############################################
 
     homepage = "https://www.opencascade.com"
-    url      = "https://git.dev.opencascade.org/gitweb/?p=occt.git;a=snapshot;h=refs/tags/V7_1_0;sf=tgz"
+    url = "https://git.dev.opencascade.org/gitweb/?p=occt.git;a=snapshot;h=refs/tags/V7_1_0;sf=tgz"
 
 #    version('7.4.0', extension='tar.gz',
 #            sha256='1eace85115ea178f268e9d803ced994b66b72455b5484074b6ad7f643261f0a0')
@@ -38,7 +38,7 @@ def url_for_version(self, version):
 
     # modifications for internal use
     patch('opencascade-7.1.0_a.patch', when='@7.1.0')
-    
+
     variant('tbb', default=False,
             description='Build with Intel Threading Building Blocks')
     variant('vtk', default=False,
@@ -60,14 +60,13 @@ def url_for_version(self, version):
     variant('draw', default=False,
             description='Sets BUILD_MODULE_Draw')
     variant('foundationclasses', default=False,
-            description='Sets BUILD_MODULE_FoundationClasses (probably always ON)' )
+            description='Sets BUILD_MODULE_FoundationClasses (probably always ON)')
     variant('modelingalgorithm', default=False,
             description='Sets BUILD_MODULE_ModelingAlgorithm')
     variant('modelingdata', default=False,
             description='Sets BUILD_MODULE_ModelingData')
     variant('visualization', default=False,
             description='Sets BUILD_MODULE_Visualization')
-    
 
     depends_on('intel-tbb', when='+tbb')
     depends_on('vtk', when='+vtk')
@@ -76,7 +75,6 @@ def url_for_version(self, version):
     depends_on('gl2ps', when='@7.1.0+gl2ps')
     depends_on('doxygen', when='+documentation')
 
-
     depends_on('freetype')
     depends_on('tcl')
 
@@ -87,11 +85,11 @@ def url_for_version(self, version):
 
     depends_on('gl')
 
-    # those two libraries are always used at link phase, but it could be a 
-    # remnant of the optionnal gl2ps module. We might be able to remove 
+    # those two libraries are always used at link phase, but it could be a
+    # remnant of the optionnal gl2ps module. We might be able to remove
     # those dependencies in a future release of OCC.
-    depends_on('libxmu', type=('build','link'))
-    depends_on('libxi', type=('build','link'))
+    depends_on('libxmu', type=('build', 'link'))
+    depends_on('libxi', type=('build', 'link'))
 
     def cmake_args(self):
         args = []
@@ -131,7 +129,6 @@ def cmake_args(self):
         else:
             args.append('-DUSE_GL2PS=OFF')
 
-        
         if '+documentation' in self.spec:
             args.append('-DBUILD_DOC_Overview=ON')
         else:
@@ -151,7 +148,7 @@ def cmake_args(self):
             args.append('-DBUILD_MODULE_Draw=ON')
         else:
             args.append('-DBUILD_MODULE_Draw=OFF')
-        
+
         if '+foundationclasses' in self.spec:
             args.append('-DBUILD_MODULE_FoundationClasses=ON')
         else: