Fix some codacy issues

Author: ArzhelaR

docs/actions.md

@@ -18,7 +18,7 @@ However, in some configurations, flip action can lead to problematic configurati
   <img src="img/actions/flip_c_after.png" width="350"/>
 
     * **triangular quad:** This configuration should be avoided, as it results in the creation of a degenerate (flat) triangle. As illustrated in the figures below, flipping dart 0 leads to a flattened face between nodes 2, 0, and 7.
-    * 
+  
   <img src="img/actions/flip_before_tri.png" width="350"/>
   <img src="img/actions/flip_after_tri.png" width="350"/>
 
@@ -51,7 +51,6 @@ However, in some configurations, collapse action can also lead to problematic co
 * **Adjacency too high :** When nodes A already has an adjacency higher than 10, collapse is not possible. 
 * **Configuration who tends to imply edge reversal**: To detect these situations, we look a the type of darts in the surrounding. When there are some darts with concave surrounding, collapse action can lead to edge reversal.
 
-
 <img src="img/actions/collapse_reversal_before.png" width="400"/>
 <img src="img/actions/collapse_reversal_after.png" width="360"/>
 
@@ -65,41 +64,41 @@ However, in some configurations, collapse action can also lead to problematic co
 
 The **flip** action can be decomposed as follows:
 
-- Check whether the dart `d` exists.  
-- Update the **beta1** relations.  
-- Update the links from nodes `n1` and `n2`,  if they were previously linked to the flipped dart.  
-- Update the links from faces `F1` and `F2`, if they were previously linked to the flipped dart.  
-- Update the node links for `d` and `d2`.  
-- Update the face links depending on the orientation (darts which change of face):
-  - If **counterclockwise**: update links for `d1` and `d21`.  
-  - If **clockwise**: update links for `d2111` and `d111`.  
-- Update the scores of the nodes.
+* Check whether the dart `d` exists.  
+* Update the **beta1** relations.  
+* Update the links from nodes `n1` and `n2`,  if they were previously linked to the flipped dart.  
+* Update the links from faces `F1` and `F2`, if they were previously linked to the flipped dart.  
+* Update the node links for `d` and `d2`.  
+* Update the face links depending on the orientation (darts which change of face):
+  * If **counterclockwise**: update links for `d1` and `d21`.  
+  * If **clockwise**: update links for `d2111` and `d111`.  
+* Update the scores of the nodes.
 
 ## Split 
 
 <img src="img/actions/split_quad.png" width="600"/>
 
 The **split** action can be decomposed as follows:
 
-- Check whether the dart `d` exists.  
-- Create a new node **n10** in the middle of [n1,n2]
-- Update node links of `d` and `d21`, they are now linked to `n10`
-- Create a new face with yellow darts
-- Update the **beta2** relations (`d1112`, `d111`,`d212`, `d21`).
-- Update the scores of the nodes.
+* Check whether the dart `d` exists.  
+* Create a new node **n10** in the middle of [n1,n2]
+* Update node links of `d` and `d21`, they are now linked to `n10`
+* Create a new face with yellow darts
+* Update the **beta2** relations (`d1112`, `d111`,`d212`, `d21`).
+* Update the scores of the nodes.
 
 ## Collapse 
 
 <img src="img/actions/collapse_quad.png" width="600"/>
 
 The **collapse** action can be decomposed as follows:
 
-- Check whether the dart `d` exists.  
-- Save the score of node `n1` for later computation.  
-- If `n3` is not on the boundary, move its coordinates to the midpoint between `n3` and `n1`.  
-- Check if nodes `n2` and `n4` are linked to the dart being deleted. If so, reassign their links to existing darts (node `n3` will be checked later).  
-- Delete the face associated with `d`, along with its related darts.  
-- Reassign all darts previously linked to `n1` so they now point to `n3`.  
-- Link the dart associated with `n3` to an existing node.  
-- Update the **beta2** relations (`d2`/`d12`, `d112`/`d1112`).  
-- Recalculate the scores of the affected nodes.
+* Check whether the dart `d` exists.  
+* Save the score of node `n1` for later computation.  
+* If `n3` is not on the boundary, move its coordinates to the midpoint between `n3` and `n1`.  
+* Check if nodes `n2` and `n4` are linked to the dart being deleted. If so, reassign their links to existing darts (node `n3` will be checked later).  
+* Delete the face associated with `d`, along with its related darts.  
+* Reassign all darts previously linked to `n1` so they now point to `n3`.  
+* Link the dart associated with `n3` to an existing node.  
+* Update the **beta2** relations (`d2`/`d12`, `d112`/`d1112`).  
+* Recalculate the scores of the affected nodes.

mesh_model/mesh_analysis/trimesh_analysis.py

@@ -1,10 +1,8 @@
 import math
 from math import radians, cos, sin
 
-from networkx.classes import nodes
 from scipy.spatial import ConvexHull, Delaunay
 from shapely import affinity
-from shapely.constructive import centroid
 
 from shapely.geometry import Polygon, Point, LineString
 

training/config/quadmesh_config_PPO_SB3.yaml

@@ -1,5 +1,5 @@
 project_name : "Quadmesh"
-experiment_name : "test"
+experiment_name : "TEST"
 description : ""
 
 total_timesteps : 10000
@@ -12,8 +12,8 @@ paths:
   observation_counts_dir: "training/results/quad-sb3/observation_counts/"
 
 dataset:
-  evaluation_mesh_file_path : "../mesh_files/simple_quad.msh"
-  training_mesh_file_path : "../mesh_files/simple_quad.msh"
+  evaluation_mesh_file_path : "mesh_files/simple_quad.msh"
+  training_mesh_file_path : "mesh_files/simple_quad.msh"
 
 seed : 1
 

training/config/quadmesh_config_PPO_perso.yaml

@@ -1,5 +1,5 @@
 project_name : "Quadmesh"
-experiment_name : "random_basic_quad_test_config-TEST"
+experiment_name : "TEST"
 description : ""
 
 paths:

training/train_quadmesh.py

@@ -129,34 +129,4 @@ def log_end(log_writer, config, obs_registry):
     # SAVING POLICY
     torch.save(actor.state_dict(), config["paths"]["policy_saving_dir"]+config["experiment_name"]+".pth")
     writer.close()
-    wandb.finish()
-
-
-
-def train():
-    mesh_size = 30
-    lr = 0.0001
-    gamma = 0.9
-    feature = LOCAL_MESH_FEAT
-
-    dataset = [TM.random_mesh(30) for _ in range(9)]
-    plot_dataset(dataset)
-
-    env = TriMesh(None, mesh_size, max_steps=80, feat=feature)
-
-    # Choix de la politique Actor Critic
-    # actor = Actor(env, 30, 5, lr=0.0001)
-    # critic = Critic(30, lr=0.0001)
-    # policy = NNPolicy(env, 30, 64,5, 0.9, lr=0.0001)
-
-    model = PPO(env, lr, gamma, nb_iterations=3, nb_episodes_per_iteration=10, nb_epochs=2, batch_size=8)
-    actor, rewards, wins, steps = model.train()
-    if rewards is not None:
-        plot_training_results(rewards, wins, steps)
-
-    # torch.save(actor.state_dict(), 'policy_saved/actor_network.pth')
-    avg_steps, avg_wins, avg_rewards, final_meshes = testPolicy(actor, 5, dataset, 60)
-
-    if rewards is not None:
-        plot_test_results(avg_rewards, avg_wins, avg_steps, avg_rewards)
-    plot_dataset(final_meshes)
+    wandb.finish()

training/train_quadmesh_SB3.py

@@ -231,7 +231,7 @@ def _on_training_end(self) -> None:
 if __name__ == '__main__':
 
     # PARAMETERS CONFIGURATION
-    with open("../training/config/quadmesh_config_PPO_SB3.yaml", "r") as f:
+    with open("training/config/quadmesh_config_PPO_SB3.yaml", "r") as f:
         config = yaml.safe_load(f)
 
     experiment_name = config["experiment_name"]