65 only topological constraints #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion validation. There are still some issues that need to be corrected.
A new feature has been added to mesh plotting: dart ID visualization. Only the flip action is available. New topological checks are performed after actions.
A geometrical quality criterion is now included in the observation. This is so far only supported in a trimesh_full environment with action flip.
Quadrangular environment not working.
…s and with old geometrical analysis. There are still some kinds of meshes which create problems with the new analysis
…New documentation for quad actions
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significant changes have been made to the 'mesh analysis' process.
Previously, actions were defined as either valid or invalid based on specific topological and geometric criteria, such as nodes adjacency, face orientation with cross products, edge length, angle , and so on. This type of analysis is now always possible in the 'TriMeshOldAnalysis' and 'QuadMeshOldAnalysis' classes.
Now, a new analysis class has been added: 'TriMeshQualityAnalysis'. This defines the validity of actions according to topological criteria and a classification of possible geometric configurations, as detailed in the documentation. Combined with observation of this classification, learning becomes more consistent.
Later on, new classes can be added to test new analysis methods.