Create Snapshots fails with uppercase letters or _

[t0mat000]

Creating snapshots through the Proxmox interface fails when uppercase letters or _ are used in the naming. Even worse, sometimes the resource is still created in Linstor DRBD. Most of the time it can then be deleted. The issue has apparently existed for a few years. We were able to reproduce it with the latest Proxmox 8 as well as with Proxmox 9.

And particularly ‘interesting’ is that the resource is now called ‘vm-102-state-UpDateW’, even though ‘UpDateW’ was the name of a snapshot that was never actually created.

[rck]

yes, that is at least partially known... LINSTOR has its own definition what a valid name is, I'd guess for resources as well as snapshots. and they might even be slightly different from what a valid DRBD name is. obviously every valid LINSTOR name has to be a valid DRBD name. and snapshot names need to be valid for snapshots on the backing devices (LVM/ZFS).

back then I did not want to implement such a name check in the plugin. but yes, some regex or using/adding a LINSTOR APi for valid names could be an improvement here. So far the solution was: don't do that then. Also I thought that when the failure/cleanup path is good enough - which it might not be - then this is equally good. Does not really matter if one gets a "wrong name" failure from the regex/API or when LINSTOR actually tried it. So having a clean error and cleanup path probably is still where time should be spent.

[Jay2k1]

+1 for checking, error handling & cleanup. Whatever the PVE web interface allows, users will eventually do/try (and they might not necessarily know what valid DRBD names are).

[t0mat000]

I would be very happy if the snapshot issue could be fixed. The last time this happened with vm-43162, things went so badly wrong that we had to restore the VM from a backup. We also can’t use the old ID anymore because all attempts to delete it fail. The ZFS volumes seem to be already gone (and half of the drbd), and the Linstor resources can’t be deleted. Maybe you have an idea?

root@server01: drbdadm status vm-43162-disk-1
'vm-43162-disk-1' not defined in your config (for this host).

root@server01: linstor resource list | grep 43162
| vm-43162-disk-1 | server01 | DRBD,STORAGE | | Ok | DELETING | 2022-05-09 12:19:14 |
| vm-43162-disk-1 | server02 | DRBD,STORAGE | | Ok | DELETING | 2022-05-09 12:19:14 |

root@server01: linstor volume list | grep 43162
| vm-43162-disk-1 | server01 | NVME_DRBD_R1_2 | 0 | 1052 | None | 32.01 GiB | | Unknown | |
| vm-43162-disk-1 | server02 | NVME_DRBD_R1_2 | 0 | 1052 | None | -1 KiB | Unused | Unknown | |

---

root@server02: drbdadm status vm-43162-disk-1
vm-43162-disk-1 role:Secondary

root@server02: linstor resource list | grep 43162
| vm-43162-disk-1 | server01 | DRBD,STORAGE | | Ok | DELETING | 2022-05-09 12:19:14 |
| vm-43162-disk-1 | server02 | DRBD,STORAGE | | Ok | DELETING | 2022-05-09 12:19:14 |

root@server02: linstor volume list | grep 43162
| vm-43162-disk-1 | server01 | NVME_DRBD_R1_2 | 0 | 1052 | None | 32.01 GiB | | Unknown | |
| vm-43162-disk-1 | server02 | NVME_DRBD_R1_2 | 0 | 1052 | None | -1 KiB | Unused | Unknown | |