Skip to content

Commit 12eaf75

Browse files
committed
chore(dashboard): resolve copilot comments
1 parent 328b03a commit 12eaf75

File tree

9 files changed

+25
-32
lines changed

9 files changed

+25
-32
lines changed

packages/apps/app-dashboard/public/fonts/encode-sans-semi-expanded/style.css

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
@font-face {
22
font-family: 'Encode Sans Semi Expanded';
33
src: local('Encode Sans Semi Expanded Regular'), local('Encode-Sans-Semi-Expanded-Regular'),
4-
url('EncodeSansSemiExpanded-Regular.woff2') format('woff2'),
5-
url('EncodeSansSemiExpanded-Regular.woff') format('woff'),
64
url('EncodeSansSemiExpanded-Regular.ttf') format('truetype');
75
font-weight: 400;
86
font-style: normal;

packages/apps/app-dashboard/src/components/explorer/ui/AppFilter.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ export function AppFilter({
3232
placeholder="Search applications..."
3333
value={searchQuery}
3434
onChange={(e) => setSearchQuery(e.target.value)}
35-
className={`w-full pl-10 pr-4 py-3 rounded-xl ${theme.itemBg} border ${theme.cardBorder} ${theme.text} ${theme.textMuted} transition-all duration-300 focus:outline-none`}
35+
className={`w-full pl-10 pr-4 py-3 rounded-xl ${theme.itemBg} border ${theme.cardBorder} ${theme.text} ${theme.textMuted} transition-all duration-300 focus:outline-none focus:ring-2 focus:ring-[#FF4205]`}
3636
style={fonts.body}
3737
/>
3838
</div>
@@ -44,7 +44,7 @@ export function AppFilter({
4444
<select
4545
value={statusFilter}
4646
onChange={(e) => setStatusFilter(e.target.value)}
47-
className={`px-3 py-2 rounded-lg bg-white dark:bg-gray-900 border ${theme.cardBorder} ${theme.text} text-sm transition-all duration-300 focus:outline-none hover:border-gray-300 dark:hover:border-white/20 cursor-pointer`}
47+
className={`px-3 py-2 rounded-lg bg-white dark:bg-gray-900 border ${theme.cardBorder} ${theme.text} text-sm transition-all duration-300 focus:outline-none focus:ring-2 focus:ring-[#FF4205] hover:border-gray-300 dark:hover:border-white/20 cursor-pointer`}
4848
style={fonts.heading}
4949
>
5050
<option
@@ -71,7 +71,7 @@ export function AppFilter({
7171
<select
7272
value={sortBy}
7373
onChange={(e) => setSortBy(e.target.value)}
74-
className={`px-3 py-2 rounded-lg bg-white dark:bg-gray-900 border ${theme.cardBorder} ${theme.text} text-sm transition-all duration-300 focus:outline-none hover:border-gray-300 dark:hover:border-white/20 cursor-pointer`}
74+
className={`px-3 py-2 rounded-lg bg-white dark:bg-gray-900 border ${theme.cardBorder} ${theme.text} text-sm transition-all duration-300 focus:outline-none focus:ring-2 focus:ring-[#FF4205] hover:border-gray-300 dark:hover:border-white/20 cursor-pointer`}
7575
style={fonts.heading}
7676
>
7777
<option

packages/apps/app-dashboard/src/components/explorer/ui/ExplorerNav.tsx

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,7 @@ export function ExplorerNav({ onNavigate, sidebarTrigger }: ExplorerNavProps) {
4141
<div className="flex items-center gap-3 sm:gap-6">
4242
{/* Sidebar trigger for mobile */}
4343
{sidebarTrigger && (
44-
<div className="md:hidden flex items-center relative" style={{ paddingTop: '10px' }}>
45-
{sidebarTrigger}
46-
</div>
44+
<div className="md:hidden flex items-center relative pt-2.5">{sidebarTrigger}</div>
4745
)}
4846
{/* Logo */}
4947
<button
@@ -62,7 +60,7 @@ export function ExplorerNav({ onNavigate, sidebarTrigger }: ExplorerNavProps) {
6260
</button>
6361

6462
{/* Desktop Nav Links */}
65-
<div className="hidden md:flex items-center gap-1" style={{ paddingTop: '10px' }}>
63+
<div className="hidden md:flex items-center gap-1 pt-2.5">
6664
<button
6765
onClick={() => handleNavigation('/user/apps')}
6866
className="px-3 py-1.5 rounded-lg text-sm transition-colors no-underline hover:bg-gray-100 dark:hover:bg-gray-800 leading-none"
@@ -97,7 +95,7 @@ export function ExplorerNav({ onNavigate, sidebarTrigger }: ExplorerNavProps) {
9795
</div>
9896

9997
{/* Right side: Utility links and mobile menu */}
100-
<div className="flex items-center gap-1 md:gap-2" style={{ paddingTop: '10px' }}>
98+
<div className="flex items-center gap-1 md:gap-2 pt-2.5">
10199
{/* Desktop utility links */}
102100
<div className="hidden md:flex items-center gap-1 md:gap-2">
103101
<a

packages/apps/app-dashboard/src/components/shared/ui/sidebar.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ function Sidebar({
178178

179179
if (isMobile) {
180180
return (
181-
<Sheet open={openMobile} onOpenChange={setOpenMobile} modal={false} {...props}>
181+
<Sheet open={openMobile} onOpenChange={setOpenMobile} modal={true} {...props}>
182182
<SheetContent
183183
data-slot="sidebar"
184184
data-mobile="true"

packages/apps/app-dashboard/src/components/user-dashboard/auth/AuthMethods.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
import { Dispatch, SetStateAction, useEffect } from 'react';
22
import { theme as themeImport, fonts } from '../connect/ui/theme';
3+
import { AuthView } from '../connect/Connect';
34

45
interface AuthMethodsProps {
5-
setView: Dispatch<SetStateAction<string>>;
6+
setView: Dispatch<SetStateAction<AuthView>>;
67
clearError?: () => void;
78
}
89

packages/apps/app-dashboard/src/components/user-dashboard/auth/ConnectMethods.tsx

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ interface ConnectProps {
2424
clearError?: () => void;
2525
theme: ThemeType;
2626
view: AuthView;
27-
setView: (view: AuthView) => void;
27+
setView: Dispatch<SetStateAction<AuthView>>;
2828
}
2929

3030
export default function ConnectMethods({
@@ -47,10 +47,7 @@ export default function ConnectMethods({
4747
exit={{ opacity: 0 }}
4848
transition={{ duration: 0.2, ease: 'easeInOut' }}
4949
>
50-
<AuthMethods
51-
setView={setView as Dispatch<SetStateAction<string>>}
52-
clearError={clearError}
53-
/>
50+
<AuthMethods setView={setView} clearError={clearError} />
5451
</motion.div>
5552
)}
5653
{view === 'email' && (
@@ -64,7 +61,7 @@ export default function ConnectMethods({
6461
<StytchOTP
6562
method="email"
6663
authWithStytch={authWithStytch}
67-
setView={setView as Dispatch<SetStateAction<string>>}
64+
setView={setView}
6865
theme={theme}
6966
/>
7067
</motion.div>
@@ -80,7 +77,7 @@ export default function ConnectMethods({
8077
<StytchOTP
8178
method="phone"
8279
authWithStytch={authWithStytch}
83-
setView={setView as Dispatch<SetStateAction<string>>}
80+
setView={setView}
8481
theme={theme}
8582
/>
8683
</motion.div>
@@ -93,11 +90,7 @@ export default function ConnectMethods({
9390
exit={{ opacity: 0 }}
9491
transition={{ duration: 0.2, ease: 'easeInOut' }}
9592
>
96-
<EthWalletAuth
97-
authWithEthWallet={authWithEthWallet}
98-
setView={setView as Dispatch<SetStateAction<string>>}
99-
theme={theme}
100-
/>
93+
<EthWalletAuth authWithEthWallet={authWithEthWallet} setView={setView} theme={theme} />
10194
</motion.div>
10295
)}
10396
{view === 'webauthn' && (
@@ -111,7 +104,7 @@ export default function ConnectMethods({
111104
<WebAuthn
112105
authWithWebAuthn={authWithWebAuthn}
113106
registerWithWebAuthn={registerWithWebAuthn}
114-
setView={setView as Dispatch<SetStateAction<string>>}
107+
setView={setView}
115108
clearError={clearError}
116109
theme={theme}
117110
/>

packages/apps/app-dashboard/src/components/user-dashboard/auth/EthWalletAuth.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { useState, useEffect, useRef } from 'react';
1+
import { useState, useEffect, useRef, Dispatch, SetStateAction } from 'react';
22
import { createAppKit } from '@reown/appkit/react';
33
import { WagmiAdapter } from '@reown/appkit-adapter-wagmi';
44
import { mainnet, polygon, arbitrum, optimism, base, AppKitNetwork } from '@reown/appkit/networks';
@@ -7,13 +7,14 @@ import { Button } from '@/components/shared/ui/button';
77
import { ThemeType, fonts } from '../connect/ui/theme';
88
import StatusMessage from '../connect/StatusMessage';
99
import { env } from '@/config/env';
10+
import { AuthView } from '../connect/Connect';
1011

1112
interface WalletAuthProps {
1213
authWithEthWallet: (
1314
address: string,
1415
signMessage: (message: string) => Promise<string>,
1516
) => Promise<void>;
16-
setView: (view: string) => void;
17+
setView: Dispatch<SetStateAction<AuthView>>;
1718
theme: ThemeType;
1819
}
1920

@@ -258,4 +259,4 @@ export default function EthWalletAuth({ authWithEthWallet, theme }: WalletAuthPr
258259
</div>
259260
</>
260261
);
261-
}
262+
}

packages/apps/app-dashboard/src/components/user-dashboard/auth/StytchOTP.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { useState, useEffect } from 'react';
1+
import { useState, useEffect, Dispatch, SetStateAction } from 'react';
22
import { useStytch } from '@stytch/react';
33
import { z } from 'zod';
44
import { Button } from '@/components/shared/ui/button';
@@ -7,11 +7,12 @@ import StatusMessage from '../connect/StatusMessage';
77
import { countryCodes } from '@/utils/user-dashboard/countryCodes';
88
import CountryCodeSelector from '@/components/shared/ui/CountryCodeSelector';
99
import validator from 'validator';
10+
import { AuthView } from '../connect/Connect';
1011

1112
interface StytchOTPProps {
1213
method: OtpMethod;
1314
authWithStytch: any;
14-
setView: React.Dispatch<React.SetStateAction<string>>;
15+
setView: Dispatch<SetStateAction<AuthView>>;
1516
theme: ThemeType;
1617
}
1718

packages/apps/app-dashboard/src/components/user-dashboard/auth/WebAuthn.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
1-
import { useState } from 'react';
1+
import { useState, Dispatch, SetStateAction } from 'react';
22
import { Button } from '@/components/shared/ui/button';
33
import { ThemeType, fonts } from '../connect/ui/theme';
44
import StatusMessage from '../connect/StatusMessage';
55
import { PasskeyNameInput } from '@/components/shared/ui/PasskeyNameInput';
6+
import { AuthView } from '../connect/Connect';
67

78
interface WebAuthnProps {
89
authWithWebAuthn: any;
9-
setView: React.Dispatch<React.SetStateAction<string>>;
10+
setView: Dispatch<SetStateAction<AuthView>>;
1011
registerWithWebAuthn?: (displayName: string) => Promise<void>;
1112
clearError?: () => void;
1213
theme: ThemeType;

0 commit comments

Comments
 (0)