chore: copolit feedback

Author: spacesailor24

packages/apps/ability-hyperliquid/src/lib/ability-checks/deposit.ts

@@ -29,11 +29,11 @@ export const depositPrechecks = async ({
 }): Promise<DepositPrechecksResult> => {
   const usdcAddress = useTestnet ? ARBITRUM_USDC_ADDRESS_TESTNET : ARBITRUM_USDC_ADDRESS_MAINNET;
   const usdcContract = new ethers.Contract(usdcAddress, ERC20_ABI, provider);
-  const amountWei = ethers.utils.parseUnits(depositAmount, 6);
+  const amountInMicroUsdc = ethers.utils.parseUnits(depositAmount, 6);
 
   const balance = await usdcContract.balanceOf(agentWalletPkpEthAddress);
 
-  if (balance.lt(amountWei)) {
+  if (balance.lt(amountInMicroUsdc)) {
     return {
       success: false,
       reason: `Insufficient USDC balance. Required: ${depositAmount} USDC, Available: ${ethers.utils.formatUnits(balance, 6)} USDC`,

packages/apps/ability-hyperliquid/src/lib/schemas.ts

@@ -20,7 +20,7 @@ export const transferParamsSchema = z.object({
   amount: z
     .string()
     .describe(
-      'Amount of USDC to transfer to spot or perp in smallest USDC units (e.g. "1000000" for 1.0 USDC)',
+      'Amount of USDC to transfer to spot or perp, specified in micro-units as a string (e.g., "1000000" means 1.0 USDC; 1 USDC = 1,000,000 micro-units).',
     ),
 });
 

packages/apps/ability-hyperliquid/src/lib/vincent-ability.ts

@@ -333,8 +333,6 @@ export const vincentAbility = createVincentAbility({
             return fail({ action, reason: 'Deposit parameters are required' });
           }
 
-          const useTestnet = abilityParams.useTestnet ?? false;
-
           // Get Arbitrum RPC URL
           const rpcUrl = await Lit.Actions.getRpcUrl({ chain: 'arbitrum' });
 

packages/apps/ability-hyperliquid/test/e2e/spot/buy.spec.ts

@@ -184,7 +184,7 @@ describe('Hyperliquid Ability E2E Spot Trading Tests', () => {
       expect(precheckResult.result.action).toBe(HyperliquidAction.SPOT_BUY);
     });
 
-    it('should execute spot buy to purchase SOL with USDC', async () => {
+    it(`[Spot Buy] should execute spot buy to purchase ${TOKEN_OUT_NAME} with ${SPOT_BUY_AMOUNT_USDC} USDC`, async () => {
       const hyperliquidAbilityClient = getVincentAbilityClient({
         bundledVincentAbility: hyperliquidBundledAbility,
         ethersSigner: wallets.appDelegatee,
@@ -259,10 +259,10 @@ describe('Hyperliquid Ability E2E Spot Trading Tests', () => {
         console.log(`[Spot Buy] Initial ${TOKEN_OUT_NAME}:`, initialTokenOutBalance);
         console.log(`[Spot Buy] Final ${TOKEN_OUT_NAME}:`, finalTokenOutBalance);
 
-        // Store BTC amount for sell test
+        // Store TOKEN_OUT_NAME amount for sell test
         tokenOutAmountReceived = finalTokenOutBalance;
 
-        // BTC balance should increase (order might not fill immediately)
+        // TOKEN_OUT_NAME balance should increase (order might not fill immediately)
         // We just check that the order was placed successfully
         expect(parseFloat(finalTokenOutBalance)).toBeGreaterThanOrEqual(
           parseFloat(initialTokenOutBalance),