chore: optimizations

Author: spacesailor24

packages/apps/ability-hyperliquid/src/generated/lit-action.js

@@ -1,3 +1,3 @@
 {
-  "ipfsCid": "QmUpGqvnfLEthsyK9MYM59794SEKerPhe7Jv1fDLLggZTz"
+  "ipfsCid": "QmbWiHwBJq3X59qeibfGmjBPVKj4ti6hFUxCvCnw1r84Ec"
 }

packages/apps/ability-hyperliquid/src/generated/vincent-ability-metadata.json

@@ -1 +1,4 @@
 export { bundledVincentAbility } from './generated/vincent-bundled-ability';
+
+// Export enums and types for users
+export { HyperliquidAction, TimeInForce, OrderType } from './lib/types';

packages/apps/ability-hyperliquid/src/index.ts

@@ -1,18 +1,25 @@
 import { ethers } from 'ethers';
 import { ERC20_ABI } from '@lit-protocol/vincent-ability-sdk';
 
-import { ARBITRUM_USDC_ADDRESS, DepositPrechecksResult } from '../types';
+import {
+  ARBITRUM_USDC_ADDRESS_MAINNET,
+  ARBITRUM_USDC_ADDRESS_TESTNET,
+  DepositPrechecksResult,
+} from '../types';
 
 export const depositPrechecks = async ({
   provider,
   agentWalletPkpEthAddress,
   depositAmount,
+  useTestnet = false,
 }: {
   provider: ethers.providers.Provider;
   agentWalletPkpEthAddress: string;
   depositAmount: string;
+  useTestnet?: boolean;
 }): Promise<DepositPrechecksResult> => {
-  const usdcContract = new ethers.Contract(ARBITRUM_USDC_ADDRESS, ERC20_ABI, provider);
+  const usdcAddress = useTestnet ? ARBITRUM_USDC_ADDRESS_TESTNET : ARBITRUM_USDC_ADDRESS_MAINNET;
+  const usdcContract = new ethers.Contract(usdcAddress, ERC20_ABI, provider);
   const amountWei = ethers.utils.parseUnits(depositAmount, 6);
 
   const balance = await usdcContract.balanceOf(agentWalletPkpEthAddress);

packages/apps/ability-hyperliquid/src/lib/ability-checks/deposit.ts

@@ -49,16 +49,15 @@ export async function perpTradePrechecks(
     });
 
     // Check if user has any cross margin value or margin summary
-    const crossMarginSummary = perpState.crossMarginSummary;
-    if (!crossMarginSummary) {
+    if (!perpState.crossMarginSummary) {
       return {
         success: false,
         reason: 'No perp account found. Please transfer funds to perp account first.',
         assetId,
       };
     }
 
-    const accountValue = parseFloat(crossMarginSummary.accountValue);
+    const accountValue = parseFloat(perpState.crossMarginSummary.accountValue);
     if (accountValue <= 0) {
       return {
         success: false,

packages/apps/ability-hyperliquid/src/lib/ability-checks/perp.ts

@@ -13,6 +13,12 @@ export interface PerpTradeParams {
   price: string;
   size: string;
   isLong: boolean; // true for long, false for short
+  /**
+   * Reduce-only flag. If true, order will only reduce existing position.
+   * Use this to close positions - the order will only fill up to the position size.
+   * @default false
+   */
+  reduceOnly?: boolean;
   /**
    * Order type configuration.
    * - For limit orders: specify { type: 'limit', tif: 'Gtc' | 'Ioc' | 'Alo' }
@@ -56,7 +62,6 @@ export async function executePerpOrder({
 
   // Create PKP wallet
   const pkpWallet = new LitActionPkpEthersWallet(pkpPublicKey);
-  const pkpAddress = await pkpWallet.getAddress();
 
   // Set leverage if specified
   if (params.leverage) {
@@ -127,7 +132,7 @@ export async function executePerpOrder({
         b: params.isLong, // true for long (buy), false for short (sell)
         p: params.price,
         s: params.size,
-        r: false, // reduce only (false for opening positions)
+        r: params.reduceOnly ?? false, // reduce only (true to close positions, false for opening)
         t: orderTypeField,
       },
     ],

packages/apps/ability-hyperliquid/src/lib/ability-helpers/execute-perp-order.ts

@@ -6,12 +6,10 @@ export const actionTypeSchema = z.enum([
   'transferToPerp',
   'spotBuy',
   'spotSell',
-  'spotCancelOrder',
-  'spotCancelAll',
   'perpLong',
   'perpShort',
-  'perpCancelOrder',
-  'perpCancelAll',
+  'cancelOrder',
+  'cancelAllOrdersForSymbol',
 ]);
 
 export const depositParamsSchema = z.object({
@@ -51,12 +49,12 @@ export const spotTradeParamsSchema = z.object({
     ),
 });
 
-export const spotCancelOrderParamsSchema = z.object({
+export const cancelOrderParamsSchema = z.object({
   symbol: z.string().describe('Trading pair symbol (e.g., "PURR/USDC")'),
   orderId: z.number().describe('Order ID to cancel'),
 });
 
-export const spotCancelAllParamsSchema = z.object({
+export const cancelAllOrdersForSymbolParamsSchema = z.object({
   symbol: z.string().describe('Trading pair symbol to cancel all orders for (e.g., "PURR/USDC")'),
 });
 
@@ -66,22 +64,19 @@ export const perpTradeParamsSchema = z.object({
   size: z.string().describe('Order size in base asset'),
   leverage: z.number().min(1).max(50).optional().describe('Leverage multiplier (default: 2x)'),
   isCross: z.boolean().optional().describe('Cross leverage (default: true)'),
+  reduceOnly: z
+    .boolean()
+    .optional()
+    .describe(
+      'Reduce-only: if true, order will only reduce existing position and cannot increase it (default: false). Use this to close positions without worrying about exact size.',
+    ),
   orderType: orderTypeSchema
     .optional()
     .describe(
       'Order type: { type: "limit", tif: "Gtc" | "Ioc" | "Alo" } or { type: "market" }. Default: { type: "limit", tif: "Gtc" }',
     ),
 });
 
-export const perpCancelOrderParamsSchema = z.object({
-  symbol: z.string().describe('Perpetual symbol (e.g., "ETH")'),
-  orderId: z.number().describe('Order ID to cancel'),
-});
-
-export const perpCancelAllParamsSchema = z.object({
-  symbol: z.string().describe('Perpetual symbol to cancel all orders for (e.g., "ETH")'),
-});
-
 export const abilityParamsSchema = z
   .object({
     action: actionTypeSchema.describe('Action type to execute'),
@@ -105,26 +100,18 @@ export const abilityParamsSchema = z
     spot: spotTradeParamsSchema
       .optional()
       .describe('Spot trading parameters (required for spotBuy/spotSell)'),
-    // Spot cancel order params
-    spotCancelOrder: spotCancelOrderParamsSchema
-      .optional()
-      .describe('Cancel specific spot order (required for spotCancelOrder action)'),
-    // Spot cancel all params
-    spotCancelAll: spotCancelAllParamsSchema
-      .optional()
-      .describe('Cancel all spot orders for a symbol (required for spotCancelAll action)'),
     // Perp trading params
     perp: perpTradeParamsSchema
       .optional()
       .describe('Perpetual trading parameters (required for perpLong/perpShort)'),
-    // Perp cancel order params
-    perpCancelOrder: perpCancelOrderParamsSchema
+    // Cancel order params
+    cancelOrder: cancelOrderParamsSchema
       .optional()
-      .describe('Cancel specific perp order (required for perpCancelOrder action)'),
-    // Perp cancel all params
-    perpCancelAll: perpCancelAllParamsSchema
+      .describe('Cancel specific order (required for cancelOrder action)'),
+    // Cancel all orders for symbol params
+    cancelAllOrdersForSymbol: cancelAllOrdersForSymbolParamsSchema
       .optional()
-      .describe('Cancel all perp orders for a symbol (required for perpCancelAll action)'),
+      .describe('Cancel all orders for a symbol (required for cancelAllOrdersForSymbol action)'),
     // Arbitrum RPC URL
     arbitrumRpcUrl: z.string().optional().describe('Arbitrum RPC URL (required for precheck)'),
   })
@@ -134,11 +121,9 @@ export const abilityParamsSchema = z
       if (data.action === 'transferToSpot' || data.action === 'transferToPerp')
         return !!data.transfer;
       if (data.action === 'spotBuy' || data.action === 'spotSell') return !!data.spot;
-      if (data.action === 'spotCancelOrder') return !!data.spotCancelOrder;
-      if (data.action === 'spotCancelAll') return !!data.spotCancelAll;
       if (data.action === 'perpLong' || data.action === 'perpShort') return !!data.perp;
-      if (data.action === 'perpCancelOrder') return !!data.perpCancelOrder;
-      if (data.action === 'perpCancelAll') return !!data.perpCancelAll;
+      if (data.action === 'cancelOrder') return !!data.cancelOrder;
+      if (data.action === 'cancelAllOrdersForSymbol') return !!data.cancelAllOrdersForSymbol;
       return false;
     },
     {
@@ -182,6 +167,4 @@ export const executeSuccessSchema = z.object({
     .any()
     .optional()
     .describe('Cancel result (for spotCancelOrder/spotCancelAll action)'),
-  openOrders: z.array(z.any()).optional().describe('Open orders after execution'),
-  positions: z.any().optional().describe('Positions after execution'),
 });

packages/apps/ability-hyperliquid/src/lib/schemas.ts

@@ -1,28 +1,46 @@
 /**
- * Bridge contract address on Arbitrum Mainnet
- * Minimum deposit: 5 USDC + 1 USDC fee = 6 USDC total
+ * Action types for Hyperliquid ability
  */
-export const HYPERLIQUID_BRIDGE_ADDRESS_MAINNET = '0x2Df1c51E09aECF9cacB7bc98cB1742757f163dF7';
+export enum HyperliquidAction {
+  DEPOSIT = 'deposit',
+  TRANSFER_TO_SPOT = 'transferToSpot',
+  TRANSFER_TO_PERP = 'transferToPerp',
+  SPOT_BUY = 'spotBuy',
+  SPOT_SELL = 'spotSell',
+  PERP_LONG = 'perpLong',
+  PERP_SHORT = 'perpShort',
+  CANCEL_ORDER = 'cancelOrder',
+  CANCEL_ALL_ORDERS_FOR_SYMBOL = 'cancelAllOrdersForSymbol',
+}
 
 /**
- * Bridge contract address on Arbitrum Sepolia (Testnet)
+ * Time-in-force options for limit orders
  */
-export const HYPERLIQUID_BRIDGE_ADDRESS_TESTNET = '0xEdB6e5c456B7ccA2EB1e5c7007f4Ab80426CD20F';
+export enum TimeInForce {
+  /** Good Till Canceled - order stays active until filled or manually canceled */
+  GTC = 'Gtc',
+  /** Immediate Or Cancel - order fills immediately or cancels */
+  IOC = 'Ioc',
+  /** Add Liquidity Only - order only fills if it adds liquidity (maker only) */
+  ALO = 'Alo',
+}
 
 /**
- * USDC address on Arbitrum Mainnet (standard ERC20)
+ * Order type for trades
  */
+export enum OrderType {
+  LIMIT = 'limit',
+  MARKET = 'market',
+}
+
+export const HYPERLIQUID_BRIDGE_ADDRESS_MAINNET = '0x2Df1c51E09aECF9cacB7bc98cB1742757f163dF7';
+
+export const HYPERLIQUID_BRIDGE_ADDRESS_TESTNET = '0xEdB6e5c456B7ccA2EB1e5c7007f4Ab80426CD20F';
+
 export const ARBITRUM_USDC_ADDRESS_MAINNET = '0xaf88d065e77c8cC2239327C5EDb3A432268e5831';
 
-/**
- * USDC address on Arbitrum Sepolia Testnet (standard ERC20)
- */
 export const ARBITRUM_USDC_ADDRESS_TESTNET = '0x75faf114eafb1BDbe2F0316DF893fd58CE46AA4d';
 
-// Legacy exports for backwards compatibility
-export const HYPERLIQUID_BRIDGE_ADDRESS = HYPERLIQUID_BRIDGE_ADDRESS_MAINNET;
-export const ARBITRUM_USDC_ADDRESS = ARBITRUM_USDC_ADDRESS_MAINNET;
-
 export type DepositPrechecksResult = DepositPrechecksResultSuccess | DepositPrechecksResultFailure;
 
 export interface DepositPrechecksResultSuccess {